From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A323CC54E94 for ; Wed, 25 Jan 2023 02:38:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C9BA6B0071; Tue, 24 Jan 2023 21:38:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 279476B0072; Tue, 24 Jan 2023 21:38:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A786B0073; Tue, 24 Jan 2023 21:38:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 001666B0071 for ; Tue, 24 Jan 2023 21:38:46 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CF0EC1C64C6 for ; Wed, 25 Jan 2023 02:38:46 +0000 (UTC) X-FDA: 80391763452.17.8164C35 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2079.outbound.protection.outlook.com [40.107.220.79]) by imf02.hostedemail.com (Postfix) with ESMTP id BB64B80017 for ; Wed, 25 Jan 2023 02:38:43 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=R77DY01B; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf02.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.220.79 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674614323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tL4pVqVInIIfVafx5AFTpf1mjx5A3SHq45XheSa9eAk=; b=C3OAQW4+mwC728Skfe0t/Pa5t9bDeVMNzWuddUuHYGG+hl6LIKzmW5hndvJLxW39t6cpXK V40CRiDN6o8PyIzW7Cktk6Qzs2j2dFTyRordFDbuJtvsdBKqJnUTC49I6jBxaVYAInF5jc rRJReemjOC7RWTsX/t9QX2EsCgryakE= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=R77DY01B; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf02.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.220.79 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1674614323; a=rsa-sha256; cv=pass; b=lsmX/1DcobrZVJVJAaqdAXfSy+2eS92YxG1oingts4utGOb1xkwumHBnCvHMmX8/k4CbOy sHXO/gx+j0PN0C5NEFg94wFQmq9Xwmqiz9Ng97Qe0BW8rVIYkPWD9+l5tBIP+b8b/jjUWM 6svR/NuIvj6pev9LikL9+7sE/6JVSmI= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyFmrpDa4c2qwDHbqcmI7pshj/Njv7zKZzk2LlfPmth9O+2leG5vX/iRFUbCjEIZZMfM9Ldhv95biv9JHWewGInDI6oIXRyKGVp6vEs71cY81BmM7Z2OcoJ/VOGmstzuBWUxgwr930fGpfAdjzZQoaOnaJNSCyhhvVVSL6Q3I4ssjAEqmN9GubnwG+Mk22+IAYAIXxd1rf80XEVeCtGxQycBCnXFU7AioaEqryNQte/lAXzbJbjYHBKec3upI8fWDsIg7ENil1nESkJGiQOAyUeK0mEzL7iildnpNyUZiEFevyD178e5kuzZul9GJVICcslYOxYgTZpVoAYaTPR/jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tL4pVqVInIIfVafx5AFTpf1mjx5A3SHq45XheSa9eAk=; b=BTIVYf2p5vtXcu4SPWWyoCt/7fN4gsp4oz6/99GAmdfhTTNQTA9WCDp91msnSBPuS52sfeuagxC3Q87PZgKQQv/nGA9pXqAE69FOpQBQTHHYL+vAP50mGcaRIKcpfL3HW5j+XjrNANXzct1XX6TIowz7nGef4WtJjnqgiICJSAJVf2P2kifFLFYObZadMAEz7tT9UtYGJPo1Ojgcgidvy0CJ71NHBHMOnDrmfXOCuiW7TY5FzldFl7ynOoz17J8IgSxQc+i3tSGPDPd9+frCjY5DjvIpxuPqbbXLV/d3udLsYJ9KRMy9ZDNNBf3OeL426TQyv5AXFtQwMiejZv9oNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tL4pVqVInIIfVafx5AFTpf1mjx5A3SHq45XheSa9eAk=; b=R77DY01BXTHiWtUILM+So66mrybC2ZegD0ipQrk3AOK966DjLeO5Q0CKEnp3RUpvRK6n39ikx/1WdVPA4ZLafo76XE2EZLUEazWAVwd+Dro1OFjdvr7ADWkLsEJHRyyJcMzSK2ZwjVibY2ZidO8h6M7kHuX66nHvjEviV2ckcOni4/V0EE8chsM0ITsJPq89T53n1eE96FL1A4BMDCvBG2d7VsjRDSrVn88NUkyaQ0RqvB+uPtceosp7ScvRBNiVPadWOVVNbn1tcFaanophdyZK/1wFPNsGrY0CQ5MyjAs+goM/q50/aa0Bl9f9fphbB0oLxs8ma5s+KQwWb4qsVw== Received: from DM6PR02CA0164.namprd02.prod.outlook.com (2603:10b6:5:332::31) by IA1PR12MB6210.namprd12.prod.outlook.com (2603:10b6:208:3e6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Wed, 25 Jan 2023 02:38:41 +0000 Received: from DM6NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:5:332:cafe::72) by DM6PR02CA0164.outlook.office365.com (2603:10b6:5:332::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Wed, 25 Jan 2023 02:38:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT100.mail.protection.outlook.com (10.13.172.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13 via Frontend Transport; Wed, 25 Jan 2023 02:38:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:38:35 -0800 Received: from [10.110.48.28] (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Tue, 24 Jan 2023 18:38:34 -0800 Message-ID: <2392b0f1-9e28-8342-90a2-a1ec35484e1d@nvidia.com> Date: Tue, 24 Jan 2023 18:38:33 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 07/13] mm/gup: remove locked being NULL from faultin_vma_page_range() Content-Language: en-US To: Jason Gunthorpe CC: Alistair Popple , David Hildenbrand , David Howells , Christoph Hellwig , , "Mike Rapoport (IBM)" References: <7-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> From: John Hubbard In-Reply-To: <7-v2-987e91b59705+36b-gup_tidy_jgg@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT100:EE_|IA1PR12MB6210:EE_ X-MS-Office365-Filtering-Correlation-Id: baccb39b-f3f4-4037-a3cf-08dafe7d4505 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hIZ9Y6sUa4KlWJnEvo2X1At6+0YQPYYuNhGV6sG/7ui60BUpPicNgyJT75c5fXTZzCgW5phGUfJFRp5X8YtNEssfqXtbqHMhJ/h3lm9DV3tzzgSYblyQKm41YxluzB0sCmhNxT0SOSacSnW8ykLO2+mrF/Vgg7d6iQ2covF9iDlcpbY3yrpZYKK8H02XsZ7hbN7I5Qpc1m4i/6kedS8D/pfYBz/187vWFTJLXy8kniZjcZDzFxeyLj/06Dpygv0qM86nv9X6uIU0/hmHmYR/FRJGXKxBzG05BNLdhXxmF41P95pnYMukxBssJsDaN/aTgqv4qFEBPjdAzKDFjhA0GeBORCkX4DfgAw5UgSM7HqP2bd6KU/0HPOTUtvDCSFY+WPC9/C0jWvXqzqY2bcvnE4DkrOGJY21IHC4K+md5NpFMqDuArTvAneN6NXg1C+SwZpeLKvt8hWk2XTf9TadlLZzDpBC3tIc0enMfiOtEhTp9lWvQ9YoaxIQb19BbQmT//y39lijTknDmvYa3iFoRxGkx8v7t7aRcp7betcDPLW5K6Q2yBM5EoZO8wZ9ejGAATAPiMVJkM0gz9AysGIj0B5N122obGGgAU7/RwDh/HslmqGiukoQIApiqHxp8BLJlupGWCzgPyGiYVMNynFNjiuRR5F08FxE4O905KUzMM2CRrPCnB0LIFKhe6PtAU11nPbxP1na+Xd/AG5Rr36QdjYbZRqeRTbH7yIdtoqQJM0c= X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230025)(4636009)(346002)(396003)(136003)(39860400002)(376002)(451199018)(46966006)(36840700001)(40470700004)(37006003)(36756003)(40480700001)(86362001)(40460700003)(316002)(16576012)(54906003)(6636002)(31696002)(478600001)(4326008)(5660300002)(6862004)(70206006)(2906002)(8936002)(70586007)(8676002)(41300700001)(7636003)(36860700001)(356005)(16526019)(83380400001)(26005)(53546011)(2616005)(82310400005)(186003)(31686004)(82740400003)(47076005)(336012)(426003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 02:38:40.7304 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: baccb39b-f3f4-4037-a3cf-08dafe7d4505 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6210 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BB64B80017 X-Stat-Signature: kxnj5tu6yfgf6qphxujs85y15cqcydxr X-Rspam-User: X-HE-Tag: 1674614323-295678 X-HE-Meta: U2FsdGVkX1+pY2jKpFaWvKYsq+hQRkIzxkJpoKuPXup4GS50OzeOFeXJBAygI7/KJdWXLmC/7wsP04KYHsgS2rCa0bJ89h5O9WrWxnyKn4VC1442uzc+ME0M00ZNe5h59CWUF/3gO0YAC505qfexK5NhrgnYpryrVHQqo8w/TWwhmB1C+z36y0SKo3ZBexmRPvRpCnOwb4855et8YOalH0Vqppbw6GVgQFsen1XA35TK1L45Mn+t4YcoWi16uMY9lt05CByNOr1LiyH5NfNAgJQ3YO3TvDKp9S4xw4PbQWfJqZ7RnmVtP79z+E0GCtYLOF9maR8xuTBDRL03xr25nsPOpKbX90bhm6LyxQLk0FDX9gS9VPGcoowCLghlL4Ru5Csq+8ML6oL6DxCEc3PJqC8n0n6tnbJKLdLsfhp9dqlKSXUFxO7NI2YU9yDuHNzw5qSYtwWZeN4LtW0Ny2T08SxpHOQETQjOt5HJiN+DIzI6Iyrw0uMuUYdrGL9IDbalmnk4Envx7AJGx6d1T8P/nBCfiLsGIKPIIdPiOryr3GO0RahHNjNygPgZhiyK9nyu8HN/axlY40Xc3WidFu/U4QW86vdRx4gkHIcnBuuHIk/1F2Z9KZeo15vII8IlebVUwUUmmvXrtdWViLeIAXjQwbbXLAVAR1mJofwSf5C9YbFyEES/vQW8t+ta76B7AMRrqAsVuYu/IJmHgyVodDF2Qs5ORXnW+BKd3IvfNNpQ8sYuR6D+H0VcO/7A8X+Zz9/1AS6Z44prwlyD3+gSeYMMuPKm5S288MDZfzWBYxdLOZIkW37hL1cqqlhlIicf4b5oU9nxpg2Vs+dAfnzXGhl/NV3yXzOS8zKdLA2Hs0VEl+/FtzSebs2u02UnEJIlJIKUUxVHrcZDZYwGxbJY3KRENWTRjOVu2sPAN7Taxgr1bBxks8xvoCneBeiqrVeNvp3NxqUqAgkmJLOsZfuhGuU WogbDd1h 5k8mDXu4Nk8eFkUTScFr1Hl00RiELKvDl6ctfos7ulrcnXSbGYw0V5dsJzaIgJ0VOpyxl6t8wTFzknWVPVxAy6lTfGXLUjlA0TUZbAFko1/An9jnt0V3eBVwdrpOsUNMB7Ki3Q4Ww/XVAnCq6nk8vbex2MTBkH4og7XVDTBMyGqaRHCcCB1lbpfyHM1xlt2GnyN5H2Swj7ayqy8dU5vvan88XyfxW0IWQH7YXOad6a0WhXTDRBZljsOhIhM8XlCvYlwI3eWgi08Bh+dH5B8ljrNx+j58wSjf/4iHus59ekloe+c0td/IOfTHeHn8pG+MF5KNJva8liZ0J5vNcf5iIF3MKK6W0iDcM3IhH3v6uyRpt1dqZ7J1AuEqGCvyccYbxXSxQSNaJR1wFUpM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/24/23 12:34, Jason Gunthorpe wrote: > The only caller of this function always passes in a non-NULL locked, > so just remove this obsolete comment. > > Signed-off-by: Jason Gunthorpe > --- > mm/gup.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Reviewed-by: John Hubbard thanks, -- John Hubbard NVIDIA > > diff --git a/mm/gup.c b/mm/gup.c > index de1a5c64fdfdcf..dfb315b3f2950d 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1558,12 +1558,7 @@ long populate_vma_page_range(struct vm_area_struct *vma, > * code on error (see __get_user_pages()). > * > * vma->vm_mm->mmap_lock must be held. The range must be page-aligned and > - * covered by the VMA. > - * > - * If @locked is NULL, it may be held for read or write and will be unperturbed. > - * > - * If @locked is non-NULL, it must held for read only and may be released. If > - * it's released, *@locked will be set to 0. > + * covered by the VMA. If it's released, *@locked will be set to 0. > */ > long faultin_vma_page_range(struct vm_area_struct *vma, unsigned long start, > unsigned long end, bool write, int *locked)