Re: [PATCH v2 07/13] mm/gup: remove locked being NULL from faultin_vma_page_range()

[John Hubbard <jhubbard@nvidia.com>]

On 1/24/23 12:34, Jason Gunthorpe wrote:
> The only caller of this function always passes in a non-NULL locked,
> so just remove this obsolete comment.
> 
> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> ---
>   mm/gup.c | 7 +------
>   1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA

> 
> diff --git a/mm/gup.c b/mm/gup.c
> index de1a5c64fdfdcf..dfb315b3f2950d 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1558,12 +1558,7 @@ long populate_vma_page_range(struct vm_area_struct *vma,
>    * code on error (see __get_user_pages()).
>    *
>    * vma->vm_mm->mmap_lock must be held. The range must be page-aligned and
> - * covered by the VMA.
> - *
> - * If @locked is NULL, it may be held for read or write and will be unperturbed.
> - *
> - * If @locked is non-NULL, it must held for read only and may be released.  If
> - * it's released, *@locked will be set to 0.
> + * covered by the VMA. If it's released, *@locked will be set to 0.
>    */
>   long faultin_vma_page_range(struct vm_area_struct *vma, unsigned long start,
>   			    unsigned long end, bool write, int *locked)