From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B958EC64ED8 for ; Fri, 24 Feb 2023 20:14:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3DE26B0071; Fri, 24 Feb 2023 15:14:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEF076B0073; Fri, 24 Feb 2023 15:14:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDD516B0074; Fri, 24 Feb 2023 15:14:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC1B56B0071 for ; Fri, 24 Feb 2023 15:14:09 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 20D65A0E2B for ; Fri, 24 Feb 2023 20:14:09 +0000 (UTC) X-FDA: 80503287018.17.8F453CA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id DECB640011 for ; Fri, 24 Feb 2023 20:14:06 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OxD4tHud; spf=pass (imf17.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677269647; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s7+ZgZ9AOzeVCqtrS/SRc6vtP8hmyKMJwSCtnXuKzE0=; b=t4h07FuEJaiN0qreIUgEEEGucQEu9Ia09Up6PWpzUgm5U5hCps5VQeB8sDYW1iYIutriNy sf6JN47m4w9PJ0LzuGI2FfD8BD0cDn3kiG22q8lPurUH8fM754b59El5lyfyFMMDfUqxPu laWJ1mGU4nYapLvISJy7Gtax6IDvCV4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OxD4tHud; spf=pass (imf17.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677269647; a=rsa-sha256; cv=none; b=Dp/8vNLzVeXNie7KMCYoVRHjydzDop7DFTwQ2CQitin5cIrHdmfyEwXsrlK9+tF57KNr9U iB+eapMdooSYvy8KrOWdLtYuSbkG5LasdUrBlraR7oe/VS5w323m/jxTCW18DWK220o9Sh 0TDHAy9aeeh0t+YqDi1uh87F+ey+2F8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677269646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s7+ZgZ9AOzeVCqtrS/SRc6vtP8hmyKMJwSCtnXuKzE0=; b=OxD4tHudWmlpO8ia5EtewURbxDcFXpjFJKPWps/W9uU/eWo+UwuHyJnhZHMG/jdK7sgX9W DtmV4BCudclL+oMv84vYHs9qW1xJAnTnQl8bdO7SNN5W2RGIB2cDk0+gsCI55Z2usfMDgW 0oz+FVWVnb6gzxSM/6mewImbhpimalE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-577-QtwMliXsNPCmyUCOCF5vNw-1; Fri, 24 Feb 2023 15:14:00 -0500 X-MC-Unique: QtwMliXsNPCmyUCOCF5vNw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D3EAD95D601; Fri, 24 Feb 2023 20:13:59 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 218B72166B2B; Fri, 24 Feb 2023 20:13:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <2134430.1677240738@warthog.procyon.org.uk> <2009825.1677229488@warthog.procyon.org.uk> <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> <2213409.1677249075@warthog.procyon.org.uk> <2385089.1677258941@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, Linus Torvalds , Steve French , Vishal Moola , Andrew Morton , Jan Kara , Paulo Alcantara , Huang Ying , Baolin Wang , Xin Hao , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] cifs: Fix cifs_writepages_region() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2390710.1677269637.1@warthog.procyon.org.uk> Date: Fri, 24 Feb 2023 20:13:57 +0000 Message-ID: <2390711.1677269637@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DECB640011 X-Stat-Signature: 4ywa9pagik7mdbwteja8aftdig6ips33 X-HE-Tag: 1677269646-772434 X-HE-Meta: U2FsdGVkX1/77mXd8FUaFnaIoZaXffVFoGzk9QSr0JEbfzvrEDqx0v2h9NxrgAJE5TOnUOWICSE01lTIkYA8TDpV/PZouHykoFp1L0iJmUNmpmqMgxZQT7FORwjwuZ9GKS+zqhdM3wDSM+NdQbPQVE54IMotEm37dkTlLCQYbiJ1pVT5M2f1uFfN7KsX2SOJdjk3oKXP6lBX+6OT16YNi4Rx83jD2r+Fov/2sF7J9Ao3crSEiiMg9fifKWAC7YItj5JBezDUGfxh9oUNnOt5uwTg+ydAKR/IpQN00bsfPNkiUHAMD24btpbApeVDXGc+pGKdmv2QV15N+bKbyA9l+qj/e49PJfmvmqnhPSKAluMVoUsdIajGG1L4sDRmv+XDGo8/Pl5LNLI2IK3vo/lXJFx0+VjECduM/zwodrxXGLZrAIXQFRJB84ESKUpolrRVOifEjps/8dsjjK0qXJMiE8I0iL1UiYNPwhGpwDF/6wc/ZqTqGfr2V+vEVKW11fPFszyKc0v4qBn2SWezrZGQ2jou1xEOSnz3NIF/2eITvoxdaSJiaSPAPQf75ki2mrYIWya9qcjBnR9jX7d+6+U2xF9iN7s8zCoEjr9m8Yropa0rWMKia7k7j+/oEsheKLw6tGATITbdkJUmjwKskry/yHpYfqlTisC5JIJulFhKYr1LMw/YkETI90ZJsHSaM+nkZAOR3RlGuYgvF7YFA2BG+u0oCCcfegoIpibySXw4qVxl+wUlmwbZC1Sh9smkVSXCozJIRsS/dvGt7xLmdt7U5Tvu858NAmjAvJaymoVAkApWNi7Amn5xrbBmmdXnW9wm51Ak19ye1StdprrTLQOqLGP++dANeSZdaFa+QoCUO5U3KKT4y99HO9CDMXiSlq8GZpOYklnatzZhplBbePPJuwfz4LjyVJ8F2Ci/mcrkG0R+39PxkEjUFYw41jhCvOlhOXa1Y+q4dNHELLxNV8T 2czd9WHf lGz14BBprTgBBJ9qhMYtA/PFeHH+4luYRk/kRt2gAP2jUh0BWQYKsSQUOezXxF0jnRfmOZQOeLYnoWh3/uP29BndP5t3dHG9FuMEMzTGpTMoAQOvWSa0rRhjDFP3RYV2y8fa5WV/zC9wak0s5R/J7KpBiRa0qU1rAeEUbz3bdcOOQ6LIU/Y+GCtHHUZLtHHxY5suRt4rSU4I3wZeLrR4wfa/bfBUV8ZEBIweTZS4SkKWVSg1P0K0cq6RN04SASwdYQkoMm4HpXE/O6dfqjIqQbURVdgRUoHYDYDFpeQSv13fOc7KWue+JJ0Co4aqb4yZRpjjNVs2Hl+l98pAfnW0cZVw3qWYH6FAZpVAiR6brqdTLrEHkNjG4iiBXGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Matthew Wilcox wrote: > I don't understand why waiting for fscache here is even the right thing > to do. Then why do we have to wait for PG_writeback to complete? David