From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF34C3DA6D for ; Fri, 23 May 2025 09:06:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B82206B00C6; Fri, 23 May 2025 05:06:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0A596B00C9; Fri, 23 May 2025 05:06:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 984946B00CA; Fri, 23 May 2025 05:06:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 78D396B00C6 for ; Fri, 23 May 2025 05:06:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D05301D5666 for ; Fri, 23 May 2025 09:06:07 +0000 (UTC) X-FDA: 83473590774.28.C14820D Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf13.hostedemail.com (Postfix) with ESMTP id 4E8C820003 for ; Fri, 23 May 2025 09:06:05 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=SkOFV92L; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747991165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MFXFhyj5hZxVtHrsYoZGkrhBWl4qMvZabBrBeFVnmy4=; b=domqU4n7Lzgcgs08unVCyrRmewwA2MI1pTQ9/suhT6wcfXsP4PBh5OwUEwXJ8tgR3Pj1l4 KHOS16KOkcsNap3nFePdROBR1GWym8k/nfDfq7hJkYQY7Xi1K+9R5jVgMw4ygOOsqSPYPR gOwtZi1mQ+ixVLEn9gwy8p2htUClnhI= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=SkOFV92L; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf13.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747991165; a=rsa-sha256; cv=none; b=JFl4XcSpuyumgxNx0TWTvbg+/LElrQLyCm4vn2OPmx8C7MUouySIGyU/WhrSD1ynOaAjTz mXvEQ6X+4mWGOk5uid+KCm9S5MNi2oBsEb35VLAtf6YjtLejLLo1AxPDfSZHzNP1p6CRGq RV3sntIwPwd7xyxdHLDjKXwFQwZBWR8= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54N8tsLO025614; Fri, 23 May 2025 09:05:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=MFXFhy j5hZxVtHrsYoZGkrhBWl4qMvZabBrBeFVnmy4=; b=SkOFV92L3XkU3OrDFZIaDy mRRMg6VPDYqGjxpcG0jq+sViECUf7byqgTzcaTpHG60tsbHzUnhMPnbrXL/7Pu3L t7hHI9obh98BInP1nl6ey9APjOudj77uyvIBrOhv32wWtA91fnw5pkbLQWN48Xid +mSbsHBllrANQ1lwpLUzYLNk3zTXzr7Q0TdUfERXwrtFQtWzu6xr9Q0vNCqo4m2U x85/vf0Wvt9bZG0V85OoXaDnsiPx/tLuXeG5JAzxqSC5YPZzAMw8d6Gn9Oma3R0M hgvHV6w/2mxGu5qrFJaJuI1nclxPwq15TwNAnvnQ1/ynUmZf3ynp587FRy0B2Szw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46t9j9383c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 09:05:44 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54N91vao016921; Fri, 23 May 2025 09:05:43 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46t9j9382t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 09:05:43 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54N6Ni0w015480; Fri, 23 May 2025 09:05:42 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 46rwnnntne-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 May 2025 09:05:42 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54N95fsl9962236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 May 2025 09:05:42 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE6F458068; Fri, 23 May 2025 09:05:41 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F178858065; Fri, 23 May 2025 09:05:33 +0000 (GMT) Received: from [9.109.245.113] (unknown [9.109.245.113]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Fri, 23 May 2025 09:05:33 +0000 (GMT) Message-ID: <23858e11-4f8f-4ff0-a27d-9b720351af70@linux.ibm.com> Date: Fri, 23 May 2025 14:35:32 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v0 2/2] mm: sched: Batch-migrate misplaced pages To: Bharata B Rao , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Jonathan.Cameron@huawei.com, dave.hansen@intel.com, gourry@gourry.net, hannes@cmpxchg.org, mgorman@techsingularity.net, mingo@redhat.com, peterz@infradead.org, raghavendra.kt@amd.com, riel@surriel.com, rientjes@google.com, sj@kernel.org, weixugc@google.com, willy@infradead.org, ying.huang@linux.alibaba.com, ziy@nvidia.com, dave@stgolabs.net, nifan.cxl@gmail.com, joshua.hahnjy@gmail.com, xuezhengchu@huawei.com, yiannis@zptcorp.com, akpm@linux-foundation.org, david@redhat.com References: <20250521080238.209678-1-bharata@amd.com> <20250521080238.209678-3-bharata@amd.com> <825d87a7-8e9a-44f8-90f0-01cf3f1b8e52@amd.com> Content-Language: en-US From: Donet Tom In-Reply-To: <825d87a7-8e9a-44f8-90f0-01cf3f1b8e52@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: txXwPzSbCqLCiDU6S2zf_jLjQAFCWZp9 X-Authority-Analysis: v=2.4 cv=O6Y5vA9W c=1 sm=1 tr=0 ts=68303a68 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=wDc4EYGwM7oaOmFDgqMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTIzMDA3OSBTYWx0ZWRfXyG3mHBj7Ol3W aPZ1hFRDdMnMMq2XxJCjDneH8ULGmwHmTPnOBeEkAxS6cTuYRN9tTrGbaEC575KudBlcMAPkwRU DGODdRQNX0T6vNhQdPIHw+HBAnilb4c2THHRUL8MmoIeU0riRLXYkI5AGcrTZ1DUmyrPAHpK0BY ivJ5zeyRUitleu25CIYE06T1Xni+E0c6SYvEkEyXz5LLuklZhAi7SSbDPqVFZ3GHdjxYglN6EmS 42GK1BIuELGbXwdLXcsJnlGIoF0bYchH0R0vu5Srf2fSIoDSFlnTLPWY8xbTW3FQ3hUikNq8b2i i7abauvz9WUIQ0tV++flqJrrHGaxn9tuI3hamuVZh3gu5LQ7dhoSvuLeBSQFyYOCBmjbItDG722 eLF6CljQDXrfjtr2Dn3yr3+fwa01pQUIUs0SeCDKEDdDEtWt/AeHvOvcp3lC6+nCzwivWM8N X-Proofpoint-ORIG-GUID: 86aR9zfSZD9JJ7sIVz4jw26oheZbYmoU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-23_02,2025-05-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=885 phishscore=0 malwarescore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505160000 definitions=main-2505230079 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4E8C820003 X-Stat-Signature: c8i531ggfuqj11e6ac31ps9p8nm4yaz9 X-Rspam-User: X-HE-Tag: 1747991165-971803 X-HE-Meta: U2FsdGVkX19I0be+WYy7uVpa3iOn4q6/fqe/NsjWTs+S6SMx1ZjNQ5Uij3Ktu43Gsj7tgLYkKA+lS4eL7fejCMyQa+I4gr5BJg32xZ5Ufkjzptp0XaS0Iqs1bl1ckPBXym4SbYCWxYlKFD6elLwVbyLzCzjTUQofCaGgAcejZ2zTzTz5Bgu7EopZuGkRucpRSultWN2zAzHDUL4luWYP/JE2iKdPocAMXn3gX2vqETUEzmSwuQx7qCMTOn6NBr0/pkv6IWTUAtTKTmh3mNj9Qclbz4+2oV2SMU5rd9QG/1mZqB+izQAVeJVk2oLVRNy/JSKRZKftfiQoue41PckyH2DXl44Rgybcvqc7ZJGEcLbJMHrJmorhPLNyKLkh8NIWe2ZX9Swh175IUPaT2QoY5kXb/rivz7v5RN6u7utf0tN574uEB/X9AnwLe6DHHCwYDtem8LObzoo0EGMqn0BEK4FBZbLXCWY/XW7TKklHZzm/mIsdfGLXxgmVw3Jf1tLzHFVz0hbr4RbkKEh4bk77DFiwmD9iywzKF0hNtkC2ZlAEJj016vCxGia4OHtVQ82Cahn1/qHXsuw/wZF+EbUR+9/Av9tYO3Yzy6UmLMi3Bj+om5Oj8DzhD5MJ/u8U4cS0KOXZGy3ByBWVxQe/gD/2GlVqj8RDi8trzIDGlvavOqH+wHfqQh+uFedSeO4YaSnituCFSuG6VQLh7cZBtzXpj34vW+WR+NxkvQ6TFdLKB1s3+BKgwh5hmeiJOsPQj5iVcoVYN0ETCYWpZ03kP1Eu/ETdPP/gOerqBVYq6X/ieZ0BF7T+v2N9mqSjVz6iFXggdbtX60UAIw8lG5KqeNzMNuFgFWE46OTY3kU8HmVgroeYPK9F9UbdJfIVs7Ngmpg6/1v8VbmxASknuqKBI1cBRAihokHkH+Srj7+v1Teq/7WhuZcW9Onr6iih+2l8neSJZwlhil8P5gaIoIIlfho 7xUZ+TWi 6FKB0nVuuPJOgg5alsQm4mnlnQeKQmDMVOUfGsDKEdACIenVu+1OPwcvkHlQUVEeXmzSyEcxNMEccXuCuVVMWXGCi1KxbjH5jUgyQ0n+l57yPt08WYiV/51niLAlPnxNwSSPwIJw/kXtG8r0umCJjI4c+sUzpkefV94EYgIRZOhzQbrkL3etgz8Akn5PWMzUMXrvvFrVeeelpt2WrK4GKCHisNPImWnbuyZiooQnjp6/cqtcvBeBBKw5rhniTp+jnwza13rEQR1PakHRilsjbi1PShDKUNG9Dj4AOHQH5TtJQWA7ihFMj8lcrdnA1yZ0ASUFnczdwMuT/zs470jnqx8A+KA7nhO4QF7DrpXHj+8COK/3xbu5Sh6VTtaZBbg/3gw7hkIy0CFhzbIAEx9kmEk+l0b/6p5ZcLLTv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/22/25 10:09 AM, Bharata B Rao wrote: > Hi Donet, > > On 21-May-25 11:55 PM, Donet Tom wrote: >> >>> +static void migrate_queued_pages(struct list_head *migrate_list) >>> +{ >>> +    int cur_nid, nid; >>> +    struct folio *folio, *tmp; >>> +    LIST_HEAD(nid_list); >>> + >>> +    folio = list_entry(migrate_list, struct folio, lru); >>> +    cur_nid = folio_last_cpupid(folio); >> >> Hi Bharatha, >> >> This is target node ID right? > > Correct. > >> >> >>> + >>> +    list_for_each_entry_safe(folio, tmp, migrate_list, lru) { >>> +        nid = folio_xchg_last_cpupid(folio, -1); >> >> Just one doubt: to get the last CPU ID (target node ID) here, >> folio_xchg_last_cpupid() >> >> is used, whereas earlier folio_last_cpupid() was used. Is there a >> specific reason for >> >> using different functions? > > This function iterates over the isolated folios looking for the same > target_nid so that all of them can be migrated at once to the given > target_nid. Hence the first call just reads the target_nid from > last_cpupid field to note which nid is of interest in the current > iteration and the next call actually reads target_nid and resets the > last_cpupid field. Thank you, Bharata, for the clarification. > > Regards, > Bharata.