From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4556C7EE23 for ; Fri, 24 Feb 2023 17:23:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 315826B0078; Fri, 24 Feb 2023 12:23:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C4026B007B; Fri, 24 Feb 2023 12:23:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18C576B007D; Fri, 24 Feb 2023 12:23:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 06E2B6B0078 for ; Fri, 24 Feb 2023 12:23:07 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D6B371A0A83 for ; Fri, 24 Feb 2023 17:23:06 +0000 (UTC) X-FDA: 80502855972.01.51F4FD8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 1061F4001A for ; Fri, 24 Feb 2023 17:23:04 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wm59UIlb; spf=pass (imf17.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677259385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fRYK0MsjqV5B1YODg8uGsmehuhwPYk48TBRRGZHiyX4=; b=q2py/aUeFpMkKHi6bPutjloMnzRCOHfnJyg9qEA3J0iLuI9mZ1WeQTzke7l8XxlIiMOizE x5G/cjtxNbUlrosnZ/ma2Sv59xcACzg2GTJEHfCdf3r5XCu0UVKBgiLxDywDZ5zIKuqltV wXwhhJHcxa/7vzvLXcesh4PuXpK1a44= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wm59UIlb; spf=pass (imf17.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677259385; a=rsa-sha256; cv=none; b=2gjS4iTmTDJK3yd8qtVXnrTr1ztBrIJu7vLyEWUaD4WpgPIIGAPu0/AnMKw7DLkLIEeevr 2O/CodpCLSO1QCMgz0In5PNLDkjSlDNEFRDSfaqG9aHnjuSRQXfhaAQapE+08xhGioNua+ tk2OcRWu1m6qRr2+xCQvm0/4g5k6m+s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677259384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fRYK0MsjqV5B1YODg8uGsmehuhwPYk48TBRRGZHiyX4=; b=Wm59UIlbgISnv+VAmeKdz9Etd5yQq6EVGohHxk85t2RcKIKWOtTYYRZD4pFFqu8Am5k2Kt yzERNEMxjtZTRgCzrvKmY0iNVkvllaDA6wmW0tkRD4xxzLW6TKbehhZsXlS7n3HDmcdCqV XF/yjwO6I/+1xyGI/ayqk1zThNXQ11o= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-180-RVuFmVE2Owq3TQkaFqbO9A-1; Fri, 24 Feb 2023 12:23:00 -0500 X-MC-Unique: RVuFmVE2Owq3TQkaFqbO9A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F31093C01DE8; Fri, 24 Feb 2023 17:22:59 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F11A2166B29; Fri, 24 Feb 2023 17:22:58 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <2134430.1677240738@warthog.procyon.org.uk> <2009825.1677229488@warthog.procyon.org.uk> <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> <2213409.1677249075@warthog.procyon.org.uk> <2244151.1677251586@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, Steve French , Vishal Moola , Andrew Morton , Jan Kara , Paulo Alcantara , Matthew Wilcox , Huang Ying , Baolin Wang , Xin Hao , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] cifs: Improve use of filemap_get_folios_tag() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2385426.1677259377.1@warthog.procyon.org.uk> Date: Fri, 24 Feb 2023 17:22:57 +0000 Message-ID: <2385427.1677259377@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 1061F4001A X-Rspam-User: X-Stat-Signature: pd89rhnkdm96gbhhr4ysi9k4eeng5a1i X-HE-Tag: 1677259384-645676 X-HE-Meta: U2FsdGVkX18gPMBZw33lY+W7qRmH8bEV8g52We/mOhb1tE5Bh5anNgXmvql8H3+/tybJAfYmapuBsmxVgQsFbh3C8enq0Ebru18tPXCLsR6UZKym5qRthok7/La4YlTGOY80/75j/VJMOidQmr7AdO9kj6pG+K2Q0X4WvJNuzJbD2LtM+x22Ai43M2LN+TyRY4TGTmwE2jE4WMp/u89PiMyAUpy4aAfzkyum/9O60d4XB+f6RiWGM7l/lfYQA7hsfxT65RIRCR4aLaINxuZ22IAdlVyelC9dGPqXGJHAOrlNQE3Wre16tNtelsV7XMc6C3FqS0TH3p6B3A+aSu4WU6z3NBYHkqD+dSjZOte1hTovgZNcQ5B5609sYrporCHSkgbzJe6Pl1eAgpT1igrENIe6cmaM52/4WXYltZelRLHJvYrJm40erHCYOJFQ1gglJDQAdYMAJEcyXiVOJ8eNleYktTeDAlUlU0V6MsSamCjnDt+N+Wprt7Jg1F7AOhZ1QphWlmbSMWHOLBWf27tSYXpgsQA0s/oPKtM11jSkI4vb5lbPzGwRT39966IlI7C464hZjnDob2EHXI+VF/Pjc1dareZbYG/Mb0PKvYuUZ5Od84VvCRp1L5LoYaTcIt7s4hGC1pGS5LlTQ6oXhmWmL/alsXDZI0EufCZ34WqDn1wx/WR6bryaX1u0CtdrxGp3HPZjO4stg1B3yEVX/nT38ftY5ajFU8d5OUNdQhpChai+eC1zbSZKbX9Gg9JKG/DdehrWO8Ie5B/i8pd17wNXlZMhYMqll0qKMRW3MceMQBN16ZRV4X7SeQx7LGt0pjxKJtXZJrnRTPbmTHXNP+7LDONpmXWvSN3obpVhI7Bu3hb6dLd0SL3lG5O/fd57smb2Rg4VX8BEx+oIQBm6rCwMbe0aFRqtisFY/6yyLPz9QRAirOef8e7en92PZ/lUfX4w2gMzgLo8YP1575GI0SY sPZn8+0k Af8vzWymmw0xddveCiJqAHDC3RnvUGcilmLqpwLVAhffL01tbchp6xGZ6/2+aD3yZ/Kxpg8tx5jvdU7SIFnxLqSjBWis5zw3pGfzs3owMKs65/hMKSb8utWuf66MC01ORnc45Q0GBy/XnQYROOhN0T34WF3B9OrKABu1V0WpH7Rfhj1RtkSBTqwycqUVSvojWpxGMJwWqbm6PBMg7o81cTSYXI2rgo520e1kiY2+pViuC7idi+bybaF+J0hdCtF5WanPOX0SJTzU0Ar+EZH/iP1AByoEdh591XyF57aTgndKgSEy6F0H6g/Lz8Ojn2hJgdE2KnfQ/mtA/ClHGQpbN248qs45enieBjYQu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Linus Torvalds wrote: > Of course, I'd be even happier if Willy is right and the code could > use the generic write_cache_pages() and avoid all of these things > entirely. I'm not clear on why cifs and afs are being so different in > the first place, and some of the differences are just odd (like that > skip count). The main reason is that write_cache_pages() doesn't (and can't) check PG_fscache (btrfs uses PG_private_2 for other purposes). NFS, 9p and ceph, for the moment, don't cache files that are open for writing, but I'm intending to change that at some point. The intention is to unify the writepages code for at least 9p, afs, ceph and cifs in netfslib in the future. David