From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 597C7C6FA8E for ; Fri, 24 Feb 2023 17:19:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A6846B0074; Fri, 24 Feb 2023 12:19:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 956D36B0075; Fri, 24 Feb 2023 12:19:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81EC16B0078; Fri, 24 Feb 2023 12:19:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7010C6B0074 for ; Fri, 24 Feb 2023 12:19:37 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 349A9C0B09 for ; Fri, 24 Feb 2023 17:19:37 +0000 (UTC) X-FDA: 80502847194.20.4760184 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 6868180028 for ; Fri, 24 Feb 2023 17:19:35 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bDNzjsHK; spf=pass (imf30.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677259175; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f2WOQUqLPxDcFQ7Nje15yiuLa01CXfpErjUcBxi/r80=; b=bQ/6vk8wSaoxjomGI5TcMKIU6QxGcn/gwvj0KTv9szE8IW3fl3miKFkRbnvvKpNnQd91cD 8dYj6vgeW+J+7SXIHgTh2BR6ooZzUuLQNNEklrovLiwARav92liGTR51Zr7S7C7D22OtJF HnrDNzikAZSApoYfeCVnlIOIBe/eD7w= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bDNzjsHK; spf=pass (imf30.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677259175; a=rsa-sha256; cv=none; b=bVAd8EXtKYc13YuC21f9/VbL1xtLnEBNloAAyIVTJVYGTVjxWZsJ9WvqIMUStFSvepf9t6 /ABACOH1/Pv7UvRgeRQZA/UxdKUMitL7URFXZ2q9X3UK3CuUDVP2+I4BLcnkljjpu0P1JP twtFOTMU9IxlvLrqme+vOvL+CvPwgpY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677259174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f2WOQUqLPxDcFQ7Nje15yiuLa01CXfpErjUcBxi/r80=; b=bDNzjsHKpc0sATAdEY6kqOTBVWTOLFU9SZghP7YIfIO3AlXWOdDXzwCWY6SbxaZtE/8obF SSkuSXUhUUcunsQnvcDGWeEtQFNUy8eHQABbaJWAY6MWjrsaEmeubOToSOP8E9MkWLtYME EFYDayCtlNBV6iEIwysiciIdDrQ9c1c= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-593-NifuMESHMPOwiyBH2L3mAQ-1; Fri, 24 Feb 2023 12:19:31 -0500 X-MC-Unique: NifuMESHMPOwiyBH2L3mAQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C0DD3804531; Fri, 24 Feb 2023 17:19:30 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id C6C722026D4B; Fri, 24 Feb 2023 17:19:28 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <2009825.1677229488@warthog.procyon.org.uk> <20230220135225.91b0f28344c01d5306c31230@linux-foundation.org> <2134430.1677240738@warthog.procyon.org.uk> <2213409.1677249075@warthog.procyon.org.uk> To: Linus Torvalds Cc: dhowells@redhat.com, Steve French , Vishal Moola , Andrew Morton , Jan Kara , Paulo Alcantara , Matthew Wilcox , Huang Ying , Baolin Wang , Xin Hao , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC][PATCH] cifs: Fix cifs_writepages_region() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2385283.1677259167.1@warthog.procyon.org.uk> Date: Fri, 24 Feb 2023 17:19:27 +0000 Message-ID: <2385284.1677259167@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6868180028 X-Stat-Signature: qzrijambbo4ho43zuzxqs3jmw9fus189 X-HE-Tag: 1677259175-614597 X-HE-Meta: U2FsdGVkX19cc2ctlQD5CnyunA2n2kFcAtY62c64useqAMaP5XmezpwaC7AKG4tHk6S/0pcbhJxmP2FhhoZ58uf/0PEY1COEUcxut2i1icRb9BSVO8Z1s7QujdiiFyL7l/QOlw3kcB9Bs4YcSLHMm1bc0a5YN3IHmU3GfiFERS0+N9jqaGLXKTTR3vAkR+iaR6wcLgGhBUmc6wmUBHp+ykq0XvJJJedaKupUWmcE7LxgEJ35atM0vXz/giZSmpiwWm08wssjFHwDDJNqjUMjNGtUmncfgVrKfj5nsXOcCzTcn3oKikTl0ze+ejLGZuvkeoUzJU5GRMdSUvImxOQyMCGzrOWWjCmDp7qD66pFPcCQXxOoxaS9aKkmQ06I0eyAiiJSC0UFWwh0ByTI+DqQztY8BbmmQL6rw0EMOsZ0T6e2QTswCZQTCXz+GDN40sLq9e3aWEtwlT0eUZPeHLE/ZioA8lpPd8SZBgSw6ZGAlkP1fbxaqYazCwaW7wQ2P3S5bAjzkONAs76lck1GiYqsaTy9U0wzScb+DsmYNmchx3bI1Alx1IzJr+P7mr64rskaw1jAEJ4EfhB/FeqOVnRdr2YRLQ0zm1cI9XiM/E3GvFLQ3Z/zv7J/9GYd6Z/sPO1lsam2jYx9d53KcOUUprLkYCdJX9UMbeOxheNmzGzrU/dQcC1OPERtKvZPn/1CinwBsrKjYb610yTNSq53F788PoVJXbKP8tg/aiZOzC8btczRHa5D1JX0/xIC72safLlNLOUSwAiloT5pe7uIkGtIykKV7xCv1jnJyiO7T9pQBexU+1Aq0JMYKTqSOQtJFyMZ9xum1UJXQGpcWgZ/mOVluaxWrM5JKf7Bjlz2ilkp+LgT5HYR2pRcE8nfYd6im9vDGD72b0XpQpfEwwbfCe5nNI6oTAvocEURWyn4PIzEy5oIVrSxOilC1gRyNV4BRlh6cHTOmPRPNtjIA5wdy6o 4qeMt+Uo 4SBwZx1+6XN+uMFVIPYqEuWqVSXqA5gzQKDzmqC+wM6pi3eeInnQyeD266zTP9LOCJYwRxJs6tQwaUkkLYGi/6a+fD96eLza+g4nTWZ0hornhY1eJhqQThmfXfiCLmyMYwJQi6m9q0wtJjUuyxpzdwK5fHEunlPhW934kti25wn2CsHkSN1ypyAP7RebP9fi4xV9FihfDFAnj4eWsT8FjG5KDFh1qj81PhqmAiCTt4IJUwKnDhhqzGWLOOA1I/PXORdp5hpfbfA18WlIQLi6a7LLay/WcwZ6azq8Tt0FLMxjrwW+LKll9vbr5rzcdXgKNMSxOQZDK+xl0miDQ0GYxjcfxloZJM00qVPJo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Linus Torvalds wrote: > Can you humor me, and try if just removing that skip count thing > instead? IOW, this attached patch? That works too. > Because that whole "let's stop writing if we need to reschedule" sounds > truly odd (we have a cond_resched(), although it's per folio batch, not > per-folio), and the skip count logic doesn't make much sense to me either. The skip thing, in my code, is only used in WB_SYNC_NONE mode. If we hit 5 things in progress or rescheduling is required, we return to the caller on the basis that conflicting flushes appear to be happening in other threads. David