From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C6C7C00140 for ; Fri, 29 Jul 2022 01:07:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87E5A8E0001; Thu, 28 Jul 2022 21:07:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82D036B0072; Thu, 28 Jul 2022 21:07:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CD928E0001; Thu, 28 Jul 2022 21:07:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5C0186B0071 for ; Thu, 28 Jul 2022 21:07:19 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 285648100C for ; Fri, 29 Jul 2022 01:07:19 +0000 (UTC) X-FDA: 79738348998.18.5252EBA Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf23.hostedemail.com (Postfix) with ESMTP id 8452F14003C for ; Fri, 29 Jul 2022 01:07:17 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Lv8Rj6y3pzjXXh; Fri, 29 Jul 2022 09:04:17 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 29 Jul 2022 09:07:13 +0800 Subject: Re: [PATCH 2/6] hugetlb_cgroup: remove unneeded header file To: Mina Almasry CC: , , , References: <20220728121949.20985-1-linmiaohe@huawei.com> <20220728121949.20985-3-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <23841f02-2611-6945-868f-f8f15c325219@huawei.com> Date: Fri, 29 Jul 2022 09:07:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659056838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0jXyaBqsICzriP87acO0dcf9SGWXbIXLVTvH7pFxjvE=; b=orFV2pQUBF5+n6befv7EGNeren0jMdg7eGG9Wdcj3srN3hJsOMEGM33/zuiIRmHGsDPZxg dWNsnvaYF5p4AXNp6/UNLz0LQ3Of6yAWULhv9RNFe+J5Z43yKx+Nxb27hgTcWIW+EsMagj kv/fQTWehNH4PmpFLyn31FpfWjt8cB8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659056838; a=rsa-sha256; cv=none; b=X+/MfRIFQjIeATTwMwqLPez8fGrcdNw/89KDRBE8No2mAm3q38fGMi7mFNhO4d5lzc6hkA a92vaaMBKN4UjogklwuZwngQY9QGjZ5Tclkgo10x20LFCAMSmhS/B4MgXaeFptAIWEuDby Mce+3/7nktJIvphvhfuzG217LxS/sJs= X-Stat-Signature: ske41ek15rp5ubmtq6upekh6xipie36w X-Rspamd-Queue-Id: 8452F14003C X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspamd-Server: rspam06 X-HE-Tag: 1659056837-186 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000178, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/29 2:02, Mina Almasry wrote: > On Thu, Jul 28, 2022 at 10:45 AM Mina Almasry wrote: >> >> On Thu, Jul 28, 2022 at 5:20 AM Miaohe Lin wrote: >>> >>> The header file slab.h is unneeded now. Remove it. >>> >>> Signed-off-by: Miaohe Lin >> >> Acked-by: Mina Almasry >> > > Actually, sorry, but this file calls kzalloc_node() which comes from > linux/slab.h, no? Can we keep the include then? slab.h is probably > included by other include files but for clarity it's better that > hugetlb_cgroup.c to include slab.h if it is calling functions declared > there. I have browsed the code to verify it but I still missed kzalloc_node in this file. Will drop this patch. Many thanks for your review. > >>> --- >>> mm/hugetlb_cgroup.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c >>> index d16eb00c947d..99e9a367e1e5 100644 >>> --- a/mm/hugetlb_cgroup.c >>> +++ b/mm/hugetlb_cgroup.c >>> @@ -19,7 +19,6 @@ >>> >>> #include >>> #include >>> -#include >>> #include >>> #include >>> >>> -- >>> 2.23.0 >>> > . >