From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB8FCFA753 for ; Fri, 4 Oct 2024 09:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53F1E6B040B; Fri, 4 Oct 2024 05:52:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EFB66B040C; Fri, 4 Oct 2024 05:52:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3416D6B040D; Fri, 4 Oct 2024 05:52:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 15A156B040B for ; Fri, 4 Oct 2024 05:52:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A67AB1412BD for ; Fri, 4 Oct 2024 09:52:15 +0000 (UTC) X-FDA: 82635454230.14.B89765F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf30.hostedemail.com (Postfix) with ESMTP id 4384180014 for ; Fri, 4 Oct 2024 09:52:13 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cagAmj1g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Trsgu59; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cagAmj1g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Trsgu59; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728035427; a=rsa-sha256; cv=none; b=YlaxKPaOvCOm0pX165hiRk9SKpNT1Td8MaCSpWcZOf9gkme5Gd4WUe240qtIyGctTZHqMA GrP2KV5id2qnxFXP1OwpVenSdKOW/EcToPQOJHMrPZT+acZKog/JAnSpYNBo8g+GEEJ0/P nSNmFwovq4aTq8jmoZp32/QsswDHlDQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cagAmj1g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Trsgu59; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cagAmj1g; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=1Trsgu59; dmarc=none; spf=pass (imf30.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728035427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mc45QIIZl/Qv9AcqyKNAc7BYIVWe6fly1TOftOh3r88=; b=20Wv/FPk5VezwEBLDSFLnTOJi9zrv8ibsZYqhfDMAUJi/C3Xl86pt/p5KOQ0/q5mT3WMVX SjDaCYSc7KA6aaGCQbbEtsBBxQrT+biyEpT6IslXu6BscUIgZBPLdklPXlx2lcq3Js872A BEqBsnLrAB7msm5VWaFlUayC0V3wKPw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 68E3A21C47; Fri, 4 Oct 2024 09:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728035531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mc45QIIZl/Qv9AcqyKNAc7BYIVWe6fly1TOftOh3r88=; b=cagAmj1gsa5olAOlWI2EUp67UYywND8Ve3s3HBa+Upq3yje+tjHDHg/ZOt+bC/A0O6OPHg 2/8GPZAfAEvTKse7fFYRe4mB8KIYvDTIl/zZxBbXUvDJSjyOEYszEO219VdLlW9quJD00n jdmbU4r/ZxdPKTiGExyFb4Kur4kCGMI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728035531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mc45QIIZl/Qv9AcqyKNAc7BYIVWe6fly1TOftOh3r88=; b=1Trsgu59AyH2TrCpc/SvAZjuFHpkA+Y/tAgMdQbIv9G4xtTSXO65L9I5w7KPzH2wxPHh3t OjgyzvwoQWs0trAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728035531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mc45QIIZl/Qv9AcqyKNAc7BYIVWe6fly1TOftOh3r88=; b=cagAmj1gsa5olAOlWI2EUp67UYywND8Ve3s3HBa+Upq3yje+tjHDHg/ZOt+bC/A0O6OPHg 2/8GPZAfAEvTKse7fFYRe4mB8KIYvDTIl/zZxBbXUvDJSjyOEYszEO219VdLlW9quJD00n jdmbU4r/ZxdPKTiGExyFb4Kur4kCGMI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728035531; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Mc45QIIZl/Qv9AcqyKNAc7BYIVWe6fly1TOftOh3r88=; b=1Trsgu59AyH2TrCpc/SvAZjuFHpkA+Y/tAgMdQbIv9G4xtTSXO65L9I5w7KPzH2wxPHh3t OjgyzvwoQWs0trAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3D2F513A6E; Fri, 4 Oct 2024 09:52:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0mwbDsu6/2YTEgAAD6G6ig (envelope-from ); Fri, 04 Oct 2024 09:52:11 +0000 Message-ID: <2382d6e1-7719-4bf9-8a4a-1e2c32ee7c9f@suse.cz> Date: Fri, 4 Oct 2024 11:52:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/5] mm/slub: Improve data handling of krealloc() when orig_size is enabled Content-Language: en-US From: Vlastimil Babka To: Marco Elver Cc: Feng Tang , Andrew Morton , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Shuah Khan , David Gow , Danilo Krummrich , Alexander Potapenko , Andrey Ryabinin , Dmitry Vyukov , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Eric Dumazet References: <20240911064535.557650-1-feng.tang@intel.com> <49ef066d-d001-411e-8db7-f064bdc2104c@suse.cz> Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <49ef066d-d001-411e-8db7-f064bdc2104c@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4384180014 X-Stat-Signature: hjbkucrzpbqgo7tfamknb7jpp1xmmoxq X-Rspam-User: X-HE-Tag: 1728035533-33940 X-HE-Meta: U2FsdGVkX1+qIyEkU/nlzyxld5URCdcQ0jGRL77W27rTAtVxebUeDNkTN2FFJZV4fMZb3GU+vrMV8eiwbZ7XgEIaxvhdM/+Mi0qibhtBAvUt383VUvz7gDFznQQP7M8IpeMu2VTzpPHJHZw6+nNh8XVlhzGjhvzee7DMyluoSc83wGRx1xGy92h6QcTnNfG8BOQf36Y5UshZYTQFlArXfSSmuQUl/287XTm8LLJIdY59hLHjRZ5PU33xvRs/Z/OkFl9RPMB8Pg0C2M7xRwzUadtUOVSZ4DMHrbjWvLxu9CB2paTDLqiQgwvN1j1bN009noDxxHIzccpwX/aOAf6/BdQkzshlTLkpEtSfF00ILcUvc+Nlk061wDh7FCMd0p9Nydp2wtEvV6vKgpPGZDmS+9OHySgUT0IXDp5lN8ZlBTf4g3Vire0Ry6j8z7FNjjA4todmrThdqcS2OQVTKQnA8WM5+7sLT02IKxzXYVJ0NfxCPWvk5OGm6v3VrVgMhVqcZ10+aO4JUzcgD/FJAcL5snSMjKGHCDhHGWk0405Lv6WX2xEritArTJn5sPl/YXBDhVHOHCk7e79oUc+uWEttwzeSQIlOdYc6WiSx3eQKgEDGeEN0w0LgoRrmflrBE+U8KJRfLHInVpc8jVdpc6Qzdl2q55gmXrVjxgzE/cbuR5wxW3l2cGfYU6YQRJS3yDrcQj2Y/VcclY0IsrQNpebTsF3WXvQbsKM/OnXmSnBSgJEd/Kb6ob6N1AFD2x68h64GroNJ2Hg/A0N2H08yAjJPfjKneQ5pCS9vMkJ2m5SzD+UUfyJynwS2JCnFxQ0r/Ks6ZGM4J6I9eSUshlFjc721EXOFx/jJ2N1roF3iD3y9pUKtdafsaFoZK97sYmTKfBO6pHHNE02D3nTohVhYQjj6mXd5T8U/wB6utolIKjPEWO8S7aZRh8042izKb1sAi5mjzzwC5vyXaY00huCGipZ 3VVOQ9xj rEFbps8P/Jy60Cza4gGlK5/H7Y58fXVWvDs+BKfPjJHT/UfRd2tX7h+sibgn8Mx+8WLh28nxoPdv9FEesHXe9zOyW7o/tEtg2ZfocR/2p8bOP4iM9FILSsteGZ+eKt6Z/WM8QRbuFgzFUSayuccgE90P98kX4vRP4nZVsypo4kFIC9g3QO72iXT9Xl35a9D3cPyGelKe91ATNr72YxhNZ1zlggGVA8KOfpZL4Oi/1s3u2+W4nMujnEKFHKPKcQv1TlQ8cPO64qjIEet9SqIaUoQMnFjhnwaKHWVZmML+DwyFJSa640MS7g7RVFooEya8q8FWd91lPzmKD2AAzD11L01jGQ4Ui9RZM7i50GVURdXzfum27n06DNtlFWjKib/OHifPnDkaQ8YmUT+SXv/FjnDsdpw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/4/24 11:18, Vlastimil Babka wrote: > On 10/4/24 08:44, Marco Elver wrote: > > I think it's commit d0a38fad51cc7 doing in __do_krealloc() > > - ks = ksize(p); > + > + s = virt_to_cache(p); > + orig_size = get_orig_size(s, (void *)p); > + ks = s->object_size; > > so for kfence objects we don't get their actual allocation size but the > potentially larger bucket size? > > I guess we could do: > > ks = kfence_ksize(p) ?: s->object_size; > > ? Hmm this probably is not the whole story, we also have: - memcpy(ret, kasan_reset_tag(p), ks); + if (orig_size) + memcpy(ret, kasan_reset_tag(p), orig_size); orig_size for kfence will be again s->object_size so the memcpy might be a (read) buffer overflow from a kfence allocation. I think get_orig_size() should perhaps return kfence_ksize(p) for kfence allocations, in addition to the change above. Or alternatively we don't change get_orig_size() (in a different commit) at all, but __do_krealloc() will have an "if is_kfence_address()" that sets both orig_size and ks to kfence_ksize(p) appropriately. That might be easier to follow. But either way means rewriting 2 commits. I think it's indeed better to drop the series now from -next and submit a v3. Vlastimil >> Thanks, >> -- Marco >