From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33FBC433F5 for ; Fri, 15 Apr 2022 15:59:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EC856B0073; Fri, 15 Apr 2022 11:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39BC66B0074; Fri, 15 Apr 2022 11:59:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28B446B0075; Fri, 15 Apr 2022 11:59:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 1BC7C6B0073 for ; Fri, 15 Apr 2022 11:59:55 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id E2ED180EF0 for ; Fri, 15 Apr 2022 15:59:54 +0000 (UTC) X-FDA: 79359574308.03.B450C54 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf25.hostedemail.com (Postfix) with ESMTP id 48CCFA0009 for ; Fri, 15 Apr 2022 15:59:54 +0000 (UTC) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1650038391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PQ/j24GLveqMBhfRtNWZjMAkMOjKnLZwyOdqxvR91eI=; b=mq1u7phOZ+sAnnnDp1ut5N/Hn+PA19vw5Hl9rcpv4HyniUFuSb1Ip8FJOHuMswzWFy+9ht G5wznUQt6OzRY0vmj9yjRRAktUQzidZUihGdWrXAUX1HC67JUtN80CUN3HdqKdjn3iV6M3 kaYCMNoSWwyJP7mKhn1RmZsaj+BJg6c= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [PATCH 1/4] kselftests: memcg: update the oom group leaf events test X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin In-Reply-To: <20220415140817.ljznpvacne6nchg5@dev0025.ash9.facebook.com> Date: Fri, 15 Apr 2022 08:59:48 -0700 Cc: Andrew Morton , Tejun Heo , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Johannes Weiner , Michal Hocko , Shakeel Butt , Chris Down Message-Id: <238226BB-6536-489A-BCC7-4611F86D036D@linux.dev> References: <20220415140817.ljznpvacne6nchg5@dev0025.ash9.facebook.com> To: David Vernet X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Rspam-User: X-Rspamd-Queue-Id: 48CCFA0009 X-Stat-Signature: wkkrefrusgr6denwx3nznh7dfra3oeie Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=mq1u7phO; spf=pass (imf25.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Rspamd-Server: rspam01 X-HE-Tag: 1650038394-944230 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Apr 15, 2022, at 7:08 AM, David Vernet wrote: >=20 > =EF=BB=BFOn Thu, Apr 14, 2022 at 05:01:30PM -0700, Roman Gushchin wrote: >> Commit 9852ae3fe529 ("mm, memcg: consider subtrees in memory.events") mad= e >> memory.events recursive: all events are propagated upwards by the >> tree. It was a change in semantics. >=20 > In one of our offline discussions you mentioned that we may want to > consider having the test take mount options into account. If we decide to > go that route we should probably have this testcase take memory_localevent= s > into account as well. If so, I'm happy to take care of that in a follow-on= > patch after this is merged as I already have a patch locally that reads an= d > parses /proc/mounts to detect these mount options. It would be great, thank you! >> - if (cg_read_key_long(parent, "memory.events", "oom_kill ") !=3D 0) >> + if (cg_read_key_long(parent, "memory.events", "oom_kill ") <=3D 0) >> goto cleanup; >>=20 >> ret =3D KSFT_PASS; >> --=20 >> 2.35.1 >>=20 >=20 > Looks good, thanks. >=20 > Reviewed-by: David Vernet Thanks!=