From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E8FFE77188 for ; Thu, 2 Jan 2025 16:54:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 721196B00B0; Thu, 2 Jan 2025 11:54:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D17E6B00D5; Thu, 2 Jan 2025 11:54:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5BF246B00B4; Thu, 2 Jan 2025 11:54:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3ECAA6B00D5 for ; Thu, 2 Jan 2025 11:54:06 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C90A0AE080 for ; Thu, 2 Jan 2025 16:54:05 +0000 (UTC) X-FDA: 82963106268.09.27F1CFF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 6684940010 for ; Thu, 2 Jan 2025 16:53:11 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735836784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sCBzV52clRZewxzKvyJND6V/O+edFzGisB1HLVdLyCA=; b=DI6uKtsaIFUaeAFq5yV/wbNuusAI3hpKjJrT+TwHbMrbuUsZLxLUDrpycA/s26XzbLAt6t pTtChaKn3yMv1fMdf9MKMUb+CuEdoBzYa/fwcyH0ViThICH2Og7N9wzY/hMzZOiotZ9SRR FzmGKyfCB5uuJQR+dwV73ZqJjk51qU4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735836784; a=rsa-sha256; cv=none; b=dw32Yad2FTu7fmGYodigmoUUmcRMueq+pWFv/8tBdufhISW9WiL46UMDRXr1YnSsbNVwkr xSQ//iIW4bgi5/JhK0ROjThDdHEY3+zNvMAUj2+fmYOFjGVy1X3t4Yk8h0GvJADj+7prvD rULSJkPA0p6FyfiVsqtDbrWJAr4tEnU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf04.hostedemail.com: domain of kevin.brodsky@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=kevin.brodsky@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E835A11FB; Thu, 2 Jan 2025 08:54:30 -0800 (PST) Received: from [10.57.91.208] (unknown [10.57.91.208]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3632B3F673; Thu, 2 Jan 2025 08:53:54 -0800 (PST) Message-ID: <237a3bf6-c24f-4feb-8d3d-bb3beb2fd18e@arm.com> Date: Thu, 2 Jan 2025 17:53:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/15] mm: pgtable: add statistics for P4D level page table To: Qi Zheng , peterz@infradead.org, agordeev@linux.ibm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com Cc: linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <2fa644e37ab917292f5c342e40fa805aa91afbbd.1735549103.git.zhengqi.arch@bytedance.com> Content-Language: en-GB From: Kevin Brodsky In-Reply-To: <2fa644e37ab917292f5c342e40fa805aa91afbbd.1735549103.git.zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6684940010 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: yen569hctn5zw1pk461k6grrun975y8x X-HE-Tag: 1735836791-882801 X-HE-Meta: U2FsdGVkX1+15jXobSpiuRwwVgvK1noBzlwvxJB2+rsqd4Sev48FLShpN6R1F+bb4KlVyQVVrIXev+Hlb5YU7rBZWkpsdrNA8ivmLgMpAK1fvmAF+sIl1t5GbbPysoiSuQgT0ZGy6HN1SZX96xJIxfOlFWIkeu6GDzeqNDp20rGm0OtxuJ3kWl9jyfbmmRZY2xKdhSnybdx6XjMCygoiS8hMfQoxwZslUCjPTLyWW/X3tSRofr/hZ/z6V8dfl1C7d6ovvo8CeNz6a4RY6sjRHNqkia5qw/tTXSu4CKKQPMaUWXGWHZJoN+1jBw3pgaluvK7MG1mAikPt71j/P0qLJ+7PGcEu7GAOilQ80amTaNPTlkcTC0gHZAfXh1x+pzzgmcqvgElHy+P5WbZ0otE3WGAGSaOE5py06HK+zTw6nR4/lZAcdUAYNDx/OEpYA6T+GjTrSvCxi3JmbLnnIlNYB5qUzbGwYJhCX94HCTv6ecjfrAntNeQfHDupVvxCkYVQBfi+ntrCnJbMwvCI4A6c5RkiJH6Ay48+xkHTF7PeHgpoK06d2VeIfPA4b7bSAu72o5fH8uE15ECSrdXdDR/1C+mV+GSHsT9tCfngMyyw8ljuIjqGXnc2vrN7r9UgMOYgqNjEjdVVl1FQU9yiLLywXbauF9wKoCmP43wkU6hLUnG6kwqa+x7CAzzV5poWjtaUkhD246zREoHhc32M7DJI+g18/OKT366sxoiTP7pbhyXzMnDl6mnUxtl/fXS4ahRMzDX3J1UIRrgeQUhsZUijfrW99q0iQdtIGa33pwVAOr934+JOWN4rakf7Xw7Cml4UvqD3R1/dNfY19dOCj4L5hIxCFxD3j1TQbFeafeMolysaJ6/YpIAOI4rWb/tdlyUok+hjoptj0Mcr8DprRZELZH8z69OX8m0AsYG0o7rPiBD02MFSmeKpG9gq1YuCAUx+Fv6hxCaRs4izMGOzGft 8Ways7YX 5Em8wdbxNnaYg6QhGATCYkdZGCzaxaKiUXK0bYRsRGo0jg/hXMG+8RkEf9yNmoqAvnYn6rH4E6CMrVqkslTW6kTwzOyvASkdhMEusw1vEcbt4szveJfzjsK57X4RaOKAqsSk0w+JbCXOd6KVuZPxddkuT7dMjLPsJHyDU+itNkb3rE03YFbE3rZQelgL9CkSrC/tDRetb1A3d6sAwyBHSWSHbWA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30/12/2024 10:07, Qi Zheng wrote: > diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h > index 551d614d3369c..3466fbe2e508d 100644 > --- a/arch/riscv/include/asm/pgalloc.h > +++ b/arch/riscv/include/asm/pgalloc.h > @@ -108,8 +108,12 @@ static inline void __pud_free_tlb(struct mmu_gather *tlb, pud_t *pud, > static inline void __p4d_free_tlb(struct mmu_gather *tlb, p4d_t *p4d, > unsigned long addr) > { > - if (pgtable_l5_enabled) > + if (pgtable_l5_enabled) { > + struct ptdesc *ptdesc = virt_to_ptdesc(p4d); > + > + pagetable_p4d_dtor(ptdesc); > riscv_tlb_remove_ptdesc(tlb, virt_to_ptdesc(p4d)); Nit: could use the new ptdesc variable here instead of calling virt_to_ptdesc(). - Kevin