From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB41C3ABDA for ; Wed, 14 May 2025 23:43:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A04036B00CB; Wed, 14 May 2025 19:43:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98EEE6B00CC; Wed, 14 May 2025 19:43:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78F666B00CD; Wed, 14 May 2025 19:43:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 57DD46B00CB for ; Wed, 14 May 2025 19:43:10 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A528380406 for ; Wed, 14 May 2025 23:43:09 +0000 (UTC) X-FDA: 83443141698.18.85748B2 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf25.hostedemail.com (Postfix) with ESMTP id D773FA0008 for ; Wed, 14 May 2025 23:43:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZMALogJD; spf=pass (imf25.hostedemail.com: domain of 3iiolaAsKCLsbdlfsmfzuohhpphmf.dpnmjovy-nnlwbdl.psh@flex--ackerleytng.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3iiolaAsKCLsbdlfsmfzuohhpphmf.dpnmjovy-nnlwbdl.psh@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747266187; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XWIedWKko0q0l+HgOrPiOCPy2pv6PChoegA1MNDO8i4=; b=jYJgbGVkxfsa2D/xKGYH/d1iNd9FfFuJUwRGCIh0CuaBzLb7a1uC/3dvhqtr0fuw67HGKY 7/TalVSP/xIQQLuKvcpgEWP14FqmbTU09te68SZJtFChw7Slqv+O7uKtUpQ0mww0q4fXcK OSiHTE4X4iF/qmswQ4f+NyWNq6LOBfw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZMALogJD; spf=pass (imf25.hostedemail.com: domain of 3iiolaAsKCLsbdlfsmfzuohhpphmf.dpnmjovy-nnlwbdl.psh@flex--ackerleytng.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3iiolaAsKCLsbdlfsmfzuohhpphmf.dpnmjovy-nnlwbdl.psh@flex--ackerleytng.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747266187; a=rsa-sha256; cv=none; b=ID1MzElK1nHaNnu6vRCEpDQv6DxN0hPPhsiVL2gHWUSXcjspOm9GxjCiLh/spEmqKxlLJi a4GigxryYla3a/39x+ny596Ore4qGeHCDZQlNaox15LwSZDZGUC6Cj0JjBNSSIjA1tPthn KtjB8Hj1K7TyBni+eW3r6LO3BW3Jq9U= Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-30c1c4a8274so359362a91.2 for ; Wed, 14 May 2025 16:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747266187; x=1747870987; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=XWIedWKko0q0l+HgOrPiOCPy2pv6PChoegA1MNDO8i4=; b=ZMALogJDRaP1hMb6rMUqIXS/fiSf/aurpiEOg2e724h50aYM45vwJTM5YflR9UyUEx UVtr/cjUOMbCZk4Z6vfLGx6i8SubMELYWajPlvBNNHq1GjxriK+HgDovBHIwCGiQOaYX Lc1AsVzdBATiTrEwr0wvtt8ZSk+xuK+uNddA4BTx9J8msC219FCsF0InuwIM7oOkz5gJ xCOLw9f5syzFSXqy/4RjdHFQRMFVUKSiHZ6VqK2BnnpJoG+qrUItHtqDDZFj3Rv4tLMJ Lv/PtVW7TLuPJt28jzUI74vM329qDd95x0rJ/DLraXsXqrgENinLs2Lu8HrZZ4LXFWvg R//w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747266187; x=1747870987; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XWIedWKko0q0l+HgOrPiOCPy2pv6PChoegA1MNDO8i4=; b=FYpFqI6bMrss62h/hGNOa+4ao03c1LqcgAD+nDs6rVaFFr2YmzCSDBdK+l4e/Z1H/v yFuWVIRfutxda5n3lu2MAqaypxrZjYpOrNXnB5M3OFRcxFC0VEiBd+ol4vy1hZTtZia1 K7QbMnfWuQGBCkE6bCdV0VZsFtXciW5GDpvgaOw2GtCT0Wtp1mOnKnxihuVml0BRGKpj kybHLItcVw5QiG+mQ31RfLNl47vgmCo3twJoqq6Gz71gXRQJTeuu8IRmMVTAfhh9auA3 lv7wb4alvaCtQA6Y8WpOVOJF9GKaNftB4Hoge521j7wmOLVYIxa/9fDyeObWrVKwyA0Q gADA== X-Forwarded-Encrypted: i=1; AJvYcCXCxWvAd+ZZEEfB3CmruuJRI+xt7pKuyWDd1xUpi8xfub419j6QkequuiTbN6dWgTSYpiGo1FfY9Q==@kvack.org X-Gm-Message-State: AOJu0Yxv2y2+sTTyANF5HgeM6pow09nYlGdJuZJSFcXiMMTFY5LHHPbe eNx7F07xSpXoNJQXiInRXDbvCI7tJOz77jdFDNO2isbcE9ERQ1T4eZ62oPs2A5l4dtjIaj28/4u ypJXaZ082JCS2anXt5a/Ouw== X-Google-Smtp-Source: AGHT+IHesn3dOk6yj3lGjW9oGrsY34nuGC/3KJDKeYlh++dy4L/FXCRUxYHz7/nH0P6zJ+IQHTR/7qIbv4kewoYFFA== X-Received: from pjbso17.prod.google.com ([2002:a17:90b:1f91:b0:301:2679:9d9]) (user=ackerleytng job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:4a85:b0:30a:3dde:6af4 with SMTP id 98e67ed59e1d1-30e2e687a50mr6882572a91.31.1747266186577; Wed, 14 May 2025 16:43:06 -0700 (PDT) Date: Wed, 14 May 2025 16:41:45 -0700 In-Reply-To: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.49.0.1045.g170613ef41-goog Message-ID: <237590b163506821120734a0c8aad95d9c7ef299.1747264138.git.ackerleytng@google.com> Subject: [RFC PATCH v2 06/51] KVM: Query guest_memfd for private/shared status From: Ackerley Tng To: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org Cc: ackerleytng@google.com, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, usama.arif@bytedance.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: D773FA0008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3u1xocf93zp8cym5nue119aniw4ei3mk X-HE-Tag: 1747266187-342983 X-HE-Meta: U2FsdGVkX188C/Ww2PLz4c9zf+YCEzq4q0b9F4Va9mKg/LgDa9KaEIi3UjzkQWsLLVCCc5zXlL/FH7Ys7gAwaD31K/iUL4CM7FNeMP3EHvXp3yAb5czWWACA1xzV8Hb1BGk5E+QiNpP4e1+DZIetpplOkgJ/9PkdASPU7kEPMmKIzwB7gPAKVv99rQWKzyJWJscGgGunfzZveCpb3AlS46LmC+LF6anW1d496QdLmBMhUo5aO1BPiTZlsgoBf3yVi90aSn4pCNVndv1zxZWOZ4iYp9GrMJ6LxBYac/9u0yzI/jCkO4cAQit3pYRgFI0u/owyTyiTN24flGntwSEkggZhDYoDCY9i/n1d+MN25E4nOWeIzsLjYHTXp8DBAmApi99gjsLkILQAtUzlDG0zrg+u0sp9JShBUTFAmHJv+XZ/rmq/bn6jES10R+WUOm8TlfDUPtlfRRZhXYRqyJW3mQLtlCma03H+Rc6sCU3NVn47j5uGyshKCAF8MDkvjtXAXeMtk32KZzewUHqgSW1dw1kcU3IsNdV5sRScv/Tn0gEDFHKnoYggBpsBEGM68ZDv8LlV1BBALxbQr8d021ftBUBUfFyOgvLTeHBu7sFGVN3vA1RvuuGQ+yd70chWn2CO4MnQJMUrRfHeUXEMDtnI00rjP1dchPiMvcr+tN0R/QlYDGmOQ851o/DY80ZAJAAdXmjHnQteECU31jIgoamCuaBPodO0t+TkKq4pSWyEM/45ugTxgct8qgA3bnSEJT9wjewzn7xFhFlxOntRJ0YdfUfe80TAQ7bN1rijkOyu/OhS7gKa2vCLXrtvUzeZz6gOt57FMF4j3PHUxSjLpoZwhueFOLxHWRBjsb4p2mUpHsvhym579qYESzpJUI6VuxSM09NCAwN1yx12IjLKNjtB79B+eBmuFKTLygEFzjIiAAGjKIPe964YpL8X6kSYYtdJNPtyeCnRYMpYLYYQzjH CuV7e/vg f3OyBPX5C2sOkTVuxflqsNBJFDuKGaQi9SHOdnGGrYEJjaoiR9DWDGdh82C252zeHV1fR8tlYz6w3IXqU4+RjtowhcK/o4BbV6iB0qbjjfJtE5EPwgPm6OoxyXch6Yvqz15jlCZV12m5SIHquvp2chkykFYAOC9RZaCerdkGyf/nKd5eamkPSCOM0+BFNma5n6QIiECxV+kWx+V13VCe9RsJ6XcDWZBwuJjCZjfhrUKUAS/rakvFwPd5ohXX7cuWu8RVNqQFmPNdA4TznCtykX6Do1zEPK7vJ1yMPaGjerxRVXFqlokA+WjvlGKQilmG0nATDBuXf30jkXyZj38Ve08lonQNOSnaNbx2XBHztZ2sIScwj4mPHvsDBI05j1uIl8gsIADk8mfdWgyExPNAc8Y8l+C0eQWB9NtFavGHU4YF5TCPD3s3wDhulXzqn1qW5Pw0EBDy5nrmmQ4vnkHBXjluIWEfSkeWzww8c3Me/i4fv/MhBBypPAZtPmfwuiF/NKX/Gzi0aFiE6cKVsV1U20W8z2wRW1k+WfeN1aSg07yRRd+/Vb4dQ9femTKwVQkKYoi9hk3yfJ2NhX9E9tKX2LN4ynmYpwxDhIYm46mozp1U275uhAElGW91g4IfZDrlNlERlwsJBhA9NtILlBpiub3mVAdfihh8jVU30RrohGjo7edJZXcr76cnpy2Vm/3ij7xGC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Query guest_memfd for private/shared status if those guest_memfds track private/shared status. With this patch, Coco VMs can use guest_memfd for both shared and private memory. If Coco VMs choose to use guest_memfd for both shared and private memory, by creating guest_memfd with the GUEST_MEMFD_FLAG_SUPPORT_SHARED flag, guest_memfd will be used to provide the private/shared status of the memory, instead of kvm->mem_attr_array. Change-Id: I8f23d7995c12242aa4e09ccf5ec19360e9c9ed83 Signed-off-by: Ackerley Tng --- include/linux/kvm_host.h | 19 ++++++++++++------- virt/kvm/guest_memfd.c | 22 ++++++++++++++++++++++ 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index b317392453a5..91279e05e010 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -2508,12 +2508,22 @@ static inline void kvm_prepare_memory_fault_exit(struct kvm_vcpu *vcpu, } #ifdef CONFIG_KVM_GMEM_SHARED_MEM + bool kvm_gmem_memslot_supports_shared(const struct kvm_memory_slot *slot); +bool kvm_gmem_is_private(struct kvm_memory_slot *slot, gfn_t gfn); + #else + static inline bool kvm_gmem_memslot_supports_shared(const struct kvm_memory_slot *slot) { return false; } + +static inline bool kvm_gmem_is_private(struct kvm_memory_slot *slot, gfn_t gfn) +{ + return false; +} + #endif /* CONFIG_KVM_GMEM_SHARED_MEM */ #ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES @@ -2544,13 +2554,8 @@ static inline bool kvm_mem_is_private(struct kvm *kvm, gfn_t gfn) return false; slot = gfn_to_memslot(kvm, gfn); - if (kvm_slot_has_gmem(slot) && kvm_gmem_memslot_supports_shared(slot)) { - /* - * For now, memslots only support in-place shared memory if the - * host is allowed to mmap memory (i.e., non-Coco VMs). - */ - return false; - } + if (kvm_slot_has_gmem(slot) && kvm_gmem_memslot_supports_shared(slot)) + return kvm_gmem_is_private(slot, gfn); return kvm_get_memory_attributes(kvm, gfn) & KVM_MEMORY_ATTRIBUTE_PRIVATE; } diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index 6f6c4d298f8f..853e989bdcb2 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -865,6 +865,28 @@ bool kvm_gmem_memslot_supports_shared(const struct kvm_memory_slot *slot) } EXPORT_SYMBOL_GPL(kvm_gmem_memslot_supports_shared); +bool kvm_gmem_is_private(struct kvm_memory_slot *slot, gfn_t gfn) +{ + struct inode *inode; + struct file *file; + pgoff_t index; + bool ret; + + file = kvm_gmem_get_file(slot); + if (!file) + return false; + + index = kvm_gmem_get_index(slot, gfn); + inode = file_inode(file); + + filemap_invalidate_lock_shared(inode->i_mapping); + ret = kvm_gmem_shareability_get(inode, index) == SHAREABILITY_GUEST; + filemap_invalidate_unlock_shared(inode->i_mapping); + + fput(file); + return ret; +} + #else #define kvm_gmem_mmap NULL #endif /* CONFIG_KVM_GMEM_SHARED_MEM */ -- 2.49.0.1045.g170613ef41-goog