From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546CAC7EE23 for ; Mon, 22 May 2023 06:28:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CF19900003; Mon, 22 May 2023 02:28:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87F1D900002; Mon, 22 May 2023 02:28:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 746E3900003; Mon, 22 May 2023 02:28:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 61864900002 for ; Mon, 22 May 2023 02:28:50 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 30E12AE8A2 for ; Mon, 22 May 2023 06:28:50 +0000 (UTC) X-FDA: 80816912820.27.81E0B4D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 5EB98140012 for ; Mon, 22 May 2023 06:28:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jUgBzgRw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684736928; a=rsa-sha256; cv=none; b=Tgj2TbAmi0Vbe2hwwq3+PQrcm8qcGHjV63JHFIulnn4QlALUW1aIhGeOaEMKlMmP/i7hWI F8u2BjwRh9f1dTckv9HOb0MfI+Zi84jynzGqQ5Hvcxv/yFANpB5+lerU27Rw6CbAF4LH1E aQSDae+9lT5KqY1CZbxqIRolYM5wZ78= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jUgBzgRw; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684736928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=L51D923F/Qnr60svKwlOplic/YuXek4iXgzeRvfwk/0=; b=MxPRIRkwPh1eSYQ1zL0n2qWyLji4e5k5KSv6Wtehn9j6/hue3GkCeO8h+Ksm9o3F/eoUzI sivtYtmrCVm0p+LDIZJ7fEyDYiGBsQS1LJtMW6QdifM93U81UyyujIDb5w+0EQyfEOkzi4 HOoW/Mc45C09HdgV3aOmN3JIjtNh6ag= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684736926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L51D923F/Qnr60svKwlOplic/YuXek4iXgzeRvfwk/0=; b=jUgBzgRwxkEHLEFkFI8T56Io54rId9HVEsft1yembiZf5PTE7m4KFDkXilv1ynZWEE82BW K18bKuvMztqkn9R+oTjr1ZezI4nR9UVN3l3c3rP2jR+/a2aoQq8TFfwWQTv4uTDoVsjgDq IZdvKxnFDBv68t9d1+JmOma3baZOObY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-_JqmLVPHOXevZRe0HvSLeg-1; Mon, 22 May 2023 02:28:41 -0400 X-MC-Unique: _JqmLVPHOXevZRe0HvSLeg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1F1933C025A2; Mon, 22 May 2023 06:28:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.39.192.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id EC7E8C54184; Mon, 22 May 2023 06:28:36 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <376ab23b-52d0-d7fd-2dd9-414cbb474e01@linux.alibaba.com> References: <376ab23b-52d0-d7fd-2dd9-414cbb474e01@linux.alibaba.com> <20230520000049.2226926-1-dhowells@redhat.com> <20230520000049.2226926-23-dhowells@redhat.com> To: Joseph Qi Cc: dhowells@redhat.com, Jens Axboe , Al Viro , Christoph Hellwig , Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , Christian Brauner , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v21 22/30] ocfs2: Provide a splice-read stub MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2362050.1684736916.1@warthog.procyon.org.uk> Date: Mon, 22 May 2023 07:28:36 +0100 Message-ID: <2362051.1684736916@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5EB98140012 X-Stat-Signature: bbmj5oqextjmpeix4h1y63wqt3mg4ttf X-HE-Tag: 1684736927-364923 X-HE-Meta: U2FsdGVkX1/CfML93elp9hk6N3geGlaALzTNPAEAKqaFTX2kUWhYfDz5Z9w/6RExOFhI/Ekl3rUCCXSO9hTM67ub0ME3szt0aqvcW1FntyLIwQ4y/xS2W08G5/Vfimxc2kFsMsWE7Re8CGGcexgcbDMvtcZfOkhePPKxdiAP4A13m7xrvJyNvE+ox4rRtIg4HKN0WEPvlHAxvK6LGLW8OPYPTO+APi9DvAacZCL15gAcigOoR2gdtnI8EyCbjWrVHslDPT4bShxU9FqpFkwxRiHFQmjm6YRhpi+EFBSzfZpjtbz9O7EMcXohii672cImOnfd7mKZ1FQcA4wcqsxMrC/1+3v82bspauX332UUpRU0cJEI6U+RV5E+1r4TQLUZMlPrIXM5VbfPASieGlgzVj2C2xS8HrlJvHuR8u+BKPHHGY6s+4BdSsL0bPSzG4MqzGPemdo/+KAl9151bCT0IVjWZMae5f707UqE+qA544H3fWDM6acycJ09bQRoyYay86c6Zx4VF95H/9w5ReGUXt6ptE8kSS1Cq5BVi7ysJfYgLCykL7TInwCnoegpJvy5IEGJVW3vNy70Wq+s8oE8W5YMY/5YKTtNYprDiAMQD8wxd6chWLYks0gWYGSyaXNjMOSjdaiYbDSQ45G14wCeb2bDkYRHeCyiMTgt8CJVCrIyBmI+U02vvw1jY2r3+kg92/rcTyj6Li6WMOq0gadfCYeZw+cFU1OIpaWSea4BLfZLrQ3+qebLCMOzx99Wdun3geEWdoQGUgfJtsdC1HG59TW4op16UHqZvq8g1Hy+/IGpXxeK2XYYWV/kmgwlOU1idvQX9yPdvBWsZVeuQMsXBncRQSrI0k6tNkgm5YOojtE/t+K/hNnrYMW5T0e79PeJfOxkTHBG0x1gl2ggbpve+5WjPQ5l2FmG0f1bqIDRdXAix64myaZ2o/6yIXxR6xcDMMzopKJD1LdsAwiUibU EYHT967m nO8DJxB+euMYrMSHxmXLZY+OyFtz06FfFta/GFKLaWpq+BkVkNnLKZPF5+/bNmh0xOVuKx7juEXU1RZn4QnUmwpCsY2pEXDnbdNQGK7erFF5xWv0EM0jDKRq4cAFzI1qGy2d9F+PEYp6nAzxrY60iMuw2Z0laK1WrGCN6R7doXBTF2OCeBKUCWykWPumQ9YCOcPPh+iIc/whMugo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Joseph Qi wrote: > Don't see direct IO logic now. Am I missing something? See that patch description ;-) Provide a splice_read stub for ocfs2. This emits trace lines and does an atime lock/update before calling filemap_splice_read(). Splicing from direct I/O is handled by the caller. David