From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F8FEC02192 for ; Wed, 5 Feb 2025 09:56:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17F4C280008; Wed, 5 Feb 2025 04:56:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 130F96B008A; Wed, 5 Feb 2025 04:56:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9E36280008; Wed, 5 Feb 2025 04:56:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C7F676B0088 for ; Wed, 5 Feb 2025 04:56:10 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D6EBB14089D for ; Wed, 5 Feb 2025 09:54:24 +0000 (UTC) X-FDA: 83085430848.04.624BEBF Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 67CD0140008 for ; Wed, 5 Feb 2025 09:54:22 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LQMQT1aI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kmTL0CwK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LQMQT1aI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kmTL0CwK; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738749262; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vTFG8kIeokGQUgs5K8Ypg712elT/hSmq4TMx2Mj0Glg=; b=Phor+xMKdkavKgdTQAT5pydaEa+nNCiDmF722Vk9T3J8enLUEr1s3qCq30TWgt1LI++Vdh 0qtCc+KWYedqJ0AwYWIAvrTNns1FaqwJMHrGXNDfvprBRrrGesi915NqtuGuv/tfvtO087 A+p4ue7s02Ae2AgZObxyPZspnboMN9Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738749262; a=rsa-sha256; cv=none; b=Mnao0t4SGXUCz7nJmyzWevwfYTl96CzN1GcQda3hXp+WS668O2o3GLt8CAfV8PMt0RJjbd rUsLeuPEyrvmQsPUDq1gHmjF8ZH6rj1McHoJTAn5/XAebfrAhVNQbvn4On33nZj1PX2o86 3PMe3VENClaT+M3l5Ar4SF8fjCcQ8mw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LQMQT1aI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kmTL0CwK; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=LQMQT1aI; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=kmTL0CwK; spf=pass (imf26.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B30A91F458; Wed, 5 Feb 2025 09:54:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738749260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vTFG8kIeokGQUgs5K8Ypg712elT/hSmq4TMx2Mj0Glg=; b=LQMQT1aIO8cyLBrCXa15H8kb+Gw2p2uqwnvw7wOhRSpUgeo2Yx3jnw77n7BT26UlMXtv5D 3JTApThSVPKwSyBJRBVsNp7VIeN10kHlXKUljup/erjBaIoZ5XvU3CAfkIbQ1Ens5YNfrv AxxcuLWqB3yuAuu4HIy3d761wkKkllE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738749260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vTFG8kIeokGQUgs5K8Ypg712elT/hSmq4TMx2Mj0Glg=; b=kmTL0CwK4sd0YkSGxp7tmdlQphs0wVF1hJZdj9/M6soMDcFf/TPzzH9Zpk0H+0OdvPjnc8 Gq9ZCVvzSnoDUxDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1738749260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vTFG8kIeokGQUgs5K8Ypg712elT/hSmq4TMx2Mj0Glg=; b=LQMQT1aIO8cyLBrCXa15H8kb+Gw2p2uqwnvw7wOhRSpUgeo2Yx3jnw77n7BT26UlMXtv5D 3JTApThSVPKwSyBJRBVsNp7VIeN10kHlXKUljup/erjBaIoZ5XvU3CAfkIbQ1Ens5YNfrv AxxcuLWqB3yuAuu4HIy3d761wkKkllE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1738749260; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=vTFG8kIeokGQUgs5K8Ypg712elT/hSmq4TMx2Mj0Glg=; b=kmTL0CwK4sd0YkSGxp7tmdlQphs0wVF1hJZdj9/M6soMDcFf/TPzzH9Zpk0H+0OdvPjnc8 Gq9ZCVvzSnoDUxDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8950D13694; Wed, 5 Feb 2025 09:54:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0i3uH0w1o2epNwAAD6G6ig (envelope-from ); Wed, 05 Feb 2025 09:54:20 +0000 Message-ID: <2361b5e8-4126-48e0-89b4-5cd854ce666b@suse.cz> Date: Wed, 5 Feb 2025 10:54:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] slab, rcu: move and consolidate TINY_RCU kvfree_rcu() to SLAB To: Christoph Lameter , David Rientjes , "Paul E. McKenney" , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki Cc: Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org References: <20250203-slub-tiny-kfree_rcu-v1-0-d4428bf9a8a1@suse.cz> Content-Language: en-US From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250203-slub-tiny-kfree_rcu-v1-0-d4428bf9a8a1@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: b6s6pdd4agxzbhkdiaefzhehjt81pf4b X-Rspamd-Queue-Id: 67CD0140008 X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1738749262-91309 X-HE-Meta: U2FsdGVkX1/kmGWbPek7ttkaTY4cBYZwh7M3awyNmy/4uMhlfBLF6Sa+Smp0neScIaY/DdHWBvdZCVdzZCWyFvY5igOVVhAIVUKmviKmCm4eZfh7PKDyCQJb3K1Olqdvf3qVW0adUMFqgrX7Q/rCoL3M9LoAvd/BxocR2xPLqBLX6gYj02RLBlHrF0MQVmI5kxNjZpHBGr39rlg0mGkzTciUof2Nc6N7Tz7Lk5ZOt0a2k63iK2dsaHXZyFuVH9FEh/+Xr4nsHVqtR1M2up+fL75i66mFc3FlgpPxQPT+zjZzFmZFO51UpQxtfvizWuQsWIoC7BhrNDTLHOjTrSN5xtv3d6zs/IEJvK5gf3wDiFRUJCzYHrwmFd4vcq/IR3TL3VFOlD1cKbVUR2syHErnGvBjVgz85wg96pX4WE8DySB7rb/bOLC5NU7mACDiO1KzH1MvvCLXTEzPUjoDz0TV+tSGFuWEi6bT2IXDLGavHAfA+MXD3a53w+DZTeFohvpRWOAw0hOS6XJ6EOPBH7pymzuaU4uNkuKKFjoQ2Btbt735ntnFwchJbTw8t52iLSNHQkgcdR8zbB1CTDIxDDrvL91+Q5vW+87IRp2K3n7Ry4h5qlhjMKIWq6BvjP6AF2lhcimVZvkc4hxYeQz5S4iz1xT/3gPjBqfXRLqNGv8B41E8yyx8iMG4fzzKSTo9Wgpu9cdD+aYvWxVcSoLyuJM+rrClx6y6sJlagM4wHzZ+UBe9opmEoXdHiFFskyjKsNgFbQHt2H1ANXLkTBQL6Rqdfyn9moGwBPdP5UORGz+MGhcBqzIxT+CyT9+sxxdNWQZaGi7MIpK2qBfHfUxYSElILy2l93hKyQdYyra/NWALMbaYbSLLnVUJs/CtFs1MoIMK3kgnz73a9eCHrUJT2sQZ/bWIXHOyrjMStwuO9Mn03x3WoiroPg997lBPw94nRg3ZpT+LMCbU3gHoGBMogrJ YTdQhi6y ox1FbxIYmyJhPTy6T3bSq5uYq5hpf45+K9Z6SFRO8YNsIAfj70UIZ4Vs5BePc4K/0nZ8H6cORWmAChWCVUx8w+kQ3p7Q7C5dUzHaKhYcaaQUcFIin3fOiFxxMsTQaa9uhvTDtH678MTeeHkcvIs8gp4gbLmRNRlEr1aiWcPxTVjlnvC1A8/yw30SGVRjKiDEwiW5GSFRg8rd2InpbQnXlaUtdCyjshW9WitKcusQr6dTKeInKjuNmQ0Jb9zYHhk59GLeErzevsgFqhnQR90a/hxuDie9Wu8AQJ6bTlQF8W/ogfz8oNqTaiRbukh8oYQSEJvx5Pw+7TzOVKrMLYakzWBXZr3cQAI/ch7aQAkXDCH9rPDNXIQ0vnq5XROxDcMvsfUv3DDAtl3CsQAcxPwS2+AE1uscG4TqECu1dRF93aGmxYnE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/3/25 10:28, Vlastimil Babka wrote: > Following the move of the TREE_RCU batching kvfree_rcu() implementation > to slab, we still have the simple non-batching implementation in tiny > RCU, and RCU implementation specific ifdefs in slab code. > > Finish the move and integration into slab. Allow using the simple > call_rcu() based implementation also with tree RCU when SLUB_TINY is > enabled, as its goal is also to limit memory footprint with less concern > for top performance. > > In order to avoid RCU having to recognize the fake callback function > pointers (__is_kvfree_rcu_offset()) when handling call_rcu(), implement > a callback that can calculate the object's address from the embedded > rcu_head pointer without knowing the specific offset (previously SLOB > would not have made it possible, but it's gone now). > > After this series, AFAIK only the following kvfree_rcu specific code > remains in RCU: > > - a call to kfree_rcu_scheduler_running() from rcu_set_runtime_mode() > > - probably necessary and a generic registration interface would be > unnecessary bloat? > > - declarations of kfree_rcu() API in include/linux/rcupdate.h > > - could be moved to slab.h after checking for/fixing up potential > missing includes > > git tree: > https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=b4/slub-tiny-kfree_rcu > > Changes since RFC [1]: > - Rebased to v6.14-rc1 > - Fixed build errors reported by bots. > - Changed where kvfree_call_rcu() is moved to in patch 1 to avoid another > move in patch 4. > - R-b's by Ulad and Joel > - Fix a memory leak in kvfree_rcu_list() thanks to Ulad > - Various comments' improvements and fixes (Joel, Ulad) > - Rename config to CONFIG_KFREE_RCU_BATCHED (Ulad) > > Due to changes, didn't keep Paul's Tested-by (but thanks!) > > Will include in slab/for-next if no objection. Now done, thanks to Paul for testing and Harry for reviews!