From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E81C4C6FD1D for ; Thu, 30 Mar 2023 04:33:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 639E26B0072; Thu, 30 Mar 2023 00:33:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E9E66B0074; Thu, 30 Mar 2023 00:33:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B1206B0075; Thu, 30 Mar 2023 00:33:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3D0EB6B0072 for ; Thu, 30 Mar 2023 00:33:11 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05E23A07F6 for ; Thu, 30 Mar 2023 04:33:11 +0000 (UTC) X-FDA: 80624294982.02.9AB9F1A Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf13.hostedemail.com (Postfix) with ESMTP id 92FE520003 for ; Thu, 30 Mar 2023 04:33:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of zhangqing@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=zhangqing@loongson.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680150781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7v9P1XQ2IsfaOpFQO1XMCg59C4NbmctoVAztoQeGuiI=; b=KdBQEV9LHQoi0g6iLRNPs2Cgxg21pwbzOrIM0HS1KiuOxAZf8d9IZXOnK48fIvUHQZMZpq hXHtp4eT6qN6ZEVw6LVyfa5KzsWU7PNiLF3J1knN48nCQ2alvZBIDvYodaqjSt9Jzwg36P 7Smau09tCbshFM43WL0HgDy+D6rmuxY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf13.hostedemail.com: domain of zhangqing@loongson.cn designates 114.242.206.163 as permitted sender) smtp.mailfrom=zhangqing@loongson.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680150781; a=rsa-sha256; cv=none; b=MzXejZkWfonqxZyVZ0kbM+cgVx5LsrQA4YPhaYot7/rnVw62RQqhAIJjTmueUQaDpTwDZ1 Q5l5PKf85NATbPAHxpewHulP0vBGZx1yHfeau0jFKmxQ1qRQPOKsy+xmcxQ4PMpzVfVQIl YpGJf39H6Odk91YdvrIFrS2W5xHwm6c= Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8Bxttj4ECVkkDcUAA--.35921S3; Thu, 30 Mar 2023 12:32:56 +0800 (CST) Received: from [10.130.0.102] (unknown [113.200.148.30]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxLuT1ECVkA_oQAA--.48468S3; Thu, 30 Mar 2023 12:32:55 +0800 (CST) Subject: Re: [PATCH] LoongArch: Add kernel address sanitizer support To: Andrey Konovalov Cc: Jonathan Corbet , Huacai Chen , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , WANG Xuerui , Jiaxun Yang , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Andrey Ryabinin References: <20230328111714.2056-1-zhangqing@loongson.cn> From: Qing Zhang Message-ID: <2360000f-7292-9da8-d6b5-94b125c5f2b0@loongson.cn> Date: Thu, 30 Mar 2023 12:32:53 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID:AQAAf8CxLuT1ECVkA_oQAA--.48468S3 X-CM-SenderInfo: x2kd0wptlqwqxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBjvJXoWrKF4xGryxJF48Aw18Ww4UJwb_yoW8Jr4rpa 40kF95trsYyFn2vwn2kw1rtryjyF1fury3WFn8Kw1Fya4Y9Fy8KF1rGa4rCFykXrWxGw1Y vwnFyasxJr4UAaDanT9S1TB71UUUUjUqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bS8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1l n4kS14v26r1Y6r17M2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6x ACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1DMcIj6I8E 87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0V AS07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km 07C267AKxVWUXVWUAwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r 1rMI8E67AF67kF1VAFwI0_GFv_WrylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWU JVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r 1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1U YxBIdaVFxhVjvjDU0xZFpf9x07jFE__UUUUU= X-Rspamd-Queue-Id: 92FE520003 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: xswxq4anmcg35wf6ib5kbxt7hatpp3wo X-HE-Tag: 1680150780-445355 X-HE-Meta: U2FsdGVkX19nFIIJMzgkKi9raLkfazqvYrlPIsn7yaFrfJmSxdutfXhU5BqOeNLfcxEiDNygY+a5AvPck+rHVj7379RvsdIdiWe0mHbh2Aea2CPhZrf5UI+mq3xd5iEvI1qE1xs9j8FYyU+iQN51WYalgkk7T+b+9jbwSN5wLJDnoAErYQL9nKjS0NJeDYN9agi4VSTfWTkdkSrJ/ICvd2LW0s4LapdhfO2pMRMjsDTFY+CPadJpGL3BjaY35EMPG+3wsFxyqIM6JI1GCZgnlmcpjMV9nY1qTsHk/C0RgHhEfDx9JZV+60qbfz5BVdGQCFxGHSUUeF4XcBNxAMwkSgXHQn0YCSecgWkZURlmIg+0X+A/xhnqbPAGRBHFIYMHNWutRf9AuCv2+gQzBjWrQyc9m72JVckpqW2SDBzwL8D/Eu5qFMSBbyjRv0mg1ntNFdDPSROJexffeLoXAekxkUNaSKIcFgWKNzTh7FYZcnVTGS4pX1LAtzV1Hgqn+Ja1a1teHjGSElMJ1wrjaAhPzW9IATIPd87J4a46kX0uCkc4gID6EeFH0nFxXNUYOarj2uPY/gtfS2k6+FnuyDueEi2VJ6QrPBRhw8v5qNT3x/AgJsKXxNJbC0fMZPm2yF4/UYTz8NBiZqm5bB/Np5iIQh50u0rHcWBhaIP+ylisMx4FASHLLq+701bcpUnsf++Vc3BxyRUPx85AHAsyCaj3zgmO6bxS9Q4q3Zuiywr0MDUoRGc+Plx4eez1+HSpT/N4uRrQBnQ38nFYeLA6vuHZ+lChLXTb7ApPbM/CsJyYHZKVJaXsu1mKi/Ig30j1t3CjGPrpMvE42+4eZUDpznoNnwc6cN3Z3l4gDY2zbTIOmrJWdEBRGmMZPha1YacoIhjaaOXvf5RYyb/wM7rhGNw1QkKxAvTbSL4jhjWU0IeH4SLnwWkFZ6dj0TmMq7QJVVm238bq8NgAdFFGABC4hvK GCfLaXDp jCPZ3XqkzM8ZqhCN6UceknZ5G8udfOG3TBRRzoY2v6thiwdLEWbBC2LbZg4Ad7/ZhdL/6BsE8gVE0qhPqhusBMBLF1s5jr1lAjgHTa59ViD3wo4OUyWlW6sqUn4R0i59wdU4A0bCgPK4aqzY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/30 上午10:55, Andrey Konovalov wrote: > On Thu, Mar 30, 2023 at 4:06 AM Qing Zhang wrote: >> >>> But I don't think you need this check here at all: addr_has_metadata >>> already checks that shadow exists. >>> >> On LongArch, there's a lot of holes between different segments, so kasan >> shadow area is some different type of memory that we concatenate, we >> can't use if (unlikely((void *)addr < >> kasan_shadow_to_mem((void *)KASAN_SHADOW_START))) to determine the >> validity, and in arch/loongarch/include/asm/kasan.h I construct invalid >> NULL. > > I get that, but you already added a special case for > __HAVE_ARCH_SHADOW_MAP to addr_has_metadata, so you can just call it? > ok, all the changes are going to be in v2. Thanks, -Qing >> This is because in pagetable_init on loongarch/mips, we populate pmd/pud >> with invalid_pmd_table/invalid_pud_table, > > I see. Please add this into the patch description for v2. > >> So pmd_init/pud_init(p) is required, perhaps we define them as __weak in >> mm/kasan/init.c, like mm/sparse-vmemmap.c. > > Yes, this makes sense to do, so that KASAN doesn't depend on > definitions from sparse-vmemmap.c. > > Thank you! >