From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F4FCD128A for ; Thu, 11 Apr 2024 06:08:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0C3B6B007B; Thu, 11 Apr 2024 02:08:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBB966B0082; Thu, 11 Apr 2024 02:08:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5D4F6B0083; Thu, 11 Apr 2024 02:08:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8559F6B007B for ; Thu, 11 Apr 2024 02:08:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0838C120A2D for ; Thu, 11 Apr 2024 06:08:13 +0000 (UTC) X-FDA: 81996220866.23.EC59E22 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf10.hostedemail.com (Postfix) with ESMTP id 97C92C000D for ; Thu, 11 Apr 2024 06:08:09 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XR4l41tg; spf=pass (imf10.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712815689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/iT9IlAymUCb2pC4/RBQKOmj3d7dpo0oLb02XVtYzR4=; b=jnsh3WJjMpPdgXBUn43TO5GhOiU/l8I+5O60hrpsDTBLkYXtwvO8qX2LWPkzbvqftEbOOh xmnzsThUehQvLOH+Xv7phDyqPPM/aDF/VYAZ3e9NvOObPYYjgXuy3anfgdpJ6m8JmhLM+B wBo+g0d282PP297Hx1JG38MRE39oVWI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712815689; a=rsa-sha256; cv=none; b=NXzBfKf/Xa5SDCJmgS7FvMX4YAmF3mstQGzPwY6KwXuYx1ewMH/B92WKg2kH/cQEMdGcPJ MJC8sjyVxVTdA11SnycXOHcUYvO4RiwWTLNcR7755FYEi58sE3Kn+PnWVc81+WuTKXajtj 9RYSJvSm5mo8Rv/zDdyaa1ESNwPEGeo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XR4l41tg; spf=pass (imf10.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1e3cf5b171eso43248555ad.0 for ; Wed, 10 Apr 2024 23:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712815688; x=1713420488; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/iT9IlAymUCb2pC4/RBQKOmj3d7dpo0oLb02XVtYzR4=; b=XR4l41tgVbRdosSmZbM/bnaCcbcTK2UqrMtmTIqtcvmG+a2tY61m4C798tMs5mro04 pI8dUYNV8FJiPdgMZsqBNJ1vIpbUwvEcxdsVWeAuLcgclqizFzul61Y429kUvYX8TY6i WF6tegltuos8R9hnu/K0L+LV/5jBlMPBwniNvxo2qRfw+3642qhelpyliQ1oLUx+3JEA U/soJWx25vWBv+qO35hgUnOVqbRoIY0ZKMDO4uSQNXP4FMJStegbOzYQqxYfhSjXR6w4 1RREL23yrcgbDPdf848pWNByLeHvuDYUfGyiCJgeFQB0GgS+eBzNhbSj7qc3RIs+391l ASlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712815688; x=1713420488; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/iT9IlAymUCb2pC4/RBQKOmj3d7dpo0oLb02XVtYzR4=; b=kpq5+6uutcunujrcX8WGbH4cMoZqC4vYm94I7TPhEP4xAbIeayIeCxMAgSN3/0+pBb oRDw2BUUzqTPdP26tW6lK3lsH1ipt9TvMK91/5ToMetvJejOIMlJM2CAf5AZOiEgAIFE ZoyncKgEyS3i0LgsQ6OdfJMXtGftreuLpvGG89x+hfChefRnCxm+6OGN0OblSfbASsUz 1DK8pqTGzVym0gw06CQoUfrhwI1C3xFWt6n2fQoPeTWl4LFNYRTQsLkcMTpsYUFCSmhm cLI1fOcLYCwmlE+b7g0b0gY4+IAPqnv+/UUFxlyprgHE9GpwZll65Lx+rWkFzIPzl1SB BgSg== X-Forwarded-Encrypted: i=1; AJvYcCW7AsScZYRB3V/sYpRAtk+tdPIeiw1KFROzMyvPsJ0UZA0lR2ttFeVdo8ylrkWKq4dUzR6HPTTvNEUCJqWzAJfvK68= X-Gm-Message-State: AOJu0YwsGxg4UY0oG/EkMhkFuYPIrYN3PDwv6dgywLeConBuibBJbIGC jpvB7d+OJuwxnns8M6AdAPRUe7Ro8Ztrt5uURBNTMQpEFN4gjWUD X-Google-Smtp-Source: AGHT+IHhyXMkprGe5UZ5k53JV62tzPnOnN38w9YWio7VO/KdjYqBp3xBsOxs0SgEFfosVBZYJBcxlA== X-Received: by 2002:a17:903:98b:b0:1e2:817b:460a with SMTP id mb11-20020a170903098b00b001e2817b460amr5668725plb.34.1712815688354; Wed, 10 Apr 2024 23:08:08 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.20]) by smtp.gmail.com with ESMTPSA id w14-20020a170902e88e00b001e0af9928casm510549plg.55.2024.04.10.23.08.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 23:08:07 -0700 (PDT) Message-ID: <235b35c2-159c-48b1-a522-654f5ccc2faf@gmail.com> Date: Thu, 11 Apr 2024 14:08:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] mm/ksm: add ksm_get_folio To: David Hildenbrand , alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Izik Eidus , Matthew Wilcox , Andrea Arcangeli , Hugh Dickins , Chris Wright References: <20240409092826.1733637-1-alexs@kernel.org> <20240409092826.1733637-2-alexs@kernel.org> <81c1de48-1e31-449d-8f5a-9342634cea27@redhat.com> Content-Language: en-US From: Alex Shi In-Reply-To: <81c1de48-1e31-449d-8f5a-9342634cea27@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 97C92C000D X-Rspam-User: X-Stat-Signature: tbfzqp7fujqnpwzahnypmy9reeth1iwy X-Rspamd-Server: rspam03 X-HE-Tag: 1712815689-885271 X-HE-Meta: U2FsdGVkX1/AcyyFCJGdenM+DyA56s13OfR3YzEpaWpVVowRzB6cjUKnzbO/iGr7ZwZmB1KmZDC5LVqWT1R1tlltykBIl770ZuO4ihcOwCbJahqpK5sB8ak2mSi5F1mXnkdhUPr1yy2GuK+FYOmlM/rXwfJFdN/RagJpcHuPrwWrxjCZjt9BbE+WA/L+gvf6DkfNLiE9ZFwMbNN5sYTo99FuwJUA8H+CJqbxWf0wN9RBS6Aj9kqbfGrbOgyTm2lDefBfik+3qvsThiyXaFonFBSDoCTzsZ1DdAczRmehHuF0jxjAP5ANcN9fPw4ptyDlNjEfvRnNPjnKw0sPtY1gnAunp/ET2hyv3euinpCP6nfwi5bRlfJ1mA9wUsK/jsiqigi1W6N0Dh5jGJy8J8MSxfXuAqaGmCjyvAjyLIn4h9hzueFqIY/E4pdB4s6c26hHQxVwrAYwWUgDvHqPs84VR6tcfLy7C/j4ENMhPShya8Biz8RNxsKrJh3SGbRv2sZLEoqeLcyCrLwytyhJv/Y5t3ECT4TRBBm2VzoMWfo1qBmW7c4wSA5HS6/GmuoFvt8ECydp0HjebeQcmYRV3QuYL+HRf35f+NIfPv6Itd/h9iqk0VlFFP03oIIrGUQApapE73PVwep4RuGEr4YwCKxxVantOwnAGgvcM/Zfa5Nq7/7nrG0cxbHnCAGUzzXJV8+zA9PY5vxsuaWKngILwDkJdo13CfT6KYCulsCYTNfo6D9X1ODcRIOK2xZ20UGoxqBsAGNEPIdgzP4CkvkTFgI3NzWfFBCcwgS0IUz/fTzhsB1pgx0fqqbN2gRtokx8gxec8MJ+Y7kaF7ipsDLBto1WAv4ZT+SP+zM7tJOfNB9TvR3SxShTGInyeg//eTqPwy5AKOtSFAY53BHh+5zf5ON6jWJoFW33uiLZc+HevX9IwUkkUK6f0Xh8NEW79CtnYCezD6YSdrRDup3JcYyN+og vD9Ai2n+ pzwNilsmfBLpLFzkPjDZEWGw/l463JwLbhkaiolHBufP07VOyKq8OfvvPsewYPLXdcexnf9nGNO+bdaj7r+QhwPJMGnYmw7Iu3WOtiZ78b/h6z/I/6enOE//uv6x+2k8bNKh/6b4VyPMZ01CqYGC6+ioeYdkqmFfxQN57twJYRKWHWzBqWGthuhaUIY2B51PzkOJXr4DOvQtcZmAEO6B8JML/D8C5mSimI0wWnCwj2BCQRmK4JcfJXCU/dyfVAg/GJn3TRMS0QeHjta1YmN/wJOyOa1/wMJ20q0CU+YQf4DM1HvAEBpBsevnLX8YZupvlaswQ+mgql6K551zzMOeUvcI6TimFUVUfUtNnIXG+VpRqTjU1qGGOkIAA4rHj9mPGmagDi1N6fvH7I76TjGyQZ2oUL1Kp9wJNYBSBeXebcvN2iW0shkwzCGRJUZUgHbPL0JBKn6OQJlXxXVTYJdjdY5QPcyGbP/MnkLz41370ph7Rba6U9GZV2sYUj/aRCXjsCXVpTLi+RJC8SIF1iK6y/ChlJPL5gs1v+us14ysH3XYeoDEw7nHViQvodO9Mm5nhvndNXPGr6Qm3cRSj3f5Yl77G+wSh9GMgjDKR4LJd13nM0TuDUS4SJE3a0ErXfa0sPmUzGHTtZqbnjLateD7CC5WBLiYGUnZMcQDRjgrKlw5SS9E4Oya3q4lIVrzxbyseeq6rz1PI/4EToEpvVzJxIt0f2TdacTAycQy0yFcD9fTgXvp5qKXzD0h8SPkBo/1VQbZeS6Z3bDNavIr+0yI8l99Suih9CVo1YmXVf3Wp49CcHvYoGfMRovcm7uL4vbhJl06nXx9gq75KG7WNw5BcC3Iaa0SLWkPMdKqeABOLj3nTnQXvlh1DFO0VmTeIeLAGXNBI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/10/24 4:34 PM, David Hildenbrand wrote: > On 09.04.24 11:28, alexs@kernel.org wrote: >> From: "Alex Shi (tencent)" >> >> The ksm only contains single pages, so we could add a new func >> ksm_get_folio for get_ksm_page to use folio instead of pages to save a >> couple of compound_head calls. >> >> After all caller replaced, get_ksm_page will be removed. >> >> Signed-off-by: Alex Shi (tencent) >> To: Andrew Morton >> Cc: Izik Eidus >> Cc: Matthew Wilcox >> Cc: Andrea Arcangeli >> Cc: Hugh Dickins >> Cc: Chris Wright >> Reviewed-by: David Hildenbrand >> --- >>   mm/ksm.c | 40 ++++++++++++++++++++++++---------------- >>   1 file changed, 24 insertions(+), 16 deletions(-) >> >> diff --git a/mm/ksm.c b/mm/ksm.c >> index 8c001819cf10..ac080235b002 100644 >> --- a/mm/ksm.c >> +++ b/mm/ksm.c >> @@ -915,10 +915,10 @@ enum get_ksm_page_flags { >>    * a page to put something that might look like our key in page->mapping. >>    * is on its way to being freed; but it is an anomaly to bear in mind. >>    */ >> -static struct page *get_ksm_page(struct ksm_stable_node *stable_node, >> +static struct folio *ksm_get_folio(struct ksm_stable_node *stable_node, > > Just realized that you should adjust the function name in the comment above this function in this patch. > Right, will resend with your suggestion.