From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B5AE67493 for ; Fri, 1 Nov 2024 02:35:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70F1E6B009D; Thu, 31 Oct 2024 22:35:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BF876B009E; Thu, 31 Oct 2024 22:35:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5602B6B009F; Thu, 31 Oct 2024 22:35:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 31C0E6B009D for ; Thu, 31 Oct 2024 22:35:33 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91BF3121A9F for ; Fri, 1 Nov 2024 02:35:32 +0000 (UTC) X-FDA: 82735959222.21.1167263 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by imf24.hostedemail.com (Postfix) with ESMTP id 2A947180004 for ; Fri, 1 Nov 2024 02:35:25 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=aIGPCE5E; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf24.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730428411; a=rsa-sha256; cv=none; b=Skp7OtqmzcKJ+RDftw5TZcuwWkte2qcYRS4Uhm1AZIsDQZVHVGfCML+EMRGhayYRJzMC/l l679g4yQaoICCdAzE/3saCus51/9bPc6NuVdDIhGpopk95qI6LuioGicclQrmHG6fV/oWE CtLeY0OksR8PQAT8T2hDA3nVO3g7ecM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcppdkim1 header.b=aIGPCE5E; dmarc=pass (policy=none) header.from=quicinc.com; spf=pass (imf24.hostedemail.com: domain of quic_charante@quicinc.com designates 205.220.168.131 as permitted sender) smtp.mailfrom=quic_charante@quicinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730428411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MTQXHZXYpxX/VkPnfVlYOkzTa6ogIv0AyusjLmcaRDA=; b=u4O+SQMGUwX4TEwk1Ne0jZtWacZqoE1jgrs63BdtGLDI67iO8NBjoQKLfJ8UCWt45ESelq g37YiG1C6FizU8Hi76PoM6nf5jaooDL/q2xQ8r0eLqByr5qp/4VdrBTODZRgZw2F/Gv+Bn awTmjwRMAm4T1BdOVGkqbNfPtwYicOo= Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49VCJvWe005405; Fri, 1 Nov 2024 02:35:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MTQXHZXYpxX/VkPnfVlYOkzTa6ogIv0AyusjLmcaRDA=; b=aIGPCE5EIlVsR6Jr OL4ONkNelM+p4B8HfaREktPdRoVy+37wZc8b00RNJ44LjhKgMd5kpLHr3My8ssHG rNx7Hihbkwxfgq7vf9Pf6mpbFzM3Lfbnzm9MOq6HYollmeEKc07O731oEjYejib/ YrV7skTszuztGm1J/H2ClcF2bgIpFydG5Jiwfh5hLzvmOsqhlt58KlwHbavqehui Yb9U97OD59SYGx/qmj/Tp66nWaMCNtwQqMTWCNxNoK0XBSGKTBESQ9F3rb2neUNd FrokNK5saFVjwEyVieL4g7CxIB/BC2oJ5xrzSW0J6f5PQRcGljGdH6lc5zB+BTRC 6BV2FA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42m1xcbgx3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 01 Nov 2024 02:35:26 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4A12ZQ0Q031255 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 1 Nov 2024 02:35:26 GMT Received: from [10.216.11.95] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 31 Oct 2024 19:35:24 -0700 Message-ID: <2352282c-e96d-bd17-7591-9012e3b341dd@quicinc.com> Date: Fri, 1 Nov 2024 08:05:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [Chapter One] THP zones: the use cases of policy zones To: Yu Zhao , CC: , Jonathan Corbet References: <20240229183436.4110845-1-yuzhao@google.com> <20240229183436.4110845-2-yuzhao@google.com> Content-Language: en-US From: Charan Teja Kalla In-Reply-To: <20240229183436.4110845-2-yuzhao@google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: me9DP71sJ4id0xQ3HUCqtipQ6NA7Y-EY X-Proofpoint-ORIG-GUID: me9DP71sJ4id0xQ3HUCqtipQ6NA7Y-EY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=989 clxscore=1011 priorityscore=1501 adultscore=0 mlxscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411010017 X-Rspamd-Queue-Id: 2A947180004 X-Stat-Signature: qyp7febg4fxaj67w7tp4ytijoaqj3cy5 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1730428525-426247 X-HE-Meta: U2FsdGVkX1+zZrLSgRIvRrw8e+gtzPuabvH6OngGLHkDBvPnaxqKCVN1DfFoB9ozd8n2XIKV4meBdk0qlN1VlJb2/orkYz48d1FmqtQKa1FfQ3SV+noivF2wt+eEC+5iFNJObt/4sS+jIJP7M3lUqKNQ/B3cZ/Gf3VQlkESXTuwRH2LOPln9gtP9beeomtsf+bsEvR05Qs/j0RvIoVy0PzYXtyXVq0cjgI3Daswe5DRnjlLq2o9fHCcaK9x+l33q4f9GXJhWL2Vd2h4XHGEO30nz91uAgXMFUrWuwbX/xtrizE3WGySKAOiirXLCOvRmKModrlMD448mga60r4TkIBthvqxE8jMg3IsFfLjWStQfSqxe4IDnQk2YXcY9JXCl+lFOt79lFtc2mfKdnT+bmgnbRMfjsg17zDHDsvjJwECkV/tI2G8oWUvsHtnNNa3tTCHUStvjSpzM9U8R0xcNcJlPRID3uSlJaPIVtbU9pVSK3QBo4kJ+uiNbElRfDZAUKntPDzm0DpwTw0680IyyNuzRXJ/IjSV6HTVRz0bhkGLmuDAN8qA2uUr0lZ9tAWVgC/vPxoGf85goE6I5hbpnzb0dSuII382OwEebPnlD1BVIIpmQ0fKfZzPdaowY9f9ybUonrHoYSB6+HIwAZY57LK2Dk3xDTWEAzlrPXzgrKxGTzEDpJIUhvBzF+NbRe/hRpJLiNAAJ6nUDYa0IzMzHpVlHiNKq4URHICLXK8iHbPtpQp4gOWJPi9wYt411erqYi551H3GxPeXMoo/SK1KvSvGO7P4Bo9jJNc/5DhPJTPrh8U/JuSBOzjpI/9BlCQsOHC0jFRT5/PVXzA7fVkkwBDvcTDjroo1hYG3H6JoDyOjKFfySM3jv5ZDfWTvkekSj4bN0TH2O/OIwOZgDFbtKBgnhWuN9q7h6xeE5CZ7sxCI7d7nqoA3c/LOkdreqMKS2vFNejtc5tWN4dNtNyuI djQiymz9 g/EfqOSjKAAJF6dU5VlD67VgDxhRHW4Gt7Ck58ODtHJO2WuiSv8DG7FaKXMVruUzOYQ6jjRffQyqwGxBX6KCV6/gtF0pJv54tyY1I1YwXzQFGv9h9KJqxlNB8vkfb8rM0BwySADSbMLODo+oKOxj+L6R51AKcrx8QV+ayHZ+SbvenUYzWEJzoke4y/YAUacK6plxEym+RtRD1yPxPJLsnOK1xaWDMVPWWj+AmzGp154H2jTUXA5iiLfJzYcbSH7Pw5VuXX3EdLuQHRis= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000102, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Yu, On 3/1/2024 12:04 AM, Yu Zhao wrote: > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index de292a007138..c0f9d21b4d18 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -88,8 +88,8 @@ static inline bool gfpflags_allow_blocking(const gfp_t gfp_flags) > * GFP_ZONES_SHIFT must be <= 2 on 32 bit platforms. > */ > > -#if defined(CONFIG_ZONE_DEVICE) && (MAX_NR_ZONES-1) <= 4 > -/* ZONE_DEVICE is not a valid GFP zone specifier */ > +#if MAX_NR_ZONES - 2 - IS_ENABLED(CONFIG_ZONE_DEVICE) <= 4 > +/* zones beyond ZONE_MOVABLE are not valid GFP zone specifiers */ > #define GFP_ZONES_SHIFT 2 > #else > #define GFP_ZONES_SHIFT ZONES_SHIFT > @@ -135,9 +135,29 @@ static inline enum zone_type gfp_zone(gfp_t flags) > z = (GFP_ZONE_TABLE >> (bit * GFP_ZONES_SHIFT)) & > ((1 << GFP_ZONES_SHIFT) - 1); > VM_BUG_ON((GFP_ZONE_BAD >> bit) & 1); > + > + if ((flags & (__GFP_MOVABLE | __GFP_COMP)) == (__GFP_MOVABLE | __GFP_COMP)) > + return LAST_VIRT_ZONE; > + Not sure If someone had already reported this: With this patch, we allow pages to allocate from movable zone(through fallback from LAST_VIRT_ZONE) even with out __GFP_HIGHMEM. The commit cc09cb134124a ("mm/page_alloc: Add folio allocation functions") sets the __GFP_COMP by default and user has just to pass the __GFP_MOVABLE. Please CMIW. Thanks, Charan