From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A45BC71155 for ; Mon, 16 Jun 2025 12:21:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F08B68D0005; Mon, 16 Jun 2025 08:21:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB8C18D0001; Mon, 16 Jun 2025 08:21:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA7C58D0005; Mon, 16 Jun 2025 08:21:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C9FC28D0001 for ; Mon, 16 Jun 2025 08:21:10 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 874561D75D6 for ; Mon, 16 Jun 2025 12:21:10 +0000 (UTC) X-FDA: 83561173500.11.68AE75E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 12C07C0012 for ; Mon, 16 Jun 2025 12:21:07 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JuvSkTmT; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750076468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rupm3VDCoAld/2pq6rtQWKArPHie9P4J1nsk+bgv55A=; b=C5XSZ5wNVNzqiqXOxIM4LnBXU/boFnYlr/nMqkh6zJgvhHERPQGcMb1ETFbMWADWHM+gRQ hovUWUT92Dl2qVXLFguYO9aLUZHfdPoST80LnYsKkrJNn7Ww55rq1k1cnL4+phJidubs2a MxK8+g3E3zIP8UnyY+m/izeGv8D+k0Y= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JuvSkTmT; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750076468; a=rsa-sha256; cv=none; b=zGsVWZ7wHv5urv9eDXouGpDVmiJmx6mOhtb8ooGQYe4rydvl+fJhvcgKPSUMszFbOzN3eE 4ioo/tzSboNwQIIKg9lsmCvTuNkffcpr7YVbJpddMtZdWhzTDvTDhAZlvgJwLZIisUWIWG SBzK8nOiBGW7GJ9qohJFr56MlKrPqHU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750076467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rupm3VDCoAld/2pq6rtQWKArPHie9P4J1nsk+bgv55A=; b=JuvSkTmTgCsmTCvu/kn1ed2XdTvUeyLrX3osMG8NUoCT7S/mPEUOnVRby9rePUha6cpjgq TaX0xZQUZsCvZn5igGA7ykepl5+J54cmlunPrmZVdn1p4ycL+hcd8M7dDEzLMschL3u7pc a7Q9DPbIbQo97Pd0/cLCdIy+xBo+bgc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-313-9Iofz9kIN-ObaJs1uUFeWA-1; Mon, 16 Jun 2025 08:21:06 -0400 X-MC-Unique: 9Iofz9kIN-ObaJs1uUFeWA-1 X-Mimecast-MFC-AGG-ID: 9Iofz9kIN-ObaJs1uUFeWA_1750076465 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a503f28b09so2541643f8f.0 for ; Mon, 16 Jun 2025 05:21:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750076465; x=1750681265; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rupm3VDCoAld/2pq6rtQWKArPHie9P4J1nsk+bgv55A=; b=JJFdV3beqJcZLHPJ7dOjIZ9RutL3ue+feZJya56q7QnCqZr6o+rquwkFtrnKEYiF4i tLAkCuzUpu3mgqeRddJ/2Dmk22CklWyxnJ/3ZGH5JKKYunWtTFk2rOf82tQugvx+R7ji KH4lWuSPSOBrb5MBwcaNdPOcFMOFsVuqmx9j1uGcZ3j1xMmqOATPvd3ovyTE54JGDTqU rLmk+2bkUBnEPGkTMm4gNgjhjFQqokPb/8awAg5jAmDs5BrGhRGyCbO0nYFP75tfoNwo DfN5Md2XXySjfGkT7Si0CwUMx4hS065uCtjKecFcOQoKGWAKHbSbeVZSIm+EOpTM4E3R M2jQ== X-Forwarded-Encrypted: i=1; AJvYcCU6mAlJJJ5GtquMNfZMxuVAStapwnXZ0z8pReU/Yqr+v/kPL2Fy/ur6RzYO3mwFJEUI1WTRXCZwRw==@kvack.org X-Gm-Message-State: AOJu0YwCPaOe97iqvbalMl0I7BoBThwynO+IttGysJ6rbZDdsKAf6Jft I3NaA+sALGU7xwngpdCqNJwb47FHcNzpA4zCwJ16dkbseGlVYNeGmyT5ztpgpcNSjezLpyZOQX/ zheX3FEy28Hw0umwDlK922z45O7JvFmk+EBzOL4HhOkBbrXnLzvjv X-Gm-Gg: ASbGncv2aMSbJETmtlHAShQGF/9f75j6IIh0sO4A02mBp6JAcN6Aa70O7M3Uukfsv/c 6pIPeoP+v/oC3X1PvIE0S1KQHXAvw+33MxxNjimZIk835NLknxJ1CZViDh/xN8gAOWLDj4tFL7h t29rwECPdDO4d1Gu2dSINjEbVSn+5bqWMnsh1QbUSYNsuFPNo1196c6tlzCksqGfDIMPUJwflJI HeXXCz5wF8ISZf2VYmuJuUXH96hdR0OJHO92c82rr2K//FFfYpahviEJxx6DRLr26vdhQHtkiSV ujDwGqMDJYxi16mXSmCwB+lZLJ+FFA/o08KYYpmvn7uSPBAaDicqmddiVHU1HJuY9flkQicLd3g qI4hZ7ShILik6ixacFqBp/e+uVDyCqsyMYMl6GLgP//7zcEs= X-Received: by 2002:a05:6000:2486:b0:3a3:64b9:773 with SMTP id ffacd0b85a97d-3a572394d3cmr7106113f8f.10.1750076464858; Mon, 16 Jun 2025 05:21:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBAJU8h/LHlTU4YFrtHj4piRaDDRZSSm+aQpvene6in796GVuxj3NXu3FCTOyOQjjBYCHbFA== X-Received: by 2002:a05:6000:2486:b0:3a3:64b9:773 with SMTP id ffacd0b85a97d-3a572394d3cmr7106093f8f.10.1750076464446; Mon, 16 Jun 2025 05:21:04 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:bd00:949:b5a9:e02a:f265? (p200300d82f25bd000949b5a9e02af265.dip0.t-ipconnect.de. [2003:d8:2f25:bd00:949:b5a9:e02a:f265]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5689e5f3dsm10951486f8f.0.2025.06.16.05.21.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 05:21:03 -0700 (PDT) Message-ID: <23431108-b5b8-4c8a-8869-8f994371e7a5@redhat.com> Date: Mon, 16 Jun 2025 14:21:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/10] mm,memory_hotplug: Implement numa node notifier To: Oscar Salvador Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250609092149.312114-1-osalvador@suse.de> <20250609092149.312114-4-osalvador@suse.de> <2bec8b53-f788-493e-a76e-1f804ed3aa0c@redhat.com> <10c87a0e-c9fe-48fe-9bbd-16afd244b4ec@redhat.com> <360f2f04-4542-4595-bf36-c45ed10335af@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OKZgmU046QVyWw5Sc5-tjrhE0CxCVSMmbw-AaKLF2BE_1750076465 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 12C07C0012 X-Rspamd-Server: rspam07 X-Stat-Signature: 9epbrfg6swjxcoft9y81syqui8dqtcht X-Rspam-User: X-HE-Tag: 1750076467-916824 X-HE-Meta: U2FsdGVkX1/gKRhzT5hndy2GPeUTKvMTISZrz+OMrBSn0dAP2J2Ifi1xJK2UeCTl4YT39vHWHHC9j60dq9robV6SO6O1qDfqlM9W0cNTqVFnmeN1MUSUZngvbXD/4zPYx1klFEu5u8b0whHpVnBgE0WzkkLh4P4XUZcVAdPSN+Zt56ksX2Xub6fF8SDPQ5aMrjc3/MLO8PU+hCBKJ9rBkOm9VzhMGltoax3f69ujgOn0mTvcEDVZRcq/dYBy7vKWe43y7KZk0FjaFUjJrwFh1dIIjOrCEIOvpKun2+c78aShnDdB/Xubrfy2QF/hLrTFufAZaF7MIvquwf+n14w/GteWwLz2qUdqbq4lmVMpShqFnzw2U1THjF/1pk9TvpVZDcznZ9t1iRTZVm0HzOYhJRnpoFEaTa603zxbQkiWxZrEURjetlOx0ZzI4ICChOzMs7HPkF848IOvcorHIuzj5l2yG27B8jYlpJmdv0En9EQb4ay6PUdkKgyIvl2EGIid/1s+bEI0hdPa4rUG5yGaqwjmfwDRoL3yH4GSnmy0SlXX0wHySRKRXvMkNd5CSk0fVPW8FZpJY3Oisxn9m5R20Y0PBxY/jfYEpDAunFMTCdM6TBHn6MIia5W89yaBfKyq/jyM22xerd1x3D57QTyAxqrQQKzSFX9TnegU0PUDUke3f8rU7fkmjK23eZOPZuXBzwOIxOW0vrJVc0n6wq474yFsh7CIzFf8iWeqs2gnXPJOKGr1qK0BAF3yOgk2Y0ZDZtqjLKD5cYClXteS+fK7+pJUEmdtYUnzDGo7u/SxT5nwU/Np6GsUBzob1L3pvaS6CS2LvuFUrGak7vZXZ8BUrddLE7FqUd4WxmAAWuhecWwX3BcJSQMIF3tODXVUnNBiudsho5Ft1Q5of4EJpuQQ0/E7dVanvBLst3PXRUPx1/gFNGJWmFBmNXPzrhd3NSV7vej2RXfFWerX3T3MOr1 7M2U1b7O EoLs35erR8AacMX1xOsLZo390RZvjSqDgfnfomty5S9fQUZWWgqc9WnqT4E1wVbTSkrObXOsU8nV71tkKfa44jb8+N8hnR77AZ4rzCjBwCaCF/mop4ByqZc+SBSilZejtsmf1ImqNYIHCWzpAWwocIeF8r3XLdoWe2evvViD9IWB7JWGq7E9ihmDRx7CjJ+3mnsXDfBauOhnepBVSndEQBsXtQzLutACy3drVQvkQUtQPXGb4avqJOmh+iEE9GD5L6ZYET0reYh/+Il9dmX9AirXaJc7TcFN6ovdl04cjMjYY20OT9VzZERZVhNClt+543nrzGdH/GLHU5GmUtv/6E4lw+EBgGN8f6lPvPZpeIepxuFn+F6G+UOEfiY8RvrOhhbg+7AVUmv7EilMOot60TkjwIlNydmaQU0MP1VZ5FSVSLrdh2XwUsft5DzxmK/mBQU/vUBwGBH2+wPqRW+UPAn5Ly6Cup4ugrvzv70vLh1t3VqZskEwnBk46jpEAzjDIW2/2WojjBuCKJZM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.06.25 13:45, Oscar Salvador wrote: > On Mon, Jun 16, 2025 at 10:52:31AM +0200, David Hildenbrand wrote: >> Probably worth checking, to make sure we don't have accidental bugs in there >> ... > > I did a quick sweep, and we should be cool since users of the node notifier > don't really use *_CANCEL* action. Only ADDED/REMOVED. > > Now, users of memory notifier is a different story. > E.g: page_ext will call offline_page_ext to mark the section->page_ext invalid. > > online_page_ext does: > > base = alloc_page_ext(table_size, nid); > section->page_ext = (void *)base - page_ext_size * pfn; > > This is fine, I think, offline_page_ext will not mark it as INVALID because > section->page_ext is NULL, so we just skip it. > > This is just one example. I checked some others like kasan and hyperv and they > seem fine. > And anyway, the we could already hit this situation with MEM_* notifiers, so > nothing new. Exactly. I recall I checked some of them in the past as well, when I stumbled over this behavior. -- Cheers, David / dhildenb