From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B267C61D97 for ; Thu, 26 Jan 2023 14:26:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB4A16B0072; Thu, 26 Jan 2023 09:26:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E63F78E0002; Thu, 26 Jan 2023 09:26:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2B348E0001; Thu, 26 Jan 2023 09:26:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BFA896B0072 for ; Thu, 26 Jan 2023 09:26:30 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6BCA2A03B2 for ; Thu, 26 Jan 2023 14:26:30 +0000 (UTC) X-FDA: 80397175740.03.113896E Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf06.hostedemail.com (Postfix) with ESMTP id 90C8F18000F for ; Thu, 26 Jan 2023 14:26:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GznaBx0n; spf=pass (imf06.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674743188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3fnkXpl0JXe5cdsKhRNEbh/HCtmKDAhmby37nYCIbO4=; b=YMhvscPmZNlcULJ2GXtO4P3Q58rKAy0PgHI69mjU2/tiYbf1/l8+8YPbyRiLOKJv/SPX6N ki8SOqKsPEujnK/seqfF4dXmvMksqP3+IFLqtpKnVb0aG0rxQVXDis3isfYtbyDUR2U2DK 6Q6haG7EgZyipsAXqraM3yhtlaEkiAk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GznaBx0n; spf=pass (imf06.hostedemail.com: domain of fmdefrancesco@gmail.com designates 209.85.221.46 as permitted sender) smtp.mailfrom=fmdefrancesco@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674743188; a=rsa-sha256; cv=none; b=N/HI9P8sirCQDlWQJtnl4q5LD6iKvELFG2YOnwmglYCH61T7tf9QDkgvDwd89OKUGjND0R q7SlpSXwja5N2xh82UsmiJvEpNzYo0889OrXol7QF4AB5TEbjYnSpx4yYqRg9gO3MylnM3 N+ebFJPrnoOxlbFlUmy6TZCbQqacPCo= Received: by mail-wr1-f46.google.com with SMTP id b7so1959789wrt.3 for ; Thu, 26 Jan 2023 06:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3fnkXpl0JXe5cdsKhRNEbh/HCtmKDAhmby37nYCIbO4=; b=GznaBx0nO92fihTvKdhBKVy1eMXnzSLw6ar8Mj/NvkFPqWDyPKzP6mOAMwarKo0uX+ ZKzXL0fE8nbkh+2Ic1OiV6sD0/2L5AS6EPcAht944BNvOEEcbF65TYwwAvBzhK02Jo+l X+0LA9Ux4CKS+aCHXOsmXvFS3x//kHwPjNHm1LxflBXIPMx7siOG4zSy1KZD+v3AleSe WBLNVDAdo3cy8A97eNFeYtyzUO+IMIKVq16bjY6aB8VkkwtB9HQczm/rPy6krDsKNHe9 dmIe5nbE0PPOomzD/yYZ7D1cgH+hZAN663OcUxo3xGh59EfIRMqNjfxECkprA/YzFrJh LKFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3fnkXpl0JXe5cdsKhRNEbh/HCtmKDAhmby37nYCIbO4=; b=XuA8FJ3ckIg8DI0EHKCi2SLsAgooTLNNu7hTykR1hJV9DNAiQA9uD4fX2e5wBXHBD8 JlV08hFJMRvZqzGaW0PQ6MBQMhyqqstENeDLZqiLXAthXwzlaImpbUAx2oo6AqitSP7y kX18kS418P6JUAE5KnR2EClD8nH6E1DMgelIB0XboA2V/XdP4pjaDP2Zwgc2LX/KEXlq 5sf/X4+h2y8th8C4N1iRUNTXiMM/Y97NZ7SUL0QqVbjIERQzmo3FRT2w+33WWd/JxXe1 CMoE0i69aiBggdO9IN6P9fpS9yxog6NEvNiJqA4GJhUcqw5WP3UGXmcEkFp33+zTwBIF QDmA== X-Gm-Message-State: AFqh2kr2VAOO3ugJIrMXsU1kERjvC8GY54zBJyZwQkiF+VQV58wMhNJj PDCQ0FiudQh1gMMPr1pbxCA= X-Google-Smtp-Source: AMrXdXvL/g+6+cBxBcCMAuTxNV5bmRDYvLTpVidFlkrkzLoddDmsOb9brXJzxC2Eo7as9WFA+lAnWw== X-Received: by 2002:a05:6000:1b8c:b0:2be:c5d:adc4 with SMTP id r12-20020a0560001b8c00b002be0c5dadc4mr32237963wru.13.1674743186940; Thu, 26 Jan 2023 06:26:26 -0800 (PST) Received: from suse.localnet (host-79-44-17-213.retail.telecomitalia.it. [79.44.17.213]) by smtp.gmail.com with ESMTPSA id b14-20020a05600010ce00b0029e1aa67fd2sm1439869wrx.115.2023.01.26.06.26.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 06:26:26 -0800 (PST) From: "Fabio M. De Francesco" To: Andrew Morton , Ira Weiny , Sebastian Andrzej Siewior , Alexander Potapenko , Andrey Konovalov , Tony Luck , Bagas Sanjaya , David Sterba , Kees Cook , "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Al Viro , Helge Deller Subject: Re: [PATCH] mm/highmem: Align-down to page the address for kunmap_flush_on_unmap() Date: Thu, 26 Jan 2023 15:26:24 +0100 Message-ID: <2334001.NG923GbCHz@suse> In-Reply-To: <20230126141144.11042-1-fmdefrancesco@gmail.com> References: <20230126141144.11042-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 90C8F18000F X-Stat-Signature: fqoz8whjrsjfh5grtqw7bruae91ahmd4 X-Rspam-User: X-HE-Tag: 1674743188-624153 X-HE-Meta: U2FsdGVkX18zVwlpb3XIIvw3Fbt8gjs4GxUaZfLweY5quJ5k4/Hb/tQBM93YVjUVjWKQGVWZmt+npBKHJ5losN+s1zIHMEvc3XfpKwitgfzEnCRwoBK3fjDWJ1hy9ZntqeW/1+U3IanuHObGr942XX5gFwd6f5BzWI6LQVj5RQqQEs9dWyYAf/CnIoex1ptKwxCecA65g0TztkzCw4BjObKLfPIh9MtLPKXNfnKUGOcvL0Za2X0QZtuMFyFZegBWIFrtIEvbGenfk09yaVl4d+v1v5IOS3WrIuG4/Xvtq28zQMQWEgtkYkJO+8pjVWh4TCFLMistLnOopCy6/EHHt9O0D80Fsizx84yEVJ6hRpV7DaEXBRcMKUagTJc2s4TF2ur+7wDmDoGZ61ghUdB4NibT56f2tJEd4cH+N3MG3Oro8D/Al/2A7uxjiVWoqAmt4VtuKb09a6g2QtWWjf+ewlTp7vo4RxpBc33WtX9viFo/8haDFYyVY70OTygfmpvBUpAakmss4sYYokoPiPKGw5XIwase+LjGXahsKiYnGseC0Lj2OhN8Oln+AevgjPQRYJXS5GbEyCm6GgHED5tpU1PHZ1h1FKxFIgTSn3qwqDVlW6QcFaiY/dGRnrY8wrRGsnynS5SGBZtKgB/FZZfE+3ENGtJlOl/n5SojfH1kuvXgb2aEWhSNkIi3KUrAKZMABEbQ54FBuTg/y4tl1ASxDCC6Dg1tMoiNkd56w8SMKEdsI7B8f27dv7ix0jw7Yo7qY539JX3gHwvOJKoxu7GQUxiyzSgQPkR1J87KtRUaFBfWNdHSUA47asptq7sHIgXZqTqX5YJp2mH9+eGE2ggrmCOrNnL1gnpJNgmebfCykl+inhbjaF5p7xbyW3wprhTRBq/bfDG+vXwSDHB4UJgy09xPtYRG93ZfjmVnhERK+FUzekTMlZAIRwPlNzztGDHyzqha0M9pGmR3CiRsF6u Iz3tlQpG AXW9gwFedi80Ny7grYYwij6lGajfywbXIXZwF2YAFiCd/iaAo4Saem1fauSHSzyAgavkJ9wr1O/nl85pDgAuHRX0JjlHF/xFNU4XGw9gHTA1r4ABC4HpW48GRFMOBVQVToqdoZjhvhpQjY16H6fJOoYT03crVwa9jXZ0TwUNDf8Zj14tjKHKqwGcLR4wmjX04rQCUXVZ/7CfE25Jm08rub/SWm5hxpZ/LjWE6nC7U7H8R9daBavPuGEQvob0B80Xfjq4CHLFNeS1GRgPrx05qEygB5R0trwpTo7S3mtxx81TFQvMT0A6uGczio9kjqsfttXTlOG4mDr3HU2TovpiHDuiOz17SIYab3ozKn7MZvo34OQUm7uMDJVmR3reEDRJGqECkKa5AJNti05uTHxGiPzAPL/+gGWHzO3JR6CYGFGlAFMZHjnkwo7E/1ohaSzXs3lEpbYUTzp3eylC0wJGGhFDX7lcaqXTaJl+dTmXCZ63jrAzedA3hcZ5bU+FkX5dYXaNZiPKE2QNO3XGvnlGgalHlLFWpGeUQ1PE4MChtSYMizo6xouYtD7nnhGnnQL4Y4l050hl2n0mFLKA6nvNBYbEGahbnZ8b/xU7C6uq60x47ZdyTSRCwgyVvn6l/wNtEZxzJROUGjJP6aZQdWqz4euUXMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On gioved=EC 26 gennaio 2023 15:11:44 CET Fabio M. De Francesco wrote: > If ARCH_HAS_FLUSH_ON_KUNMAP is defined (PA-RISC case), __kunmap_local() > calls kunmap_flush_on_unmap(). The latter currently flushes the wrong > address (as confirmed by Matthew Wilcox and Helge Deller). Al Viro > proposed to call kunmap_flush_on_unmap() on an aligned-down to page > address in order to fix this issue. Consensus has been reached on this > solution. >=20 > Therefore, if ARCH_HAS_FLUSH_ON_KUNMAP is defined, call > kunmap_flush_on_unmap() on an aligned-down to page address computed with > the PTR_ALIGN_DOWN() macro. >=20 > Cc: Ira Weiny > Suggested-by: Al Viro > Confirmed-by: Helge Deller > Confirmed-by: Matthew Wilcox > Fixes: f3ba3c710ac5 ("mm/highmem: Provide kmap_local*") > Signed-off-by: Fabio M. De Francesco > --- >=20 > I have (at least) two problems with this patch... >=20 > 1) checkpatch.pl complains about the use of the non-standard > "Confirmed-by" tags. I don't know how else I can give credit to Helge > and Matthew. However, this is not the first time that I see non-standard > tags in patches applied upstream (I too had a non-standard > "Analysed-by" tag in patch which fixes a SAC bug). Any objections? >=20 > 2) I'm not sure whether or not the "Fixes" tag is appropriate in this > patch. Can someone either confirm or deny it? >=20 > include/linux/highmem-internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/linux/highmem-internal.h > b/include/linux/highmem-internal.h index 034b1106d022..e247c9ac4583 100644 > --- a/include/linux/highmem-internal.h > +++ b/include/linux/highmem-internal.h > @@ -200,7 +200,7 @@ static inline void *kmap_local_pfn(unsigned long pfn) > static inline void __kunmap_local(const void *addr) > { > #ifdef ARCH_HAS_FLUSH_ON_KUNMAP > - kunmap_flush_on_unmap(addr); > + kunmap_flush_on_unmap(PTR_ALIGN_DOWN(addr, PAGE_SIZE)); > #endif > } >=20 > -- > 2.39.0 I just realized that I forgot to Cc Thomas Gleixner. Therefore, I think I'd= =20 better add him to the list and resend this patch.=20 I'm doing it immediately, so please drop this. Thanks, =46abio=20