From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7152DC5B543 for ; Wed, 4 Jun 2025 19:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F4708D0053; Wed, 4 Jun 2025 15:16:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A4BF8D0007; Wed, 4 Jun 2025 15:16:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EAE5F8D0053; Wed, 4 Jun 2025 15:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CCA718D0007 for ; Wed, 4 Jun 2025 15:16:23 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 734881A069A for ; Wed, 4 Jun 2025 19:16:23 +0000 (UTC) X-FDA: 83518674246.30.84CB104 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 16B7F140002 for ; Wed, 4 Jun 2025 19:16:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EJgfCMVX; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749064581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rfu56wuubM001B/pgaMkp5G9PWTbiIJhIqTlXiTrxqU=; b=kILewSzjnB4dVU9ip9Op+l57mZCNgFZlknXUhtdlOgw/FwrTEjK6qzIEKKfUc64EHvbyXH ujSGB2Fs3OCMMFV+T/tWS0c2MgQ6AHT8mTNMTSULvTOuOprHuniwqoLVkHqOAoiT+mIeVV 3XBx31NSj69NMut+XawQXdhhcDaos1w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EJgfCMVX; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749064581; a=rsa-sha256; cv=none; b=8Um4Pzj32eywZMBceJaB6+Nc6uFkoNvYTFZlvQujEnCWOEz6bXRJ0GQCORSZ1SdT+twytM e17MmsOYAfQ1FtB4wIGwWK2hxAN69f7eF86e4UHxxK0y41gIRJOLpcTFDDJcQKcSvOXUhx +cCwzp/0jAAbWEcQSWxE2b7UCYfq+2U= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749064580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=rfu56wuubM001B/pgaMkp5G9PWTbiIJhIqTlXiTrxqU=; b=EJgfCMVXOluqlvaMgEtniSrc5Hcm3pfBeP7BVHKxPzdBcBRpBSKdesoENndvosj6zSl+F9 XuX/+pfgw1hbeK8pGudbrc1ZDzyZOPzsuW6qc3vDkHZNORmX4w6Lcgacu9KeMXrd1n6Wyn Gk2dWEl9ukVPsdkmvniT+J+Akz8ar3M= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-Xew7SM2hNUWmoY1oXfBrLg-1; Wed, 04 Jun 2025 15:16:19 -0400 X-MC-Unique: Xew7SM2hNUWmoY1oXfBrLg-1 X-Mimecast-MFC-AGG-ID: Xew7SM2hNUWmoY1oXfBrLg_1749064578 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f85f31d9so185081f8f.1 for ; Wed, 04 Jun 2025 12:16:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749064578; x=1749669378; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rfu56wuubM001B/pgaMkp5G9PWTbiIJhIqTlXiTrxqU=; b=N74+kBf81VfVrV29EIgRw6XuTKyrRXSbBRhNVSjIWx/e6MUaTbkKRVlx/pc/XtGVi9 qeyuKUuhOYhokr+41YJG5Zy1JArFIrT9uGpH38icek0fOnw+OqWotRPN1i/z1zVJI7S1 2tjKwxke3dwzAQTZ3bcEn6BdhJG+T6D/7QvuoF83zJnuYAOIH1fZ0Nq6vjDIHU2971wN wgea1roBKSsTQhm288xk+X1PLt4wAJYpO7G25FMbKIxT5zTeOV9Pja4qMNQ05REz1Vch QVLKTuh3aj2R0x7lVnXvsccqFGZMQ5CnjnZbhcv4qqWOHDNxI+SyUmnAbuSBNLV0EmNu S7SA== X-Forwarded-Encrypted: i=1; AJvYcCXFz1VUdz/A8DCUbRVOPupvkPO1/bQcsChoY/3x69tfUIEan46ImtPWnDttXte797o2ZMgEOBolxQ==@kvack.org X-Gm-Message-State: AOJu0YzuSlsCWj5/bF6mJeWNd+ZQQKfZIl6Y8Wc1AVvFhg0UjROMlyis qLaDrfgLUN9yKTMJWHhqEwBMsC+k9tOpe5bqhlmSHA1XbQt35kLxO/XDvvMFstZV1QTaB3mhodU BGulfIphfRz9hug5HanOHVQpewHmiHrpNP6OhkHrV3cnjBgNqLypm X-Gm-Gg: ASbGnctzHbfVTUZFtWzjCqtBrGOplNcPsvKBYFTOE1E/n2r7yJW/DSr0FkUq4IaXWuU y5F8y+DmV2Ixf21FmIz9AMPbo+eusVKE9sA/pqyVcN6CKktl7A2QSNx5CMYqsAGkYB5/WeYcSxx x95DdK6infGXhKzcz2cGI7StHJtBYSbhAzYue2oLeGNfWYKwjuCYaoq4GZ6AiubcAW5fq4aZ5KK 2zviDZUtdSjWTj/oFEAATsZrP8/1R0vjvT1HA/JSe5FzS7lROVfljmW0pmDfGCEr0czYhw2roN/ JdQPFz8T//UEE2PnXRGvvk25Auy7y1aGF5Bzp0p/0j2aev2W/txB X-Received: by 2002:a5d:64ee:0:b0:391:3aaf:1d5f with SMTP id ffacd0b85a97d-3a51d97c83amr3564765f8f.52.1749064577916; Wed, 04 Jun 2025 12:16:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsBr85DF/VWKVoy5wsZ3LFl+OisFHUCnMjMgzy50eu/xYDiBdrKcfoup3zde3lnswnlMQSxQ== X-Received: by 2002:a5d:64ee:0:b0:391:3aaf:1d5f with SMTP id ffacd0b85a97d-3a51d97c83amr3564743f8f.52.1749064577527; Wed, 04 Jun 2025 12:16:17 -0700 (PDT) Received: from [192.168.3.141] (p4fe0f831.dip0.t-ipconnect.de. [79.224.248.49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a522322534sm2200127f8f.70.2025.06.04.12.16.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 12:16:17 -0700 (PDT) Message-ID: <23316621-0338-476f-b255-9ac4dff15d8b@redhat.com> Date: Wed, 4 Jun 2025 21:16:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/gup: remove (VM_)BUG_ONs To: "Liam R. Howlett" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Lorenzo Stoakes , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jason Gunthorpe , John Hubbard , Peter Xu References: <20250604140544.688711-1-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uahjEQVv32pd2aSIwXtwePZoWjB_wd8jV-cnLeYVOvk_1749064578 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: zw34am1r9nkrhk6xr4gi39rz1twhe3if X-Rspamd-Queue-Id: 16B7F140002 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749064580-234172 X-HE-Meta: U2FsdGVkX183eeO6Li+JtlJtF31jqvCOFUVwJYFV1CQb2vUMTRJE4RIjK5nmz1qK/ZykhJoQGROqR8kxclGCeVFY7eI/fT8Be/G3EZrpzP24NPYtzP0KEYzKSSqb6xlyJnMwD1uo93uX/+ebyboJ864W/KVlVwK8aqY+XQ4zCNx+y2BK3zugSlpWB5A7Fcq3wMN8yi0bqUXOhPO56f+qUzf5nSTeUhOLfDdQV7EXb4PbV0ZaHF7tiPju4t+pUnOkL3gnPzC5xZz8MEy/V10LXlMDxgiBWlbe5qtExlKUXIq4XA8cyVQ+A8UJBi/Iw9O7z0RK6zZwrWL5+Ly5FKr+qYD2/dedElj9NBTdGdStmVBVCUdvgaGvrw2uzjigcEeedqLHh6rUbyhODyHkHUVEDdqnSgC1g5K5ylakILTy/ABpp8Cb5S6E6rLNPdOYmdzjdkTLvIzzhoYvjyechWqEDo3yb5DDfk8LNavmI8bodQUbxtLxqqCFc3F4Wf4S3znz4cvfgsj8A/4xadPaInckdNo4qNciaON3v8nCAhyQcdfjsIPF8B3ue18RkhJhnLb986eQv5JLhuasDqJweKiPkGmP+bGIgMt0aExDIjQdyiPcd13iGbVgoDVs4qarkDtUY5NXsfl3tvZRa3LSyRh3EsioALabpkUGAkRsymAnG/GchwWXKxlyZNEdmsMLIVwMBZPzuxJj8f0qp62E22+Gb/SlOa7tZ+sc2VdJT0s1AnQFVVq+42ykEZioUapo/+vw6zAdsDJf79eO76QJEd0pFIq/ip6CVMVNlDaYsrhA6Z7WTlzd0V0qYonptIhkbKzZYZh4v7Fw/adJSJJgINQeqw+AVwYKkeRBm4Q98SlBt48uN3+NfJ1MfSs5+8CuzrnrVFeKZGJe80KkXiBSF0eORS3TztRzlPg46PKtn8yElrznfnfbU06AXsa2SzqnW+SExmqs4RppAlbGC1hBAmV lAKDcru1 WmotIo3VAlKjvgIS+vs0eYrIpf+nDcdtFXV6WjLE5XF4zQQFLhILdkBMPvqG4k5OaOa7wJhIkPTHgcP5BYZX8N0KHKI2ddCybu5OLV2+G5j4rX1mLVjbUcVjGRO9XweHsJj/MzDL8ACqZ+RdeyJiOCxqA8I1x43U5/S+kUFASzs+8lSBcM2S5zdM6aXHeTpfV8msqNOBR0kmVLIhGr6eoJtYXfeoMZE9ZWTEsOwuAK0WrHF0d8bnkcx15Q4iD1pbb5slk/8C+uKgYP6fmuYMa1IU59blleCa5zkx279Cm79cjxfYxGZmQbaGisD5/CPxaaCTSzSDzDHZeVjrlpD3YWqd8NZXhCq41XqP20x+BSU6dNq4xTAE/8KavGXFWlmKrPHMpeyhwz5Fn1glRaVwqI6axolm70Q/E1qLo4T5ESz3M1hqoMZHcqNTCryPD43chNmccS8aoZ8raNxiakyT6f/n7LIxrfUtk5GIs0R+CcoDncFcqE7zqDxTr0uI7xHUbM4iCpU0MXaTRRmI+Cr5k/jX4f/LqLtulWVRmlXOL/H1Q823/1uevWyPjdbcjHgW26/d26zvXZRiGuAIrwhnz4zUDnt58HQa6B9Lk/L5RfyT+0xniccZAhAnrpt/Iu9DKiyyL8FoCl7nBKDpFlQQ4RgeIku5Io+1VLOkIFEAXAz0bxYRZC+BCvX083cVD+OItngtYsa1JlkkYNfE0ci2JfOIiwI4cl0d+6RiBKwi5ziPG2buCadjry6K2oak3g4i1yGRQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.25 21:12, Liam R. Howlett wrote: > * David Hildenbrand [250604 10:06]: >> Especially once we hit one of the assertions in >> sanity_check_pinned_pages(), observing follow-up assertions failing >> in other code can give good clues about what went wrong, so use >> VM_WARN_ON_ONCE instead. >> >> While at it, let's just convert all VM_BUG_ON to VM_WARN_ON_ONCE as >> well. Add one comment for the pfn_valid() check. >> >> We have to introduce VM_WARN_ON_ONCE_VMA() to make that fly. >> >> Drop the BUG_ON after mmap_read_lock_killable(), if that ever returns >> something > 0 we're in bigger trouble. Convert the other BUG_ON's into >> VM_WARN_ON_ONCE as well, they are in a similar domain "should never >> happen", but more reasonable to check for during early testing. >> >> Cc: Andrew Morton >> Cc: Lorenzo Stoakes >> Cc: "Liam R. Howlett" >> Cc: Vlastimil Babka >> Cc: Mike Rapoport >> Cc: Suren Baghdasaryan >> Cc: Michal Hocko >> Cc: Jason Gunthorpe >> Cc: John Hubbard >> Cc: Peter Xu >> Signed-off-by: David Hildenbrand > > seems okay, besides the one nit. > > Reviewed-by: Liam R. Howlett [...] >> >> ret = handle_mm_fault(vma, address, fault_flags, NULL); >> @@ -1760,10 +1760,7 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm, >> } >> >> /* VM_FAULT_RETRY or VM_FAULT_COMPLETED cannot return errors */ >> - if (!*locked) { >> - BUG_ON(ret < 0); >> - BUG_ON(ret >= nr_pages); >> - } >> + VM_WARN_ON_ONCE(!*locked && (ret < 0 || ret >= nr_pages)); > > nit, we are losing accuracy on the value of ret here. I doubt it makes > much of a difference though. Yeah I doubt this will matter. Thanks! -- Cheers, David / dhildenb