From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
John Hubbard <jhubbard@nvidia.com>,
Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Logan Gunthorpe <logang@deltatee.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 07/34] iov_iter: Add a function to extract a page list from an iterator
Date: Tue, 17 Jan 2023 08:19:59 +0000 [thread overview]
Message-ID: <2330483.1673943599@warthog.procyon.org.uk> (raw)
In-Reply-To: <Y8ZV9x9gawJPbQho@infradead.org>
Christoph Hellwig <hch@infradead.org> wrote:
> > +ssize_t iov_iter_extract_pages(struct iov_iter *i, struct page ***pages,
> > + size_t maxsize, unsigned int maxpages,
> > + unsigned int gup_flags, size_t *offset0);
>
> This function isn't actually added in the current patch.
Oh... It ended up in the wrong patch.
> > +#define iov_iter_extract_mode(iter, gup_flags) \
> > + (user_backed_iter(iter) ? \
> > + (gup_flags & FOLL_BUF_MASK) == FOLL_SOURCE_BUF ? \
> > + FOLL_GET : FOLL_PIN : 0)
>
> And inline function would be nice here. I guess that would require
> moving the FULL flags into mm_types.h, though.
Yeah, the movement of FOLL_* flags is queued in a patch in akpm's tree.
David
next prev parent reply other threads:[~2023-01-17 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 23:07 [PATCH v6 00/34] iov_iter: Improve page extraction (ref, pin or just list) David Howells
2023-01-16 23:08 ` [PATCH v6 07/34] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-01-17 8:01 ` Christoph Hellwig
2023-01-17 8:19 ` David Howells [this message]
2023-01-17 7:46 ` [PATCH v6 00/34] iov_iter: Improve page extraction (ref, pin or just list) Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2330483.1673943599@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jhubbard@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox