linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave McCracken <dmccr@us.ibm.com>
To: Andrew Morton <akpm@digeo.com>
Cc: linux-mm@kvack.org
Subject: Re: handling pte_chain_alloc() failures
Date: Sat, 28 Dec 2002 17:59:30 -0600	[thread overview]
Message-ID: <23300000.1041119970@[10.1.1.5]> (raw)
In-Reply-To: <3E0CEA3F.35B3044@digeo.com>

--On Friday, December 27, 2002 16:03:11 -0800 Andrew Morton
<akpm@digeo.com> wrote:

> Dave, could I ask you to check the locking changes carefully?  Some
> of them are fairly nasty.  Thanks.

The only thing I specifically see is related to the pte_page_lock.  In
places where ptepage is derived from *pmd, the contents of *pmd can change
if another thread unshares that pte page on a fault.  There should be a
line like:

	ptepage = pmd_page(*pmd);

in the places where it reacquires the pte_page_lock.

I'll study it some more, but that stands out.

Dave McCracken

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/

  reply	other threads:[~2002-12-28 23:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-28  0:03 Andrew Morton
2002-12-28 23:59 ` Dave McCracken [this message]
2002-12-29  0:53   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='23300000.1041119970@[10.1.1.5]' \
    --to=dmccr@us.ibm.com \
    --cc=akpm@digeo.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox