From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFF1BC3DA59 for ; Mon, 15 Jul 2024 08:45:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489606B0089; Mon, 15 Jul 2024 04:45:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 439356B008A; Mon, 15 Jul 2024 04:45:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3010C6B008C; Mon, 15 Jul 2024 04:45:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 10E756B0089 for ; Mon, 15 Jul 2024 04:45:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 872441214B7 for ; Mon, 15 Jul 2024 08:45:31 +0000 (UTC) X-FDA: 82341353262.18.4C9698E Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id D89D11A0012 for ; Mon, 15 Jul 2024 08:45:29 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721033111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gz3ACM9L2SYNsw0gqdiO39YvLapmR0QQ1dA5ZISQO4U=; b=BUG9F7gz55sfGnWGzCurTIkkZ7aKcLtcogJF3dhgW/3A3L7ir2/9uWqRKZwOtrhz/aVq2V sPAeW/r5lbPL9Y8ZMOsV+lWsdzLLC1bPcIC3ljhLgPsndueRArvv/niXzEkx9kAPXwr/xt 0KxmrjLqBpDzftRSYFX93K6x+wexLFw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; spf=pass (imf19.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721033111; a=rsa-sha256; cv=none; b=XLdtN4JPkxACYfki3GQQ6aWjDx0+yDn2ypomU8mjo9up/jL1+ZvwqaPMXSl6yJxP3l2ZB+ ODTKnVCqLlHSI8Wj8lbMI+sYQP2jiONNMgHNmQ2jYekFea60E+VkgjbfnPnw/pIwNV52vS eNYWhHCNGKszXKyU6EEnHCrMh9+7Jhk= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C0CEDA7; Mon, 15 Jul 2024 01:45:54 -0700 (PDT) Received: from [10.162.40.16] (a077893.blr.arm.com [10.162.40.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ABD933F73F; Mon, 15 Jul 2024 01:45:20 -0700 (PDT) Message-ID: <232f5d3d-8a85-4bc2-9076-f5cd4fb968a2@arm.com> Date: Mon, 15 Jul 2024 14:15:17 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/29] KVM: arm64: use `at s1e1a` for POE To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-10-joey.gouly@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20240503130147.1154804-10-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: D89D11A0012 X-Stat-Signature: mrhyr8zdgweakas8yueg1u79ajwqkxt3 X-Rspam-User: X-HE-Tag: 1721033129-325759 X-HE-Meta: U2FsdGVkX1+gNJMGaN/wgzJHjO4DP0/1HDEBDHIEyzRkPK0aTe7Yxhy+NreHHKGtGw2sqhKHsUoCLC1KsK2Z1kZ2Nzy7D9ZXJZ1kH5B8bba9QrKkVnMU3GI1FtThOSjqEKVhPNxPE0yetlOSRa0UeCz2KCeEAn7UC583KxNt/1f/N1RWVW5JMm2KdF0iRPDIorEuqkjqp24fNLl+gCkGa/CUTNNny1fkNeUL4gGlpGYYaAAGh5ZrWm5391pLhvkwblgLAN74E0XZl7BhWcNIbtZspNO9bASLRGvWCCaCrRKAGpuI1MLHFCmVsptdz3LjG0BRtdlyzcX6J7uEhwv/zyEzMMKmJG0V+J2lixVkozYVksRdtAuD6oSPKY9orryIeK8Du6BzgKXV5MrPenJ2m3BxJVGO6EMF1ikza4vLI6+/Lqe7YeTxfQz+cwPta8Yxf+41dYf5ighp8fpmWkUZPx1cGq1YHJkjkJSW1R4pgeqsRzKT/yYBdB9wiviPfZVDRJeetC05uA6aH8LDr+t3E9xm7rw6kqwggMzITK0s8RARbU2S0Sdl+zRY18vCRLRtCHGF2y0DscLBVUyUFtst+gkAVIH95IevxWbBWpAdqJF3NVNDqG6gG7+iwRF2y6XAGlXKy4xmeEfTkAXXO+oCvdAGF7+a76ui+i91qo4r7ochl8Dr59ZR7rgimq7fF0n5rTKqINBpzbdRfI23nSl8jycpPvkGo1aMabXSguFDZkZsDlhuHC7xZGblGIZqExMxvA0Sm490wSrX1kzNyoMNRMyglLNcdFXpsaEnD69tFIlxUDZGT3mxJ7Kpd5yUsDBkiUJsnc8iZSPChpLTy7Mmb1jK9Gy3/C9rXGcN9tCrCGAwKcJt9ewUkda3TWQJ2dte7cS+gKfhfcaPl/9jGvhrZCFVpEiSGeq56wvQFeVvzyohGsD8AA1hUt78KMp3PAhKAqEk89IR7y/LJKiBc/z ISvrCmbO kNS8DIMZhvXMK7xHGZSbLi37osc0q951w6s1SyCtxmPslkY1jAqKdmPYecsr4GlVpOAGM9hdnvETZTUg53BsWmnJkopiIsg8eZc/9yV7SKa76i0nahGrLieHzEq2Vo/HIUESioJDiqjeEaqmzExQ4lc2ENv2Fo9waPtTye2M7ue/ZvX7HYUABXp+eZJTxFe68GM2NerEpdghUvRP9MEokwyl0rOeWp/1aTIJnP5eThkNBH4wNfep+D4xWNoLvNlR4n4Dp+roO3acUPYQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > FEAT_ATS1E1A introduces a new instruction: `at s1e1a`. > This is an address translation, without permission checks. > > POE allows read permissions to be removed from S1 by the guest. This means > that an `at` instruction could fail, and not get the IPA. > > Switch to using `at s1e1a` so that KVM can get the IPA regardless of S1 > permissions. > > Signed-off-by: Joey Gouly > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Catalin Marinas > Cc: Will Deacon > --- > arch/arm64/kvm/hyp/include/hyp/fault.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/include/hyp/fault.h b/arch/arm64/kvm/hyp/include/hyp/fault.h > index 487c06099d6f..17df94570f03 100644 > --- a/arch/arm64/kvm/hyp/include/hyp/fault.h > +++ b/arch/arm64/kvm/hyp/include/hyp/fault.h > @@ -14,6 +14,7 @@ > > static inline bool __translate_far_to_hpfar(u64 far, u64 *hpfar) > { > + int ret; > u64 par, tmp; > > /* > @@ -27,7 +28,9 @@ static inline bool __translate_far_to_hpfar(u64 far, u64 *hpfar) > * saved the guest context yet, and we may return early... > */ > par = read_sysreg_par(); > - if (!__kvm_at(OP_AT_S1E1R, far)) > + ret = system_supports_poe() ? __kvm_at(OP_AT_S1E1A, far) : > + __kvm_at(OP_AT_S1E1R, far); > + if (!ret) > tmp = read_sysreg_par(); > else > tmp = SYS_PAR_EL1_F; /* back to the guest */ Since the idea is to get the IPA, using OP_AT_S1E1A instead, makes sense when POE is enabled. Reviewed-by: Anshuman Khandual