From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DD78E77183 for ; Wed, 18 Dec 2024 06:28:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D2086B0082; Wed, 18 Dec 2024 01:28:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 981946B0083; Wed, 18 Dec 2024 01:28:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8498A6B0085; Wed, 18 Dec 2024 01:28:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 641CC6B0082 for ; Wed, 18 Dec 2024 01:28:33 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CBDDCC0BC5 for ; Wed, 18 Dec 2024 06:28:32 +0000 (UTC) X-FDA: 82907100276.16.AC88B4A Received: from out30-112.freemail.mail.aliyun.com (out30-112.freemail.mail.aliyun.com [115.124.30.112]) by imf26.hostedemail.com (Postfix) with ESMTP id 4E3F414000A for ; Wed, 18 Dec 2024 06:28:05 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=qBOGgCay; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734503297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NENYlu16qMH+2vYQF+ATHDH+bfs0XF3IbaQTvxHr3JA=; b=YUGzgQweyIbVAcPZUvM0IUGUoS2TTuIq8pPtOm4YeHlbYhNR1RkPG9ax4Goeas/rSb5Y3p OqY/Cku4NIhW/fN677b6pmlp1FWYY0ST3lZGvzwfi3wPAb6AdtMmthZ3I3DRKKNSNxQ6pq LseLn7dBX7iMLr00AYGARap/S7MtTIU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=qBOGgCay; spf=pass (imf26.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.112 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734503297; a=rsa-sha256; cv=none; b=pS15pIEHUtBCevaMWvyegrWlKn5B4IbMSo3r8UDdMTC+NLq8XBdSq02N/tVVRUCQmFRaue EmAembKwOoAXUSgX/cLBbl0L53/uqZnkI+KYD7x41B/ldlQYwYLlLFkLjj+Yc8iLJyZStM UrgxMRCIVmAyUQwot87lGP4Ev/Lj7vo= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1734503307; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=NENYlu16qMH+2vYQF+ATHDH+bfs0XF3IbaQTvxHr3JA=; b=qBOGgCayuPGxAydk82NKB21XYaz0fvUOyPzn09x+vhoT/73RVbW/VeBcoHiEkuV1pGzGTDsDnXB8GfDx2PcLiUVmgkInLV+2jl3CK3ITXT0KFfG0N/+7lG3HQkUBIDMvjlQqkM9a+A0S57mCQ0p+Uder1jSYPjkBwq2hJQl3Bjo= Received: from 30.74.144.132(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WLlPUX5_1734503305 cluster:ay36) by smtp.aliyun-inc.com; Wed, 18 Dec 2024 14:28:26 +0800 Message-ID: <2328c2df-fb6c-4c7f-8247-5061b0f94f06@linux.alibaba.com> Date: Wed, 18 Dec 2024 14:28:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] docs: mm: fix the incorrect 'FileHugeMapped' field To: David Hildenbrand , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4E3F414000A X-Stat-Signature: r47erh1rwbnhydrg4spiggxe66pbrmye X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1734503285-563274 X-HE-Meta: U2FsdGVkX188Q/OhpdNaYTwursEirQuB5R1ichn6a9ceXUYLMQm91laDstFb7NfEgsjdJMCrXXzILuWqruZI4M24FuPJGKxXb+2kJrk/P6/GsS355TtRJBH/3hfTxrEbaViJrgTw2O3QbqblnGuex6Y7RkiqLcTnx6kWOJJPKYz06/zE6kwLjjjdQWYmuv1Mpx7Xg4zze1gzCIH2DIALsSvNWdmoxhd56yWt/d9vU2ugHthxK8IG7+UpMKOoCos905KORNfyLmCbFJz3bD7xnfRQOVyZUGpi1/LBt6wFGvOYiAKH4GEcTzjMQIFijHkBPfvI+UZzPaLSYC7svSyBo7TAjn3ZiCyW7AZdaSYl7a7f2OAzFU9BJFVSFupgGi40N3C8v20vact5cAxf0peynikHhnGpVdt06o+WbliqtB5JYNVDOeE6OwhWgTUX1xqWTWcdvtfF+i1zDIY8lYXby2TQSPMNBiSwwfAi9aJN7z7jeeLaOe9Z2JeQtEwybAxYIGwu5Qcsuy+HXPUoMVpMtQmFakisYhqbucd9pDTbkyZx/sKbOrsbhld2qeIJ5pEN8IuCx4v0AflwWYn0+yoOpWibeMX/pdA030Nr6jz5P7eRqjoAk+/XOYtKAIJXIFwBud3W2oEap+qYVh1oKrbFleJnF+2vpUdVxPOfQBilgjqe9pkGIryvaxJl8Q8ofuFMCjOujxlGJ5bbbyHgALrIjlPAHEaZVl/LmxOLOeI8DUF+kcMMjo+EsdAEGvKBEO8DQl2HS3B1i/9k7qIAXZWDNs1dZKbRXzalYTt8CusfZzIXermNYpfGc3vlEvFYsXco99GMAt8KjrNXLlEYhXAk8S88cDJpPP+hHFvOjrnYxHB66QN5jG45G4Eqgtvk/wQXsIBzayo/IUuzKjMJWP9L6AziPUBGw/a78CLWZZL8oGD++GuDSWau9vqPGh1OaXTjEhKM8LFl3YozVx/1Uvm sDnWk1ys xXHHtcfyx2tpwfpsK6JQNqL2iCd7vMoX4vXNXQqPUuLS5+IkEVeDQufTWgBuwkSrXoLCEL8va4yMTTa79DG8c/Xl6pHjW6R9rszYHA/i+GvU/RTAULQJoO7A7GMOUerpOYIGqTSPaDC02VTbK3cKm0CcuQVoqNXlMPQBjSoITRzKzdej9QeIFlrxcE0TWcBsoAfVprgXgVKw+scdBWG0QRhWl7ho7/Sxvx7uSITmPvHZZ+e1qpe9IUZFp6RcfKT0BH94bAKTOASguhoEL36iYOHPH4NK4Q4UClAtxV83M95DxoiXsYS88R60DTjrvvqAzQ1BQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000953, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/12/17 19:59, David Hildenbrand wrote: > On 17.12.24 09:55, Baolin Wang wrote: >> The '/proc/PID/smaps' does not have the 'FileHugeMapped' field to >> count the >> file transparent huge pages, instead, the 'FilePmdMapped' field should be >> used. Fix it. >> >> Signed-off-by: Baolin Wang >> --- >>   Documentation/admin-guide/mm/transhuge.rst | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/admin-guide/mm/transhuge.rst >> b/Documentation/admin-guide/mm/transhuge.rst >> index 156a03af0a88..dff8d5985f0f 100644 >> --- a/Documentation/admin-guide/mm/transhuge.rst >> +++ b/Documentation/admin-guide/mm/transhuge.rst >> @@ -466,7 +466,7 @@ AnonHugePmdMapped). >>   The number of file transparent huge pages mapped to userspace is >> available >>   by reading ShmemPmdMapped and ShmemHugePages fields in >> ``/proc/meminfo``. >>   To identify what applications are mapping file transparent huge >> pages, it >> -is necessary to read ``/proc/PID/smaps`` and count the FileHugeMapped >> fields >> +is necessary to read ``/proc/PID/smaps`` and count the FilePmdMapped >> fields >>   for each mapping. > > We should probably change the above to clarify that this is all about > PMD sized things. Yes, I will create a separate patch to update the document where it needs to specify that it is for PMD-sized huge page. > Acked-by: David Hildenbrand Thanks.