From: Valdis.Kletnieks@vt.edu
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-mm@kvack.org,
ngupta@vflare.org, linux-kernel@vger.kernel.org,
francis.moro@gmail.com, dan.magenheimer@oracle.com
Subject: Re: [PATCH] staging: zcache: fix cleancache crash
Date: Thu, 15 Sep 2011 19:56:46 -0400 [thread overview]
Message-ID: <23267.1316131006@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 13 Sep 2011 14:19:22 CDT." <1315941562-25422-1-git-send-email-sjenning@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Tue, 13 Sep 2011 14:19:22 CDT, Seth Jennings said:
> After commit, c5f5c4db, cleancache crashes on the first
> successful get. This was caused by a remaining virt_to_page()
> call in zcache_pampd_get_data_and_free() that only gets
> run in the cleancache path.
>
> The patch converts the virt_to_page() to struct page
> casting like was done for other instances in c5f5c4db.
>
> Based on 3.1-rc4
>
> Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
I was seeing all sorts of bizzare memory corruptions and panics
and crashes while testing zcache - average uptime was only 2-3 hours.
With this patch applied, now have close to 24 hours of crash-free operation.
Feel free to add this if it isn't in somebody's tree already:
Tested-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
prev parent reply other threads:[~2011-09-15 23:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 17:37 [REVERT for 3.1-rc7] staging: zcache: revert "fix crash on high memory swap" Dan Magenheimer
2011-09-13 18:56 ` Seth Jennings
2011-09-13 19:19 ` [PATCH] staging: zcache: fix cleancache crash Seth Jennings
2011-09-13 20:56 ` Dan Magenheimer
2011-09-14 9:26 ` Francis Moreau
2011-09-14 21:02 ` Francis Moreau
2011-09-15 14:16 ` Dan Magenheimer
2011-09-16 17:55 ` Greg KH
2011-09-15 23:56 ` Valdis.Kletnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23267.1316131006@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=dan.magenheimer@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=francis.moro@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sjenning@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox