From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 920DCE92FFD for ; Sat, 7 Oct 2023 07:29:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 301578D0007; Sat, 7 Oct 2023 03:29:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B10E8D0005; Sat, 7 Oct 2023 03:29:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A05B8D0007; Sat, 7 Oct 2023 03:29:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0A7B08D0005 for ; Sat, 7 Oct 2023 03:29:25 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CA178C0134 for ; Sat, 7 Oct 2023 07:29:24 +0000 (UTC) X-FDA: 81317839848.14.1AAED49 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id BA15DA0007 for ; Sat, 7 Oct 2023 07:29:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hz6oT4nj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696663763; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P2XYj63JutQ2NopEHr3614ehw4VQD2DCO6wPQwn2C2A=; b=AoQEQSv4WgISMXcCWAWdiyILnO3KqEdtnfLVZixJ4TUwbcI1dwQW+Zi1j5S/h/YhQwYGhw XJTlN3b1qqIRYYgIJU9BuQj4uHc8kOyYzWL3vKTWbBwzqqs48zANmooKqpeoUr+4GlShAV zOWskAjUKLnlMQ6YOgw4zUuvQDhF0l8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hz6oT4nj; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf25.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696663763; a=rsa-sha256; cv=none; b=V8kMU/1mSSqvnhF45h8nFfmMouq97ximKnAT/V0Ywi0ZLC9veLRcGeA4/A/fR8Wws6nikd Z5/Z0TpFuG6W7xJ/GedaHWqoyi7Cd9j6dNp+gLyFW+xjg7CGECYy9WubO46TQnIhBJoYQ+ gfNj1H32maeHh4l3T0vhWgO5ateFYi4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696663762; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P2XYj63JutQ2NopEHr3614ehw4VQD2DCO6wPQwn2C2A=; b=hz6oT4njxv8MutcApmtguAkGLuSZ3KbUwzjOvX9zEV/8/Fqf8JFm9G6GA/2VsA9Mj7SavV EZ5bmSBBNI+use0K/sN1c+GWp0RmlTtHEaNJrI7uJMht2UXeDZFl2Hh+V4nm59PfG2cm9l FDmsizFTNoWOZ3WRjoewtVg1ZdXn3e8= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-649-Id4xzfQGNO-7JeT9k6sb-w-1; Sat, 07 Oct 2023 03:29:18 -0400 X-MC-Unique: Id4xzfQGNO-7JeT9k6sb-w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A24B8380200F; Sat, 7 Oct 2023 07:29:17 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id D59FCC15BB8; Sat, 7 Oct 2023 07:29:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <356ef449-44bf-539f-76c0-7fe9c6e713bb@google.com> References: <356ef449-44bf-539f-76c0-7fe9c6e713bb@google.com> <20230925120309.1731676-9-dhowells@redhat.com> <20230925120309.1731676-1-dhowells@redhat.com> <1809398.1696238751@warthog.procyon.org.uk> To: Hugh Dickins Cc: dhowells@redhat.com, Christian Brauner , Jens Axboe , Al Viro , Christoph Hellwig , Christian Brauner , David Laight , Matthew Wilcox , Jeff Layton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH next] iov_iter: fix copy_page_from_iter_atomic() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <231154.1696663754.1@warthog.procyon.org.uk> Date: Sat, 07 Oct 2023 08:29:14 +0100 Message-ID: <231155.1696663754@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Queue-Id: BA15DA0007 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: ek1ak1xebn946ptmj6u8oaof4aszf3rb X-HE-Tag: 1696663762-367784 X-HE-Meta: U2FsdGVkX1+G1olu+A9S7oEG3tksqhd5z56HfpPcowsXzSHGCFuVUyGcisBUgFc6PqRweK/kxIp1k7Rm0+7AhhXEXdu49wMOmqyiQsjwffmB6M580ozRvmHi5ZV8tKp9qSgg5o0ai3QSaXiqHfmQiX80CgfScCe9uzVIJbiqbyyCldOvdgX9gax3wuhUkbeMr0WvE1BogQyeCirph3NHV39zmQF/jzwj1opYYbOJ5U4TPpGstFrUkKORy+47CfPSkSRPnt0d/X7IwY76qBUNFnQwvpMWI6cDFobSK5omuYFGA8ihuGPnkKpjG7QhY11gSjxEq5+lae/MiqA8+qgqMWxHGz0IhluftJMSkLByxqQuP/55+oipfQvPtuf7d9wc6KZ1/4gkv9t/IhHVFch5kcluhRcrfNolYE5FuzJ8X+EFL4GAglBiliJWLa9kzSfECdw6MNfxyMOUZtM8eFbv2kD6UcoZQqKju7X1qBywz4luYg+vnvbFHu5QsNCVBv66qdtU+FdPDXmtjc/TG2x4f9SLnyhYmAHtT6fJR3sYmlsWltBRlBhZ8lUrhJN9u9bNVVq8gLwwV0ghUSTWEIBMcsxvpNbX2qHka90ZKBzhY1VKHvCUdbhlQkp7X2yKEHs8GuEHxuwpovAsh1KM1zqFW1azFSSXmTVr7U+lo7x5EiGL9+UjiUS2iOp6+ZHPGfWjTj0LSmwFgUeEMOUBW1cq6jmBH64KPjGFr4UPBWiBh/onz7lzkbsw9Z+gLFftVizCHhPeBRoZb1+pB6XFERqSZnbEzR13C+zCKLUBoQpL55NM8VpBSHiupb7+9XSw+J3rt6Rs/MJak7c1KEymd5Kb0AoAW37uDhPn2MzPOk5R55MiC7ETOCzZcaT3wwZPcTFGVPirDHZrot+0gcLkxhOd02++HlExPY5qYkZl4DpwCmk1fdvvvOCmALXmNo65TALXWyGpZr+movMN0UqovSY 8eX1vXo3 pfKhqJ3et29RLZTTgDQN5jMAvtYjBmSTYcqpYJYVS3YYMbTVGQV60f380HPabey4+mr3ng0bIgDZ9FgUDzvdZhk4pNuAWG/uGMpmRME7pjEMPPHyjzu3aJeSwk5jjIz9nyy99LnN1o4QMTeKFo93PnJixlx2EZ+Gqys318JEf4NvZCLqWpaO3BIA77ymee+4u0Bz+qwiUOytE0jtmFlA3Cg3ICFuBIm4pBWh2FMPIvZau+TbGsB8A0ZYk5A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hugh Dickins wrote: > - __copy_from_iter(p, n, i); > + n = __copy_from_iter(p, n, i); Yeah, that looks right. Can you fold it in, Christian? David