From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B86EC2BBCA for ; Fri, 28 Jun 2024 08:56:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 021346B0089; Fri, 28 Jun 2024 04:56:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F13086B008A; Fri, 28 Jun 2024 04:56:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E01E36B008C; Fri, 28 Jun 2024 04:56:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C243C6B0089 for ; Fri, 28 Jun 2024 04:56:29 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5A6A2140CF6 for ; Fri, 28 Jun 2024 08:56:29 +0000 (UTC) X-FDA: 82279691298.03.25BDEDA Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf02.hostedemail.com (Postfix) with ESMTP id 41C3F8001B for ; Fri, 28 Jun 2024 08:56:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=UBDbLBJL; spf=pass (imf02.hostedemail.com: domain of tvrtko.ursulin@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=tvrtko.ursulin@igalia.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719564979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ABLvUC/ePHzSEuBbp1KLhmP8GQstWD4khOur3Y/Z+Is=; b=E68IFZP6UYHicnvk0weIqfXgwhW8WckrdWahDlkRa3ZxZblPxVqimBYspP/38RoHOYkEb1 KfmRvJn6SpALsmrFD/kiDXjX/5Be2EdVMTAFuxOqHmJ3F96wlWYIv3b6ZLvET6VuTSzO75 MWBP33pUwqJEZMj4b+u5lP0ZmIC/hKY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=UBDbLBJL; spf=pass (imf02.hostedemail.com: domain of tvrtko.ursulin@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=tvrtko.ursulin@igalia.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719564979; a=rsa-sha256; cv=none; b=NkTtGTuaLmLwzDE1u4cqKYKhLo/6gXv5soJWUanTpLHa4rpnJesOk7jHo2OGnZQGeh8MHV iynwzqs4666VTvmPOeVTWERJ4hABCud5oOJwuLE6VDYCkP4QoKfK2ngh60j5Msi8acrAc3 ewH1rICHppmbuRGvO5Xk82O25L48hik= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ABLvUC/ePHzSEuBbp1KLhmP8GQstWD4khOur3Y/Z+Is=; b=UBDbLBJLDaySytJdd/gG1JXQEK LUqoxxEwnrvLmfKs0klpIjjoUNPz66cElli4bZRd5uRmnrV9bs5GfoYvqtzdpLggOFlMfiT5N1DXv 9imsnlKes9ddmUi4du72f9ekeb0kDCGIHENUjobK8hr1QOUUhvB86rRTnizukPD7NJgNhvr/fXn/A BsQqOXtms4TFyeztfb7NHID60EduJg3EwagzX7Y4soBxDPFkKEpjzEN31ze2/v1LVc1atm3GeiLsh g5LVCOMgCR6v5ftR9Pc+wRftfYg3HhFuLgebl7xxxIBCMdtJmQeoAZqFsulKch6I4QzTN3ROtYT5H NA9PT2bA==; Received: from [84.69.19.168] (helo=[192.168.0.101]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1sN7Oo-008XRH-Hh; Fri, 28 Jun 2024 10:56:06 +0200 Message-ID: <22e9cd24-1ed4-4f1d-b7de-b44cefca6009@igalia.com> Date: Fri, 28 Jun 2024 09:56:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/numa_balancing: Teach mpol_to_str about the balancing mode To: "Huang, Ying" , Matthew Wilcox Cc: Tvrtko Ursulin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-dev@igalia.com, Mel Gorman , Peter Zijlstra , Ingo Molnar , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , Michal Hocko , David Rientjes References: <20240625132605.38428-1-tursulin@igalia.com> <87bk3lpxp1.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <87bk3lpxp1.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 41C3F8001B X-Stat-Signature: bg17fr11hpetbue33zhz91zewq4377h5 X-HE-Tag: 1719564986-741055 X-HE-Meta: U2FsdGVkX19JP57UTfqO5+FCHWp/+lqly5Hx0RAKTd/Gj8abtUJOJnKTZCJA3P/dtsfCfz/MnH2gcHJTFHnCTazQ47QiAFljMhVnSRWoVfIoKPFlXHp7qJr9VumHviHRKKF8bIsofRpywxC8RZ9CEiAnaA0/4Wsc+SMpcOUgQh093Rg/qSWLqhvX3fM5ZFkekVcsKNIQLFFCvdllVjVYWCfD+9/3q/vqWgyixM/xasE3t8Gftq8Cwk/QQuDujWAVOe9FzKvAQm85ep4ZHjWRVGv9QudPxHyXFPFSCX9aaVDWSrqMK09r3SRYkTKS8uZnBLus1fcpAY4VuNhHYXF4iKFbw2RoHgGSx9PjYzqCmZTrHT/hMJFax/zlqDdc+eMq9JDax1a8eWqLZ9ttbuG2Pmkx97t+SD7LWqKdPzkYQoNB/xI7/qbmmpUvmDTB2FVFIlRgkeKKrj2FDZQZmvy8NAT4IDymdIPmuvp4VKI6DLwPAMWUI4GnDu8QC5C/vlLi90bxpX78Pt+rRVnTHuBNLwJWnvKUo3cgGKTglZ2jWVXlTCtpJLCTj8jfxg+f6rIJvggBqbhyuVqNx3VPNlQAPmEBkX+hpxvDnM6ZoSLkzsDMli5/3QM9oXfY0A+X6cw2DjW6NZC/t30CMKcJefXQI6oG98VhQrB+IIZPNKFrBegZg4Ix66p3l8NT20jHwp0/i1cSm6lh9AZQnYd5HPeWBO7PCWeQdXWgR6daEWzmJgAOp1VTjSDkFzrshJ3G4xj/TohqV3ssN/o/Oj+EuOEK0qexJuIg1YLyF85dLJGWBnRoj6yPlHg7UuWBgyb9wUT4E3s0Nv2aKasMesHBQPQGrTSxG8cwFnee1kcfUWy45v21MaVlv59l3Wk1XP3DRncdZEtxPjU+nAvPwZygfuBrCPvAsj7O3nSrAIYRa77ZNv2hFJ9ye7y5pEdcuqTkBLc8s5eqDHmiv+sm0ns8Hpy Xlf8TX45 HvybFnUXmVdXkwhQGbGpiJKE2H22b5TVltPJb+xVC3HuBrpIayy5mNHMa4L1NtQAoaFFGpkygUTdDyXbeaffgZ+C68jY5mZD3XG0j233U+bT2uObK1r64bTnmOwlpmKzYMpOD77waIxeXOm8oXMnDEoY0jLSZ87I2aaAT7Oel1bFQsswlBIvMoDePJR0Vwwoq7yuCbBBfWmEl7fHlCD51RgU9WBsXk+NhWDQjHxd1ntVBO+cf1I47urmmsw3F59D5IF70/zL0fsnDvZa3qjvoCgxJjGWBIfkZk0BGYPQXoglYnrm59SGt/4jn+5T947HA1RaOZscwA7Emgm4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28/06/2024 04:12, Huang, Ying wrote: > Hi, Matthew, > > Matthew Wilcox writes: > >> On Tue, Jun 25, 2024 at 02:26:05PM +0100, Tvrtko Ursulin wrote: >>> /* >>> - * Currently, the only defined flags are mutually exclusive >>> + * The below two flags are mutually exclusive: >>> */ >>> if (flags & MPOL_F_STATIC_NODES) >>> p += snprintf(p, buffer + maxlen - p, "static"); >>> else if (flags & MPOL_F_RELATIVE_NODES) >>> p += snprintf(p, buffer + maxlen - p, "relative"); >>> + >>> + if (flags & MPOL_F_NUMA_BALANCING) >>> + p += snprintf(p, buffer + maxlen - p, "balancing"); >>> } >> >> So if MPOL_F_STATIC_NODES and MPOL_F_NUMA_BALANCING are set, then we >> get a string "staticbalancing"? Is that intended? >> >> Or are these three all mutually exclusive and that should have been >> as "else if"? > > Yes, this is an issue! Sigh, my apologies. I was sure I tested it as this patch was part of a larger series I have, but then I decided to extract it and send out and the problems obviously go deeper. What I think happened is that I probably only tested the other direction, setting of via mpol_parse_str(). Andrew please dequeue it if you haven't already? > Dig the git history, in commit 2291990ab36b ("mempolicy: clean-up > mpol-to-str() mempolicy formatting"), the support for multiple flags are > removed. I think that we need to restore it. > > Done some basic testing. It was found that when MPOL_F_NUMA_BALANCING > is set, /proc/PID/numa_maps always display "default". That is wrong. > > This make me think that this patch has never been tested! > > The "default" displaying is introduced in commit 8790c71a18e5 > ("mm/mempolicy.c: fix mempolicy printing in numa_maps"). We need to fix > it firstly for MPOL_F_NUMA_BALANCING with more accurate filtering. The > fix needs to be backported to -stable kernel. Will you work on this or I can follow up if you want? Regards, Tvrtko