From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D8E5C02188 for ; Mon, 27 Jan 2025 18:53:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BF78280196; Mon, 27 Jan 2025 13:53:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84964280191; Mon, 27 Jan 2025 13:53:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67464280196; Mon, 27 Jan 2025 13:53:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3FE3D280191 for ; Mon, 27 Jan 2025 13:53:39 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C13C4C0569 for ; Mon, 27 Jan 2025 18:53:38 +0000 (UTC) X-FDA: 83054130516.28.ECAB649 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf05.hostedemail.com (Postfix) with ESMTP id 6B35B100015 for ; Mon, 27 Jan 2025 18:53:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ZlZtoVu3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=tVsyQD6y; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738004015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MwMWWn6cpMPYQb1zMiwquMFTSb64mNP5LAkIh/vIVis=; b=tXjuAJE10j7qdECBKjZvkbwP/rXHcVXGfKg9Boy7NM4vjmUB1o99omDnGIL9eZbzsoVpOE L+3bWehAWFvEXKoXeV1t1ckPzMusumXVGULha6jq7ctwfHzdan8YKCVXP4wQPV6+pRWFL/ TvIIC9NbjWxInJkwh7kSZKfxK4SG4YY= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1738004015; a=rsa-sha256; cv=pass; b=fb1eeAurr+x+wX+eLQ4m7Na/wvollTo1RZXrocLAk3ySuWS2K1+2K/L69RURy0MYsb5aMu CnbdNcX/3PfijbO9DpruGb0H5BrZQ0HFVQv6sYzGb7ox3xfFFDzotK8NylgReFd30Ac4/T 3YCKE2JulJU7XN2VaVjDJix01n+Nm7I= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=ZlZtoVu3; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=tVsyQD6y; spf=pass (imf05.hostedemail.com: domain of lorenzo.stoakes@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=lorenzo.stoakes@oracle.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50RIXm2T028882; Mon, 27 Jan 2025 18:53:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=MwMWWn6cpMPYQb1zMi wquMFTSb64mNP5LAkIh/vIVis=; b=ZlZtoVu3rJZa9gHTjnGqsdrpwE9gyxJDpA tvnl92S74Vz3vzWxHcdSMXJOlCjX8SswdGEISZxvtJlfarx6DGfEUy2mGF31sKXk spJh0tUMV5n6z82dRjiQkqsK7nGKhOPJxoecFctI/srpf7g/X7CPuqFf6bzFn+R6 S5Al3oF/dyUKOqEaPriIVJOlDSHa9nLw00+RTAE7ZiynqlLCORAhkEe+KLXgI77k XQ6M9sW6sytAHouNYcVBW1AsJ69TfhTZzlwO74kcDdInhgYcl5FUchDTeHvBnrjx yuNPHF++SEkScDPu26bshsQ4D9G2zUz3ooPVe5h6JumiHM4bfjIQ== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 44ef4f032m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 18:53:30 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50RHYoLB036012; Mon, 27 Jan 2025 18:53:29 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2174.outbound.protection.outlook.com [104.47.56.174]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 44cpddce8t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jan 2025 18:53:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JuGVjV5pTPsGrsez+JBjMjmKAbrhYgdleaqtHUu5Ffh6X83OXy9/CJ9+YcSPsHftpPMrjPnghV1rz0Ch3Cts+H5KhaFXJ3iUj1q8wZM5VkxzgwpwxdFi9i9rUEJtwyXgyVin3A5z9+tsB1Y06v7nVdeq+CEoWZHm5Gmhbtld+G1+6yhsDmfPGnUaB7RpNxWixZtIdHwbodCI2JvKZj2Da0o+Baf8ujPl+qhxAZzc1hTX0WEu2xLmid3igbjlPtU6ftlzd5L9S4VZb8G5eIKburAOrjjfBfTR/oMlmMmHiLRoNrFYhFYLRQFfvhH/Llq/hLZs7Z33yXEi9xe5eNcdVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MwMWWn6cpMPYQb1zMiwquMFTSb64mNP5LAkIh/vIVis=; b=u2BYm60vLXdFMMjDcEphez9sxt9OILal0B9WgRNQNm9iihn1hxE94EMHHVC844/ULi0PB2DccQFyZC9iR3KyfVAq/kQj94LCyXjBd6/LCEzB7OFaxwo4z5UXjzvW9BRkPDBq4teG7zbHPHEyS7iYdWQyBR1P3msTUUVKQ7HI6IVXxVupbhrWIuSEw2BuNSYpiSeSt9BO7rdU1hJu1ViabW41VytoWoB9U7EX37poUnil9WL8Bl9UJzKwWIq6PzpkAYfJo0pztOWzNJVbG3MusOeINr2wdVUe8GHQzzi5DQGkNycb2vq0GFJXjPz8ktc1BB4haR95iYnNyx30qe6RBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MwMWWn6cpMPYQb1zMiwquMFTSb64mNP5LAkIh/vIVis=; b=tVsyQD6y83KGhDl6TnTVg27RE0KvnQXnpsFVhiEKvjQS3xARl3qf52QpWe/pWb56sT0pvzz7kLUG6vLlZsZ0XsWl7awtWmplYQNkU85wdmJwMXM5E6W7kFJCMrXUpaqV9OQPKXzd14RR1ryDZlakjDeDv8R3Ypkm4DZbqZ92EMA= Received: from MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) by IA3PR10MB8017.namprd10.prod.outlook.com (2603:10b6:208:512::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.22; Mon, 27 Jan 2025 18:53:26 +0000 Received: from MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348]) by MN2PR10MB3374.namprd10.prod.outlook.com ([fe80::eab5:3c8c:1b35:4348%3]) with mapi id 15.20.8377.021; Mon, 27 Jan 2025 18:53:26 +0000 Date: Mon, 27 Jan 2025 18:53:23 +0000 From: Lorenzo Stoakes To: Alexander Shishkin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox , David Hildenbrand , Andy Shevchenko , Li Zhijian , Sumit Garg Subject: Re: [PATCH v2] intel_th: avoid using deprecated page->mapping, index fields Message-ID: <22d79ad1-0064-42d2-9f69-883ec2872c11@lucifer.local> References: <20241203080001.12341-1-lorenzo.stoakes@oracle.com> <0fcfc239-19c7-404f-bbc5-70a29ccf6ec0@lucifer.local> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0fcfc239-19c7-404f-bbc5-70a29ccf6ec0@lucifer.local> X-ClientProxiedBy: LO4P123CA0615.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::17) To MN2PR10MB3374.namprd10.prod.outlook.com (2603:10b6:208:12b::29) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3374:EE_|IA3PR10MB8017:EE_ X-MS-Office365-Filtering-Correlation-Id: 59914e14-92f1-4704-1049-08dd3f03e16c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?q3nSmoMrD9/2o7bfBRo6c/92W2vThph7UQgo5SdecnnQcJRnUxARwXh+w+Ux?= =?us-ascii?Q?GP95cO6LH31g/rw4x/juGleh2tW/HNKrrtKQQ/H6T00tTOq0HY3IqRqHpDFu?= =?us-ascii?Q?8MzwNBHZCRgwsoDtlxzcNRGxhscTDcb8F2cxW9EYj9ELHQ+WFmieCHykBOj5?= =?us-ascii?Q?SrGSBoJ8wuTlZMB/23yF5QuZtaY59ZcQDDevoEsbtPga6LunvwAzOpSFeJnv?= =?us-ascii?Q?Cz45rT0fJ7b1GrxSEUBEukI5iS8WF5uneeDDAn8dNyxta4eDni5vLwaVK3zm?= =?us-ascii?Q?2vC3H7+M2panSANUkdngWuZJGKqCc4OqRdyRyjcZAw2Hq5zI4bf2yj71aVnj?= =?us-ascii?Q?WVfCPvGxwS31nPfsxPrbNm/vny4DWQy8lKG2INVl2Ca/3AU7LSOoovgDLhYc?= =?us-ascii?Q?f0yQZUt1Y8DBmEtyFmXfpWqKFwLzdM9W7TMNv2PlqEKtIOo+ERTT+Qh/UIFL?= =?us-ascii?Q?o93O+n7kbuhOq6GiaRMIcbc0I5sDZRHmuZw7SghRC0/3j8b/mpZYg21wf84K?= =?us-ascii?Q?TpJ5cKfLfiEm4441cNkQWZtT20aGEnGdmLgMvV+3UN63g5e78DetuaAzAkNb?= =?us-ascii?Q?gEb4/+DqdkMHU2O029/+Vx33PzXPhahXWGWjoo7TRP38lT85k4yTWkejmKN8?= =?us-ascii?Q?Nv+2WZ5gDki4fQylLTfjNcivFi8or/B+VprXcY9Lb2LdmGgkohfZGUiPrseQ?= =?us-ascii?Q?6Il0+er0PF+qtlZx/bArH2h9cRMfohs4eDr1HFhndQ7OPLrLTWGsznM+BSVC?= =?us-ascii?Q?krPZxRGvxmmGVYCRwi0HuXQZ1yLw5kSqIJIkp8Vffs95cW+GseBeezSKZ68Y?= =?us-ascii?Q?8R/rD4DnMWxHwbUmLTX1vWnoenPDH3ClKknjM1N/i0v6tlg6h9EPy5nck6+h?= =?us-ascii?Q?gpD7IoONdnQBXwPRGFWWr3RPQskp+Az911JiE+7DgwDC+Eg8S9t4U8w8Ahi9?= =?us-ascii?Q?spDEiOf0Ua6+wNTvi7NbQ2yZNFYn24O9O9iVlHqK2oNYAni8WyC0xLDst9h4?= =?us-ascii?Q?KQMddjogYwjrpsiAK9iw0IZBHTSqR1DFOLbn1SSfFtF5L0u6WtVzcC7cb/k5?= =?us-ascii?Q?RnJnxTAnrK6HHUluxnWNq1oAeyTtKXlu8eR2WqlDc30x0gRrGzIYhjJqpeEe?= =?us-ascii?Q?t4zuNtqnbsfnqmFQav3mEFuZbJCdhA+z4iO/jzp4weZRr+8R4BmA8Ztq78so?= =?us-ascii?Q?2E17+Kib1r1ebvzIheh2EIp3FFvAfu0mAUywxoThy0Xl+5gANZhCJoUP5XSn?= =?us-ascii?Q?iC3ba9dnLEanD55rZxRXGpctilLnKfqEYc0w9Rs2JBawFLuhYcin/s+cvoBY?= =?us-ascii?Q?VYJQVMFNNiCumgpJQysqzFG5iyUWhUTrPz4AHO/g3ylW8w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3374.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MB5GO4nPy61Bv+gk5qGEdkYpnJdf4zIbCKsyehHsBn90MNKLGoDCONjAV3CB?= =?us-ascii?Q?Q+IJOkolcquMc96aIwjUXTwcoDfPdeSkmNwXAhP7dwgpOJMzBuVoHR6ulgxe?= =?us-ascii?Q?WHDUKZ77c8hv2tt1pvyGU6yIvqWYKSzUzkV11grpY9oxij9SR4aBD5SMaU5y?= =?us-ascii?Q?CumFC9cVYWrHIRGGB9fy/S5Urkm6Q00UQuZC0/RSO2yHNFYB9wdQMBMsVg6V?= =?us-ascii?Q?bXTPtCf0nzSdZ5bozcPpUV6dofDhmuNvVLF5MYpVbh5JeslykUSf8vqkmaEg?= =?us-ascii?Q?xRyCrO0ZhhJviEM2yqwbQwX3s4tohvfyfSr/F07wCASRFgjYZqycH75ilcH3?= =?us-ascii?Q?R3C+WcIMiY9Jaepa4016moEQ86mdI7+xQ9gtDhyr9SjDlgN8HlTPWXEV64ct?= =?us-ascii?Q?clUSu/yxRco2MiWtovSP5Waj4j+F8ZsSLKKg2kISK9xdK9gPh4ygey2DQXbG?= =?us-ascii?Q?ZUK6Cd73i07U7+/6iiyy0hrd8rEweEmyl8j+5lmWlj0hkBkExJT10oGw8AwR?= =?us-ascii?Q?ChoeLoGvka7jKHAqYpJISa23y9DmM6kTbf0qCIpZBfvTnIuCQkZL1FIwEEiA?= =?us-ascii?Q?8s84CH30JgsyauxcKmSkA6wOGvTKdOJ9o+BvneodcmfEFOu9X8F3ty/Dkdf/?= =?us-ascii?Q?kT3A8V9UrC3Ng5+OYIPOiFIshg42XU8Jt2XNduDi7181GVzBkzvtAdrDeQL1?= =?us-ascii?Q?RlVEyaLtNOptqvarsBYntAoZA0RkMtmAvjaoAim2QkBa5CMzcHWPCLHoiQly?= =?us-ascii?Q?bRMFCzj79oEEovsqJtQpmyGl/E/EQ/kw+n8rUOHYQDaksgIEk6Tl/vflrjzV?= =?us-ascii?Q?+1QBs7KlP4BbF6FIxgHVX+TlgV1J259qHeRheKaZzaWUwlvw4dUCcHCmdYn7?= =?us-ascii?Q?gEmvMBv2qENMIDAAGhBUYB93Z1+5wsDyQUF4vFIDOfOSCfsogwg9T+xqra9F?= =?us-ascii?Q?o/77rj2abZYhHhwo51zYluEQXCyKxI9/GvMg6Tb/s1uG95rGM0ORwMjEdTLx?= =?us-ascii?Q?AE2VRZ5MLBAc1B5KmnF5jomNJlWlvi2JQA8EJwPDJYcVMm6FakJyBgGk2VIl?= =?us-ascii?Q?ktMLWRu6Me9YarvBd4e0DFU6lgu9szD82f/t3cpXXGLMX9OsAsMe6Huk/Qlm?= =?us-ascii?Q?HgFxs2psEs/STFjYiaFZ3rFG0BLJI+IpX39bPCeMErsX1mTMPkGlTijPHjY6?= =?us-ascii?Q?KBTF4b4rpPmXdGdRzzvMcGy0unlni03cwnq9o55r31IOM9vWsqkNyfMPtup1?= =?us-ascii?Q?PJybe0U4F/tX0L/G3XHfJ/5sypY5JYi7GA0vHzYyt0ZqICpvlxTgEifA8v90?= =?us-ascii?Q?tk4n7qONEcu52JjMkRhFRkFTm47lA1e/iRI2Ls/9l2BLrNfNAyfcIR8rfmax?= =?us-ascii?Q?Rf/G85j//qLCQQIQ3Vwosa462BT3T632wN3DducLcQvu4iOHAsbpsdO6pgQR?= =?us-ascii?Q?hREaF46Y9UPQf/5ybmCgP0D7L1Fn6g9CPpsgn7TQ+z1kzfQtC9G0b9tNvFjh?= =?us-ascii?Q?0c8LdHLHqAmJdH7hjJ4w4NEVlFFq0QCT/XAlxGs9eyx8G9RerQ8A13tbL1Lh?= =?us-ascii?Q?BxxEPDfcrdkfOvpKwnipE7f33vEET26Zf2e8Awcn0F9F6MWzeOkeOdmQGG0U?= =?us-ascii?Q?KA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 3XtNjJDrUe7tvcI105c9Yhct0+ztAiCZzERT1pajPivlwYLj9GHqTNp9JEaq+7V5qkywp+TkBhKCsV+akDunCHSBAOfOKcqVuVR5LTYofIWuNQv3OhUsehixl2qsGtCkeUnkuYFHmQX/NHf8/ASLH1sLsbyrfsWzgai20f90opzGhiEd7GWoaiZqXITz6Ckkfusto9T8CnTOTeUkVBRtxcWuwDiSmL3rWg3CYrughVHxuZ8G3sP2D0MWeWxZPbaRduuaSku2rzNJr+aIxggwhnbivZMqH+YZGqy2rOyjp7DGZPLr3DECEQna+mfvU3mpxiTSVnciUfR1sKz8pwRgIgtcwkP7SnqXUubnmJZ/wzvl+VMnBWzkNoZpxz3lXYC2fKIIBxPA67rImfuY1ck1K9GVL6pWeiEa/A3VkvVRYAhJhnnqdVKaxEbQbP7z4NqMQZZJuMybBD/JozdH59UtHZZKTvLtbcM1+X0v8K46uocTSt1nzFxfKEwRPoAKpwjNL5Wn+mnNROrp/bx6KX+RbtG3Su+kDcv/UcfN83TR2k4V1DSUvEX2tzo5uajdebmmOKvouz0ByoFvl+8xvGs8Qs4+c98ZVTUAA1mQGSJcBz8= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 59914e14-92f1-4704-1049-08dd3f03e16c X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3374.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2025 18:53:26.2172 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L0keLWRcD/yPG9qDCJyNIPmrX2yOL2m0xWG4ck6O8UJLXU9ypDVMdO8M561lGxWnE7no4dbqZDK5Qv3wQrZbbwlOlKaZBnC+c1a9Sty2Xjo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA3PR10MB8017 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-27_09,2025-01-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 bulkscore=0 phishscore=0 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501270149 X-Proofpoint-GUID: Y9A2b9wE5vqOXWz0yvFkq0f1kAmTkZqu X-Proofpoint-ORIG-GUID: Y9A2b9wE5vqOXWz0yvFkq0f1kAmTkZqu X-Rspamd-Queue-Id: 6B35B100015 X-Stat-Signature: osgjj5pwsmb8pq4ky3aug8n5e9fxu5cp X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1738004015-186962 X-HE-Meta: U2FsdGVkX1/IWqAS6E9qz4BE7lZVr/FS6gpm54wogI91YZi8emkXs1fnJmLPK3Z37Y0hveEILFiurOOw1c7ngXKs6ochg4dcumS6ovAOPXYKIF+Cc3P2v/OM5mwkT7Z8IjiE6fEj+pKtUWK2MRGDY+3b8hFZj+HbyvarBbAByPMlYpLWJgGlgIriJi0JUXykNgJKNvUNqzupsO2h2FH3CWMgScc6vcBmkv1NVlszgOAM4ViiEbKyEqF5bb2xLQXY61V58QL6eZJoSB2M4SGB8tU/NUJtiu3lf04V+O7M1Y91Zsw0BAYsbOoLZsC+94p50EFUI8BpJjkFEek1l2+T6uOKpH/9VDlo0a/BjkikJrInUSIRTyu+AvrMIV663kWo22yvYuMZ6pu+Lwsd8699IOq/v6mGw1XC3rXrHJ54u4vzbrKgYu8UmJgzUlJQi4XQDHP0iA0y/JbmtybB+NJ0U//d2Sf7jGA960Ic0RzyFxRIuHwVsXDIPpNGclSWhKC9XUeEeONqyyOnRke6nVQUWRP9Oyx57r+d09VNROfkqXrLG0Z6sCxNmWWQI7KqF4koY9OrA6zWqMEZFPdj2nPOFo/EMHv6olQPiTplgMzyovVzcxVbWFVoYrqINA3Ab2nDDuzxQxEt8I5yrAtl7AooG0S+uP3i1qmskOuh68MXkxtzWOoH/11mdqiwTSYWX+fF9LjPvL8A9iKo51ffusOLhpPwPMcR2q97v3J5BX7Hneb5bqHg7ArAMPinUPrFHbnmJ9mvZQ2C2fqdzzXpJph5uYFShDlXrt4jQxDhrvz8KmyTu/A9TV1Wxv0+8F5muQSISavWE2ikiuH6I/K3XSvi36ycZK5wKKYDvM5uONRiSF12yojh00FThzN6DbynVGpXLqaU0+Bt/o9IR/pHWeHnInxt8S811+78Ms308XXo51eHq6t3BKSP1ePvGxV1mebUPKKsj97bvqhT4cfTAxH jr2CWaWy xAQynVjYOD+qj4v/7JjJ62EogTNBcgE5q1iIGkNzAzhUbPZeSbBUb6/DCuizKdLHsJXtB9brDMiEKbZowTXxWfCoD6Iy+6LtQvuykJA5dHYdlvHMm4zJEMlT3s7FmgZSvCC3Qc9Bce5NfjwK+qJNS5YXrOI7q7xNVhQNLwSnXiXtM3d4Y9t2eG5+xrenpRDhH6QQDmouygYgTUzvJ0pcZa0AL1+2CKq9Gmh9qHt0NsHsv/KaPZfkdnme4cViX9WovuHxPECMDoRNiZ47Dyr/ZBSVn0PXwEnZR5VcM5Z6ieTqQj9E7OD+WwV7O34Qu63rdYKDfDyRu9gugnWt2QEnkkzJ7V5IyMRt43jV+7nyLw3frXpjs34JrwiCtGmhc2z0NrmVmv5xoz1pPwoFuQbQ56rn979e+J4tq54Bt+JNj16zdmiwGiVg9rTPtBxGYaAewENVmLPXRTn8zf1K36+/OPsAQp8dFGFQ8h3sSfGeSLoDHKEG1pYgd+D1HmWRfstwLkRb1PqaXMe6cbRbXigz+fDCU/CCYX6mtacjyLR2sSlLwIzVpsfHvX1sD7zoHjFYYAX54UykHIvskq9hm4yT5HyNfJzsFcHpePfnRkXl5vOIGtcZJ3Swks5H0+7GG5RwhA1YpV72kGa8y69o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: +cc some commit signers due to total lack of response here. Hi Alexander/anybody at intel/elsewhere who can look at this. These fields are deprecated and will soon be non-optionally removed, it would be good to confirm this works on actual hardware before this change goes in. So this patch is probably more urgent than you think. If there is a problem with maintainership in this area, MAINTAINERS should be updated accordingly so I know who to contact. Thanks. On Mon, Jan 06, 2025 at 11:06:56AM +0000, Lorenzo Stoakes wrote: > Hi Alexander, > > Happy New Year! I realise it's been the holidays recently, but Wondering if > you'd had a chance to look at this? > > Thanks, Lorenzo > > On Tue, Dec 03, 2024 at 08:00:01AM +0000, Lorenzo Stoakes wrote: > > The struct page->mapping, index fields are deprecated and soon to be only > > available as part of a folio. > > > > It is likely the intel_th code which sets page->mapping, index is was > > implemented out of concern that some aspect of the page fault logic may > > encounter unexpected problems should they not. > > > > However, the appropriate interface for inserting kernel-allocated memory is > > vm_insert_page() in a VM_MIXEDMAP. By using the helper function > > vmf_insert_mixed() we can do this with minimal churn in the existing fault > > handler. > > > > By doing so, we bypass the remainder of the faulting logic. The pages are > > still pinned so there is no possibility of anything unexpected being done > > with the pages once established. > > > > It would also be reasonable to pre-map everything on fault, however to > > minimise churn we retain the fault handler. > > > > We also eliminate all code which clears page->mapping on teardown as this > > has now become unnecessary. > > > > The MSU code relies on faulting to function correctly, so is by definition > > dependent on CONFIG_MMU. We avoid spurious reports about compilation > > failure for unsupported platforms by making this requirement explicit in > > Kconfig as part of this change too. > > > > Signed-off-by: Lorenzo Stoakes > > --- > > > > v2: > > * Make the MSU driver dependent on CONFIG_MMU to avoid spurious compilation > > failure reports. > > > > v1: > > https://lore.kernel.org/all/20241202122127.51313-1-lorenzo.stoakes@oracle.com/ > > > > drivers/hwtracing/intel_th/Kconfig | 1 + > > drivers/hwtracing/intel_th/msu.c | 31 +++++++----------------------- > > 2 files changed, 8 insertions(+), 24 deletions(-) > > > > diff --git a/drivers/hwtracing/intel_th/Kconfig b/drivers/hwtracing/intel_th/Kconfig > > index 4b6359326ede..4f7d2b6d79e2 100644 > > --- a/drivers/hwtracing/intel_th/Kconfig > > +++ b/drivers/hwtracing/intel_th/Kconfig > > @@ -60,6 +60,7 @@ config INTEL_TH_STH > > > > config INTEL_TH_MSU > > tristate "Intel(R) Trace Hub Memory Storage Unit" > > + depends on MMU > > help > > Memory Storage Unit (MSU) trace output device enables > > storing STP traces to system memory. It supports single > > diff --git a/drivers/hwtracing/intel_th/msu.c b/drivers/hwtracing/intel_th/msu.c > > index 66123d684ac9..93b65a9731d7 100644 > > --- a/drivers/hwtracing/intel_th/msu.c > > +++ b/drivers/hwtracing/intel_th/msu.c > > @@ -19,6 +19,7 @@ > > #include > > #include > > #include > > +#include > > > > #ifdef CONFIG_X86 > > #include > > @@ -967,7 +968,6 @@ static void msc_buffer_contig_free(struct msc *msc) > > for (off = 0; off < msc->nr_pages << PAGE_SHIFT; off += PAGE_SIZE) { > > struct page *page = virt_to_page(msc->base + off); > > > > - page->mapping = NULL; > > __free_page(page); > > } > > > > @@ -1149,9 +1149,6 @@ static void __msc_buffer_win_free(struct msc *msc, struct msc_window *win) > > int i; > > > > for_each_sg(win->sgt->sgl, sg, win->nr_segs, i) { > > - struct page *page = msc_sg_page(sg); > > - > > - page->mapping = NULL; > > dma_free_coherent(msc_dev(win->msc)->parent->parent, PAGE_SIZE, > > sg_virt(sg), sg_dma_address(sg)); > > } > > @@ -1592,22 +1589,10 @@ static void msc_mmap_close(struct vm_area_struct *vma) > > { > > struct msc_iter *iter = vma->vm_file->private_data; > > struct msc *msc = iter->msc; > > - unsigned long pg; > > > > if (!atomic_dec_and_mutex_lock(&msc->mmap_count, &msc->buf_mutex)) > > return; > > > > - /* drop page _refcounts */ > > - for (pg = 0; pg < msc->nr_pages; pg++) { > > - struct page *page = msc_buffer_get_page(msc, pg); > > - > > - if (WARN_ON_ONCE(!page)) > > - continue; > > - > > - if (page->mapping) > > - page->mapping = NULL; > > - } > > - > > /* last mapping -- drop user_count */ > > atomic_dec(&msc->user_count); > > mutex_unlock(&msc->buf_mutex); > > @@ -1617,16 +1602,14 @@ static vm_fault_t msc_mmap_fault(struct vm_fault *vmf) > > { > > struct msc_iter *iter = vmf->vma->vm_file->private_data; > > struct msc *msc = iter->msc; > > + struct page *page; > > > > - vmf->page = msc_buffer_get_page(msc, vmf->pgoff); > > - if (!vmf->page) > > + page = msc_buffer_get_page(msc, vmf->pgoff); > > + if (!page) > > return VM_FAULT_SIGBUS; > > > > - get_page(vmf->page); > > - vmf->page->mapping = vmf->vma->vm_file->f_mapping; > > - vmf->page->index = vmf->pgoff; > > - > > - return 0; > > + get_page(page); > > + return vmf_insert_mixed(vmf->vma, vmf->address, page_to_pfn_t(page)); > > } > > > > static const struct vm_operations_struct msc_mmap_ops = { > > @@ -1667,7 +1650,7 @@ static int intel_th_msc_mmap(struct file *file, struct vm_area_struct *vma) > > atomic_dec(&msc->user_count); > > > > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > > - vm_flags_set(vma, VM_DONTEXPAND | VM_DONTCOPY); > > + vm_flags_set(vma, VM_DONTEXPAND | VM_DONTCOPY | VM_MIXEDMAP); > > vma->vm_ops = &msc_mmap_ops; > > return ret; > > } > > -- > > 2.47.1