From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 628E0C5B543 for ; Tue, 10 Jun 2025 14:55:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE2356B007B; Tue, 10 Jun 2025 10:55:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E64B36B0089; Tue, 10 Jun 2025 10:55:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2CE76B008A; Tue, 10 Jun 2025 10:55:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AF08E6B007B for ; Tue, 10 Jun 2025 10:55:41 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2F1C659E96 for ; Tue, 10 Jun 2025 14:55:41 +0000 (UTC) X-FDA: 83539790082.11.24EC881 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by imf01.hostedemail.com (Postfix) with ESMTP id E7DA04000A for ; Tue, 10 Jun 2025 14:55:38 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ShhzWZ5b; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749567339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MoiFKTSdyE7IJGcKTaIkGUWkCRoNt+8NVqwQ8tImNno=; b=GKRHWbmRkpUFwzJr0PRKat0yrSGSRNdtKu/3gBrrAQTAX1Q9KkPaFMUBI0rj4OW1ztWTtI 8S6eWESi9gkL3IJZjLBSG+kgVA+czo0iwJidqK080/oDiNCjPMLjRYQn12LJaI7/nU+emx alnra5mUndG3G6VLmwmMMkGwgIGqHZ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749567339; a=rsa-sha256; cv=none; b=UmPhwP5Nk43WxHt4OpzXEZlC3phihwpQMQpVXAli96limoXLCVR482UPsx7H7RRBasIzuf 3T2CWa4SyLmDMBY7PaBKFgIOq2Nb/XrZ5ueTJ94fE0AeMcfN/K0zWtT9o+i0vBsUIR4wFA sB42XTERzUGyDLF1IVYocAbbjdQBfB8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ShhzWZ5b; spf=pass (imf01.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.21 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749567339; x=1781103339; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Eh+iheJKwBVfOPh/9XPVIBHnKO/A10PgqY0AzI/9EZY=; b=ShhzWZ5bQrPToDJWfZgjeyGqwiKNsvJk1yzMoD14yD3wJesUPzoWg30z z0g19b34E/iVpgMG+KG96/w2ee+gK5iSSETG0Fxv6Do9StXv28X2/3MiL cOEvpVkj0FKEAXGcpizpzMNO3X4uriWUecgnCXi4VVK8mahbft957u2/V rvZZm1tR0D/YQmJ+XmsJal8e42Xor3O47rYibheCe8ZEHW44SGCit8RgL S1V3EjM2VtOmVLGyxEDdgWuj69bv27ibozlvieVO2Pjzold7Xr3mOIDUK KDLNDG4TLWehJDIGqpBQld8koFhn7Z3gLLYFqxYVwJXHYz3O4V1CAejUz A==; X-CSE-ConnectionGUID: 5P+66t7tSme4UR5l4wfk3Q== X-CSE-MsgGUID: k7NvgXr3TcC27dKqd8bnfw== X-IronPort-AV: E=McAfee;i="6800,10657,11460"; a="51536937" X-IronPort-AV: E=Sophos;i="6.16,225,1744095600"; d="scan'208";a="51536937" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2025 07:55:37 -0700 X-CSE-ConnectionGUID: N7xJj846RwiiZjpFXhzCgQ== X-CSE-MsgGUID: riD1qMt0RnusQVNq59w/yQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,225,1744095600"; d="scan'208";a="146839722" Received: from cmdeoliv-mobl4.amr.corp.intel.com (HELO [10.125.111.131]) ([10.125.111.131]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2025 07:55:37 -0700 Message-ID: <22cd0fa8-d14d-4d37-a6a1-5e6827d6182b@intel.com> Date: Tue, 10 Jun 2025 07:55:36 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*_init() To: Em Sharnoff , linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E7DA04000A X-Stat-Signature: hjkiirq3q36k6gqfkze3fmdsucsef9xe X-HE-Tag: 1749567338-744450 X-HE-Meta: U2FsdGVkX1/MLy3vFsJGGIYx6Hu6rwE6meGLC4GZ1tveOnWbb5UqIwDk517O4lsIQrKID7w9bRjzMtcgsYuARIhi6KaJl1CkumwXOd2BslnioMd0q4JCq3bIyg/mMaFJOxmISC4erVZZHTIXR59zCn3SgCrVYWk+Sjxi/JzNrwJFi1CEZ3nUd/Ntcl8GlnQJlZvImW9jVnkITw3JdTWxC4GKxDMqhqhVMcZWJq9LnwEW/0erD/P8b8Vl36zL+CBpT/HUUTarFyPVguSYUbL0H+FVFZcmNJIYttndYLF1FNX+tTWn8SrEUXGz+ozXMV4wo9AA3qgbvCNg9zaz1x6fEkXOfMCUtADgyYcIHeYBMaLHjFG3EoP7+fsinUgG0EA9AeSeV6Wr/trkQBW9fdtvNHN3zBGxJ2knq8S4AzDiLzfXjjVaPlUQEdp5ILKQ6kvc+Sv2I+CvzG70xHjSkNKpplkuYWswM8aB2jRBDb7XzHEwQpDbZbVu1u1zC0KLYvFErlzI/F9ftw+gCOUcfKcZG3bd3Fcyt76ZNWcAb4MI7/Dl/54bxl0XjOdYVHMd5QVKw3Nfs5HdvwD42zMcIC7s4p2A0y31Kz9wgWbN5EWJNa7HOuU8+WVv3pqT0nclU1hcmav0My0yHU3Vx24xJeXFpF1zuKQ1Ned7Rs/hVxSfnAOCk+l77qzygH+IEQI+FqBRJ7KNWOEfcgfue3nWoL6NBPxULGCk9SF212y/Beb7Z6KWEX/YsIpUOgEsM1hkDfejH7ArAXsijIwsK5mhn6rEzoNSTnGSQz72uFaldEAG6GwPDbi1lRcwf/fVOZLGskdHRo/V1SDz6yFk4SADIy5v1gii4EOZffcYDe5FHeBOLBObXBJUazp/FUngdK9DAHxYG6xj0gAjTdBSRXXGLZ2ADEOxarPsgMSvOHpIWpmqmHmdHVnpLKEObE4vnS4pyRXgmYrjy1gSrWwF3emv1Vq Hk9Fi90J pzV/xAbi2jodwD8a9Cy9QguO2GoIlOMh4lvh8eCWdEmAKw+SYTCheefeBQwyPnVvbEh/ZL/M7lSmouDF30ZhlgMY1FiCisiHaGxET+UTtYQJ3b2KOKr8sSbDKmt479FGgDkISscZCeM0m9oOLyzcFxxAym9homdZ1ZUzySlTo3MdVA5f6fBwNaNGeGC8mwwy9uuT5u57f3J6bB7+JPKqu2INXXwPRcYM7+OaTKBgnQ+Rq/cipfsszmQP3WD8qu5lxNda5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/10/25 03:16, Em Sharnoff wrote: > + if (!pmd) > + return (unsigned long)ERR_PTR(-ENOMEM); All of this casting isn't great to look at. Just about every line of code that this patch touches also introduces has a cast. Could you please find a way to reduce the number of casts? > + /* > + * We might have IS_ERR(paddr_last) if allocation failed, but we should > + * still update pud before bailing, so that subsequent retries can pick > + * up on progress (here and in phys_pmd_init) without leaking pmd. > + */ Please write everything in imperative voice. No "we's", please. > - for (i = 0; i < nr_range; i++) > + for (i = 0; i < nr_range; i++) { > ret = kernel_physical_mapping_init(mr[i].start, mr[i].end, > mr[i].page_size_mask, > prot); > + if (IS_ERR((void *)ret)) > + return ret; > + } Are there any _actual_ users of 'paddr_last'? I see a lot of setting it and passing it around, but I _think_ this is the only place it actually gets used. Here, the fact that it's an address doesn't even matter.