From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E863EC61CE8 for ; Thu, 12 Jun 2025 16:56:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 340956B007B; Thu, 12 Jun 2025 12:56:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F1E46B0088; Thu, 12 Jun 2025 12:56:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E0A86B008C; Thu, 12 Jun 2025 12:56:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F2BEC6B007B for ; Thu, 12 Jun 2025 12:56:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 914F7C161B for ; Thu, 12 Jun 2025 16:56:40 +0000 (UTC) X-FDA: 83547352560.22.99711E0 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by imf22.hostedemail.com (Postfix) with ESMTP id D6BB9C0012 for ; Thu, 12 Jun 2025 16:56:37 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xi3CtTKH; spf=none (imf22.hostedemail.com: domain of marc.herbert@linux.intel.com has no SPF policy when checking 192.198.163.14) smtp.mailfrom=marc.herbert@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749747398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=h6UmW/997WEMd1RmXSxY3k3iloEzVql0s/HvGYSP9xs=; b=QwrSIZHC6eajHY7ZFwiXf4uAF/2SBc4PN14ZPpKYto/wP1imk1mJ03nMiGsEQsr2v6xGah EQ4jwiECjkSHOSL2O7cPZ5zq6DOCEyWgnl2RnZkOwwnrgqHFIfKXq5H1iud91FlOe2/20T I7TuYeWhPWnF7gt0mjPO2AgZk1A8IxA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749747398; a=rsa-sha256; cv=none; b=1VNm7XODe+vvDLXAYXECFV5ktFL8ywXug+pBHpZc2RADkQsaBfxqcmKxpbIqwvnuQ9U7Vh 5nvjM2WtVMW8QpcgFPLKPMutsI5djyHDxLLAPvTD0IzWdhMpNYlLDcHTddCMAtxyPJ62bx GC13oOFDd5AmiauXrLhyTLS7xicR7co= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Xi3CtTKH; spf=none (imf22.hostedemail.com: domain of marc.herbert@linux.intel.com has no SPF policy when checking 192.198.163.14) smtp.mailfrom=marc.herbert@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749747398; x=1781283398; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=8Ye67YnjttyTwFTBHI+RLSlHPDRdNz234kvp3fp5Y9M=; b=Xi3CtTKH7FWdG9bS3qOoPE6LI4rP63wnkK0IBxNFumk4GSawkm8V46P8 fSnDAW/m7xHQitHt4lHIZIUOpeSvUn7fmEuIkQ96k9E7ieKUvE1Fc5ENU 6Mp58spfagdYAR7Yr7oxJbe1pqaEGhIHjuvPZ5HAcpgwU4GE0M9KQNAjp Q6i1zDK/dWj2e4JzT3CFQDycsqI+9kkQcqy9kCz6Wpvw7qi+8NNS7x0BZ iJLeyfYnUZaji8en2/XZIo/K+02BONdx0nILT6ZcntZOFaDUT7q4dvRU0 mwkjnIWNjjor5sUOsnqWGb+y337so3uOfew5yESA3AWxXSSQWfE1zYmSP Q==; X-CSE-ConnectionGUID: 2oWC8dyWTx21zLjT5T8NaQ== X-CSE-MsgGUID: myhjyxWNQvOsIT2snhnFug== X-IronPort-AV: E=McAfee;i="6800,10657,11462"; a="52039763" X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="52039763" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2025 09:56:36 -0700 X-CSE-ConnectionGUID: IEi61bqhR3G9Riiy6tUyzw== X-CSE-MsgGUID: 3V8D+rDbRz6duGbQpO2V6Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,231,1744095600"; d="scan'208";a="152483191" Received: from dannysua-mobl.amr.corp.intel.com (HELO [10.125.98.185]) ([10.125.98.185]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2025 09:56:35 -0700 Message-ID: <22b3158d-565d-450b-809a-af302220bcf4@linux.intel.com> Date: Thu, 12 Jun 2025 09:56:27 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes To: David Hildenbrand , Dan Williams , Alistair Popple Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Oscar Salvador References: <20250611120654.545963-1-david@redhat.com> <684a5594eb21d_2491100de@dwillia2-xfh.jf.intel.com.notmuch> <990ce9cf-0e48-432c-a29f-0bd1704eede4@redhat.com> Content-Language: en-GB From: Marc Herbert In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: D6BB9C0012 X-Stat-Signature: sgm9c1kuuadbuoj4efw8hxy71gfx3nh9 X-Rspamd-Server: rspam04 X-HE-Tag: 1749747397-912578 X-HE-Meta: U2FsdGVkX19YMbwSRkHo7YtEXJ/tUVOO5CcDP7MyabpUEkwADYxwl6pabl0E4mJKI3Bjm4xfZeGRs5cbFUWfNm5xD3WXgOL+9WFxEXtHQeoLTqBkO2nc8KJwJH7YiytxcTSv3Ge/CO3XdpWSFhJ67l7itgyaafEzjnodwr9+izObogb3T4aTVO/bd9/XVyAXe+D2PRIQoUFVXRQ2mGLlAp5iIqtspdjU62m308SxSE5q3iacqmELWqCTfTVYYXuemwzx4NDmPSouAsLiMVi8suRT8tH7Of358KvsUTIvtlhgH+GMmsO4okxbwDeXA/J/thFl+2bBF25+I3njX+Q18gQCIN2fe4vTK9ApSTFcZKvUrSmLaLQb2QH+UVCjLZTuvgnlM5iXSwyYcQeDaqJJNMbjozk5aqdrwml1VFMtqB0dkAE4bi54JGgKlcDnGHeC6o5D1niy2LIASlfefZbaVNvMQwuu2qq7MUoIKzxc19BiYQRArr5DFo5O+4e/eAR5fNPSWMIDnihnA5hB4aKJBzqWVLLUfeWki1cVNllfL3q64esLSa+wCmSJPmnYn3duYPcLhoDct52rYW+msXgrDx70xF4o87r9QjjZztS0ey3vzIdIpnk5ajjo7vQVWxWf1b3OuIkqCaFV7bBLJXQ9HxRecpX5/u1r9wA/OMtDUlWyUnbbzVrCN3I6yzt5PHKA3foi4k58YmIHT+dokbCHvn6UhpLZTx8i2CYwePkOHOX5ESlTBd8WuqhmX4pnpcsikxSbPGPGLHzO+PYtNukh3V/6q4WPuq/HOkGz0VBvl5fEjLdxnVGvFX05Nm+U2BS26jX8gXR1522vjzl7U1FKYaKAeICNG1QVC07OaSOgSXf+EATHNDyGl0+9FdVG8mSsLS+HESFIp5UwyfUaGnSouV6Li2PSI6S4jk8vrP7uAjCNDtlaajc/yzJGAwnVLxD+kzhBIMouXnN6hLgOTWj 277J7xRh LMPoEQfXVseji5ddF1dz2N8yKPg/wUGqbv3/SysvojLVCYa+64k+NK9y6897rzgiiWpSS93hswUjFGoWDdj6wmtyJT0GuY6SSVq9jMG+rBnw4ZlNPWg3JmgRr7DYAkf+fObDDRKKo5DD3xVWfDfAC/RYSlL5NW4cNqz+inXs2eab5XQfdSKwD9iFKH9Hs/GNoWTkzgsZNq9idfgpzCiNo3iUqdxrJ1/OfZhItMHKfcEz3COlSsNRn68zWfS4speich0xT1caPG7MQlykymDUsGlqjMHIR3PQY6FaCMlhHFrMq1IU8y758uELPZg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >>>>> I spent too much time trying to get the ndctl tests mentioned by Dan >>>>> running (.config tweaks, memmap= setup, ... ), without getting them to >>>>> pass even without these patches. Some SKIP, some FAIL, some sometimes >>>>> suddenly SKIP on first invocation, ... instructions unclear or the tests >>>>> are shaky. This is how far I got: >>>> >>>> FWIW I had a similar experience, although I eventually got the FAIL cases below >>>> to pass. I forget exactly what I needed to tweak for that though :-/ >>> >>> Add Marc who has been working to clean the documentation up to solve the >>> reproducibility problem with standing up new environments to run these >>> tests. >> >> I was about to send some doc improvements myself, but I didn't manage to >> get the tests running in the first place ... even after trying hard :) >> >>> http://lore.kernel.org/20250521002640.1700283-1-marc.herbert@linux.intel.com >>> >> >> I think I have CONFIG_XFS_FS=m (instead of y) and CONFIG_DAX=y (instead >> of =m), and CONFIG_NFIT_SECURITY_DEBUG not set (instead of =y). >> >> Let me try with these settings adjusted. > > Yeah, no. Unfortunately doesn't make it work with my debug config. Maybe with the > defconfig as raised by Marc it would do ... maybe will try that later. After a lot of trial and error to get them right, these fragments have always worked for me: make defconfig ARCH=x86_64 ./scripts/kconfig/merge_config.sh .config ../run_qemu/.github/workflows/*.cfg Warning: there is a CONFIG_DRM=n in there to save a lot of compilation time. Nothing against DRM specifically; it's just the best "value" for a single line change :-) The run_qemu/.github/workflows/*.cfg fragments are mostly duplicated from ndctl.git/README.md - but unlike the latter, they're machine-readable and testable. The CXL fragment is actually tested in run_qemu's CI (CI = the only way not to bitrot). https://github.com/pmem/run_qemu/actions As I wrote in https://lore.kernel.org/linux-cxl/aed71134-1029-4b88-ab20-8dfa527a7438@linux.intel.com/ these fragments should ideally live in ndctl.git/, not in run_qemu.git/ (the latter could still add tweaks). Then ndctl.git/README.md could just refer to the testable fragments instead of inlining them. "Send patches" they say :-)