From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28395CDB47E for ; Thu, 19 Oct 2023 02:17:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DC5C80076; Wed, 18 Oct 2023 22:17:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58B3D80074; Wed, 18 Oct 2023 22:17:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B7480076; Wed, 18 Oct 2023 22:17:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 38FD580074 for ; Wed, 18 Oct 2023 22:17:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04BE3C101F for ; Thu, 19 Oct 2023 02:17:12 +0000 (UTC) X-FDA: 81360598746.22.A93BE06 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf21.hostedemail.com (Postfix) with ESMTP id 0A2311C000C for ; Thu, 19 Oct 2023 02:17:09 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697681831; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vLCe2Vt2H86xgiw6tuB5H3IxPuWQ4GmxK0pKW1rDGjA=; b=kRjilvMrCAEJ/BG0Zmg2RD56nF6v1yGKWp8CYD+nnpUoMuqcTt2dyCSRltz25YzIoa3Yrz xX7eTJbBJgOQWFDcH2PCKG9aWMIrMk9BnuGyCiUkUF+t/e4cBJw3JUxddrp0rQOseCprYw V27UaxQFOS4vOOLShlviYNF+SQ5GGao= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf21.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697681831; a=rsa-sha256; cv=none; b=fUUimChjGUMbArUth5cRk7TSmeU3vXKWvOCyV1h7PBDxuWLlRxigp9hqVUQ+kRoq23WIHe JwswUYuGUTdiUoVbWXsEfqgODuZid/3j2RSg09cCgLb3enZogk2IRYi+rsYyWaidzcrIvz rqO60oWzjW+0QeQkYQuSegPv7p+sy50= Received: from dggpemm100001.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S9rnt6YvbzvQ0V; Thu, 19 Oct 2023 10:12:18 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 19 Oct 2023 10:17:04 +0800 Message-ID: <22acc5a1-39a7-4a44-b468-429f1ca23b5c@huawei.com> Date: Thu, 19 Oct 2023 10:17:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/5] mm/khugepaged: Convert collapse_pte_mapped_thp() to use folios Content-Language: en-US To: Vishal Moola , CC: , , References: <20231018203213.50224-1-vishal.moola@gmail.com> <20231018203213.50224-6-vishal.moola@gmail.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0A2311C000C X-Stat-Signature: frcsnapgrrri3binnxzg3t3qttqhqesf X-HE-Tag: 1697681829-774752 X-HE-Meta: U2FsdGVkX19fHfpGsqsaoRG71dOQHs479lsxXsZ9yYJBrUv3U8rWzYBCH5LPrKMtGqsfOhNr3LBQmfwsa+QFQtt5RiwlSPpRutDaGhRfzuwdzOzgGnJKzMBsZ3mz7xy5j4QnBn4RU6XtMOznBo5nd1Tz3i6mvarerueaG8v3XmM2hVvAFQ+O7b7naCEU4mmvkUtvq5OuEJ5e1UoCGC28/4EPOtRiwFMNrshaFqtEFGP5lBwoGlreUAZgcCPggR5xOR3VXhPI0VnrRtZmsDuu0orl8SRxTSfHAkaK2vuVK6i5L9Prtmdzl8LGpOBjgBKiD+Z96O/+PwipUV4pDJX920DNEObPDQdBUpTAkNPRiU08C6QUAAD0TavhIlCsGE0734VOTEHd6l0MvQ/H6c6E6RPGQjnBrxzaUfqkKOzLtX73KEEX0co/nfhz+LhQLkN5WKtpCbCMWWSmuTaWVrisbCAxGCOlvJkHxyk6LrUd0ZhuyvM4F/AHAoCdaOlFvCJh5y6NYC3V2w3fcfmjwCHUGBZUx9KbtExujNGdQ/EEPMdc30tEAKd0phZR48sitijJPXZNUK2Xz8FLt7YdgX7OQhqcbxEX/629LcDtuyiTKf8DRxE3Jc7msZO2MgisH0UifilX53bvwi7jBu4TQ1LkYtMPo4wEzqlVYODRzmbXA3xblZk8wnuNSxSqRvnyTZdDSZOe0AIUGcA2BuTEZSJ6ABU9/4pEzpGgZo/7EVz7vD3lYLYyokG4UijEXeRztw6qvP0oLQmbOw6+CGA9Oce5QnlccwzX5etfomlsfaez6/eNJ+RMwxv93OGZXPzBgKJg6HHrzvwN+YmBGN0h7RDcrC0Ee60xmpwn1XwNGkbAe7HwOQGl78/lQtqg1Yglzb74d5a/iSr7E9tr0VzUCR/5knR2GIZv9zXAlOUpQ7PMiUodCXiNCz6jmkM3D5UNMy3rtEkNi7XeSsZzQF3II7J 75sROZGG QxmmodcoboSqPrkkgmD+5bvg8SvxSiBDI6crbsPKsxke65YHUD4i7+64DSHIFQM+2OrxJ1cmiUe6xjBnJbWXSibpR/55/Lb6gOCZlv62jbHnWg1YPchRbWflVE4O34bgY+oS9W4qIkyis4ygHLtG66T3w58FeYVvwFlfyla1qBX9/wYztDvwOciJ6bNhuo6hh6dKQv+Rbn2zfcb1PRXkwky4mJmbuMht3NFxgPdQy5jhyWMjcC9vqL/4m/s1GRn+sIZWXdT3slmoEAMq0gc3GzQ5Zk223udXbtcQUEY5OJtAfHUy5/oV0mNCmpOASaWg4qrfNZhfZVNMXxDZCrUmNXeZXGdE64rAo93ohsW6zNdfyUe+915Rvj64TBogizI5MbXZYPwTRYhYTtbRynTbWW+DaOw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/10/19 7:01, Vishal Moola wrote: > On Wed, Oct 18, 2023 at 01:32:13PM -0700, Vishal Moola (Oracle) wrote: >> This removes 2 calls to compound_head() and helps convert khugepaged to >> use folios throughout. >> >> Previously, if the address passed to collapse_pte_mapped_thp() >> corresponded to a tail page, the scan would fail immediately. Using >> filemap_lock_folio() we can get the corresponding folio back and try to >> operate on the folio instead. >> >> Signed-off-by: Vishal Moola (Oracle) > > Hi Andrew, I've attached a fix patch addressing the syzbot issue. > It can be squashed into this patch, syzbot tested it on v2 already as > well. Hi Vishal, only IS_ERR(folio) is enough since filemap_lock_folio won't return NULL.