From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2546AC83F2C for ; Sun, 3 Sep 2023 04:55:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 265A08D002B; Sun, 3 Sep 2023 00:55:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 214A48D0002; Sun, 3 Sep 2023 00:55:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD558D002B; Sun, 3 Sep 2023 00:55:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F1FCD8D0002 for ; Sun, 3 Sep 2023 00:55:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B9B24120358 for ; Sun, 3 Sep 2023 04:55:09 +0000 (UTC) X-FDA: 81194071938.30.27A9819 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf23.hostedemail.com (Postfix) with ESMTP id 15BAA14001C for ; Sun, 3 Sep 2023 04:55:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LgyvXg3j; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf23.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693716908; a=rsa-sha256; cv=none; b=ctc5Qwr3wYcefs8jgWK4WjEbb8l7Q1gTD8Gup6SCw+mPHxhA5ZMj6cZ0aNEoLUqL/Y+E+o jngmVsvWzc04/+4uWx6oXV1E8mIwJUFmqSOjUFawe8rNjq4CovGmVFAp5Karte/mHGB2Ic ejWLuHOxImD6vvbFlMV2dHHCywDWkzY= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=LgyvXg3j; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf23.hostedemail.com: domain of wuyun.abel@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=wuyun.abel@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693716908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v+U5CPjOKyPGHDpwnXP0B3NDICrZc2hSQHMD9gvWWzQ=; b=SOBh4Ez3UmXNkCJsz/Qx7exy4eDt58bvGUjA/ffEq+13eGUqbDi2eV+EyI8GISGal96RAX 5wNcHHEpTsYg9pAGtyAjPcn5969Z9y7Mur4P60CAOMWPHk7oop3b10ZaGrqPbER7AHbHY1 gcWvYj6cnRHwPY2YPG1bjTq7QmKhGnw= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1c336f3f449so16405ad.3 for ; Sat, 02 Sep 2023 21:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1693716904; x=1694321704; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v+U5CPjOKyPGHDpwnXP0B3NDICrZc2hSQHMD9gvWWzQ=; b=LgyvXg3jtskqYhbDJdp3v8VQqMnoRV3pvEpBTxdPHMAl0DVH1zXRcVj5tQq52wA0jm KFaHySriUAMFqGCVltcGFjPQICd17OenNgu29WEI2AFTv6KGdonNF3WlXJ1G3hBEPcGa dT84JqX0fJcet29wI+SHUI21sPAu4mfRtVVw7R3+aQtqbQ2mWHD0jdRH/LMuxfPPIJGi grXCwnb9LU4OYlLy0euWGI3sxfnLspxE+iiA2jWGtbHMp/oCnJeYaP/M96W5OTiUQ+2q ta54XF5+wTc4fSx39KI1ljywq/AS+Ope1fCXuEHH8SH1DaNLlMNeSW9Phjqa9aqI/4aW 5Wkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693716904; x=1694321704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v+U5CPjOKyPGHDpwnXP0B3NDICrZc2hSQHMD9gvWWzQ=; b=DZ4wpRj3nNE4Hwzx65BqPl0G5DUhZZR4bt4esAQVSaZLi6t/XTFFssGt+X1QNaVO/1 QLpZeofOuz068W+J72fSDhoDqBagJpYqlgw3sBoY1GlT53+DPi6HiItBHj9+5HBMUTRh ypd26y1DQNSW7nbridL1SpbnVtBykfldCHGIWsiRqnunLGYVV7c212EnKKXLOTfaLohz BrOKQoyKQlfXgs8f6meg6v8qR1GIR8oMcHytuc6D2C0rxkBAMfK/TupKUU3jXB26MW30 p+kqRd6/VYQUkrILa+ZhzH1fgjDbeo0t80j9/el+pLwzbISO8BJIYAylL5p+Q2k2Oqf/ rTfw== X-Gm-Message-State: AOJu0YwYx7vx5E0ODdK5wKRyJfg/st2lzyya/65DuJpLPa44BAL5cSf3 uBszh2s9Q6H/wdpHJVjb91qmXQ== X-Google-Smtp-Source: AGHT+IEZm84G9mzAoT4L/Z2t61RZFgqR47NnzrcVfwzvXzIuo/vipgN26tmwI1A7WWb/kkbrm2Z/rg== X-Received: by 2002:a17:902:ef93:b0:1c1:dbd6:9bf6 with SMTP id iz19-20020a170902ef9300b001c1dbd69bf6mr5878849plb.41.1693716904671; Sat, 02 Sep 2023 21:55:04 -0700 (PDT) Received: from [10.254.83.51] ([139.177.225.230]) by smtp.gmail.com with ESMTPSA id x2-20020a170902ea8200b001bc2831e1a9sm5301651plb.90.2023.09.02.21.54.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Sep 2023 21:55:04 -0700 (PDT) Message-ID: <229c6f8d-b89b-1b85-8408-089c4cdf32a9@bytedance.com> Date: Sun, 3 Sep 2023 12:54:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: Re: [RFC PATCH net-next 3/3] sock: Throttle pressure-aware sockets under pressure To: Simon Horman Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Morton , Shakeel Butt , Roman Gushchin , Michal Hocko , Johannes Weiner , Yosry Ahmed , Yu Zhao , "Matthew Wilcox (Oracle)" , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Breno Leitao , Alexander Mikhalitsyn , David Howells , Jason Xing , open list , "open list:NETWORKING [GENERAL]" , "open list:MEMORY MANAGEMENT" References: <20230901062141.51972-1-wuyun.abel@bytedance.com> <20230901062141.51972-4-wuyun.abel@bytedance.com> <20230901135932.GH140739@kernel.org> Content-Language: en-US From: Abel Wu In-Reply-To: <20230901135932.GH140739@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 15BAA14001C X-Stat-Signature: 8ngxrt8eiooe4b9qw4p1h1jh4gaxnpfh X-HE-Tag: 1693716905-470519 X-HE-Meta: U2FsdGVkX19jlXVrgGxhsIZBXuBnrUKGIYkPx7//hB925JDhqhKBD+ipvNmRGO5Vp6rFS5alVEiOCH2msNqFWmStx8a1HCaiGRW+u6anhXLMIOJE5rwCNTDeceX+YuqoBDi6ryF2RnPRsjelyMtCtQAzQC9N9olJEKFxlVZZlNAhSDjQtgAmoLeHHQlEaSWDwggGChSlgitcj4O26XYWL5ITRga5RbyMnxs4ifWiwA2/eFILVxK/iUAl2AzCgdM0ewRpMgaSrcNP9oagr4PKamvpDOcCDwfLJ90v9g6TIXH/j5i3bxonfSc3I32D01e6CBTrIuTyqS86SfIf4kKp3QdxPO+oNis4u1F8WDR0NVL95uX+Hc4UZQyF4jwZnddQy/QwFXsG/ISUnA+MBDA2nKjQdPSyKIKkhUePXAR+1DQ/VuSFk98sOVt47qz4/0iCWNmqSU0vbBWHOkd/UYiMuPB5hEBBY41ZTUSDv/JNwQzxafHyxLNJWMA8FR7+JbRvQ2ONHW1gJV+fRpJeFZ1pbU53Q8cdoMBwKEZyH2s0W+tkYFyfzJ5W2/Gqs1ECSNVm3S+jCZIBNIeH2iF6Snsc+w3iWTuAc6awLEttYgSA/svVjSPX9CrGv0N1aicQG/Nhn1vdSN4xV3iTGA4uDtrJkUbjOhSVKZ+SQAqjm2IKQHx+sEWaQ0pPELlr55wGNuSr+seH2hdy8iHEB42dD3tcRdOgMfteFSaqch5kqDZX0JNzIKIFs31r8o5FexgWQoXX4Gsl0rmWY0a99ORqhUPOLyQBRkJV1p27unsaD1k1i5+4NkB+wUpWcsU7zxaSI41gU5E3lFWiiiiMgW3bIUYmQ8C7IDGyFVZ9/tX5UYCL32iBCJVAxMpxGjZppvFQM4lNmTluXY6AOBvr7hI+0ZX3qjh7CM3hN8SoCiAFgxeDh3dyisiPS3g5BM4qooWqgaq6bpKHVVBVwRQHgC4Azdb qzz9vB3b k0gX6VmUcY294Ne2lo0yk0e3hBRDPz4cg95Ai5IRB7T8j9wlbiehA9ieQAsJKH/1KbS+2WeMDMHCay+tGabnaCkoTqD0ERHHB18LHoYEBxLGnCYDrz7o+5++QrzBJF/t8KJuXee4ujDcpVp7JsxsPjP0bRcG5j9Vc5OOd4iQpcoujdy0Df5l0eug4ySNZ5CHdXWYtCc37ZpcwQ5ow1n2KZWG1kmgL/zE9AuKL2Gba70YjnK/ntj650c0sI02YyqvhgpLfXqVq+S751fR2EUOlybib0mPKh5vyr5lFdOw3SpE7NYadUWoA0cZ/9/eRQh8kj+nllIGeQZHzgCkaIa9PILxh3GhwTqkwqgzpbIk2SW5g/NOh26IZMhnz5sPKHhFubmuvcMmjr2wgJKJUFaDVkdesVTLIBn7j8HB4yoYMlfcxWpjA49GGXtUIAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Simon, thanks for reviewing! On 9/1/23 9:59 PM, Simon Horman wrote: > On Fri, Sep 01, 2023 at 02:21:28PM +0800, Abel Wu wrote: >> @@ -3087,8 +3100,20 @@ int __sk_mem_raise_allocated(struct sock *sk, int size, int amt, int kind) >> if (sk_has_memory_pressure(sk)) { >> u64 alloc; >> >> - if (!sk_under_memory_pressure(sk)) >> + /* Be more conservative if the socket's memcg (or its >> + * parents) is under reclaim pressure, try to possibly >> + * avoid further memstall. >> + */ >> + if (under_memcg_pressure) >> + goto suppress_allocation; >> + >> + if (!sk_under_global_memory_pressure(sk)) >> return 1; >> + >> + /* Trying to be fair among all the sockets of same >> + * protocal under global memory pressure, by allowing > > nit: checkpatch.pl --codespell says, protocal -> protocol Will fix in next version. Thanks, Abel > >> + * the ones that under average usage to raise. >> + */ >> alloc = sk_sockets_allocated_read_positive(sk); >> if (sk_prot_mem_limits(sk, 2) > alloc * >> sk_mem_pages(sk->sk_wmem_queued + >> -- >> 2.37.3 >> >>