From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB35FC25B78 for ; Tue, 28 May 2024 06:57:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76A536B0083; Tue, 28 May 2024 02:57:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71BB96B0088; Tue, 28 May 2024 02:57:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E2DE6B0089; Tue, 28 May 2024 02:57:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3D5776B0083 for ; Tue, 28 May 2024 02:57:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E8E341A1663 for ; Tue, 28 May 2024 06:57:07 +0000 (UTC) X-FDA: 82166897694.18.E6D74BB Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 481D7160011 for ; Tue, 28 May 2024 06:57:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of amitdaniel.kachhap@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=amitdaniel.kachhap@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716879426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5q09fyMM7+1VXHhckp9sjDw9WndHmEOCSOqKY09XDMM=; b=GnmpwNY6gFrlFNKoR/RkFejuyjeD3raXihRyyGR+Xq5uvhv6Vp9vnX2k79WFWQ/tWlmVXa 9M96eKL3G4a9lekpBIBRhZQyMjFUpcr7GCNdl23PjBWavTr4z5ZncKAwkSubNpAwxL92ap 3xDT6XuDnQS1/a95aGpz3Ohubw0jK44= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716879426; a=rsa-sha256; cv=none; b=zo3ajQEgt7oXCyu/kpsLd7Qa14ypgSaqgXmkRPeRcL7sTdigsFsWAGH2r0fR0Ul17g2CJ6 sAcbomdBijgC8E/pc/iupoNU3fWHCh3O0kCL7NJtlXmfwImrxJNQMSll40DeAhIwxTtiNL /m7F0WKcu6ge4EVqXjjYWeeAYSskm1I= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of amitdaniel.kachhap@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=amitdaniel.kachhap@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B57FF150C; Mon, 27 May 2024 23:57:29 -0700 (PDT) Received: from [10.162.40.16] (a077841.arm.com [10.162.40.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5B67F3F792; Mon, 27 May 2024 23:56:57 -0700 (PDT) Message-ID: <229bd367-466e-4bf9-9627-24d2d0821ff4@arm.com> Date: Tue, 28 May 2024 12:26:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Amit Daniel Kachhap Subject: Re: [PATCH v4 18/29] arm64: add POE signal support To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, bp@alien8.de, broonie@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, szabolcs.nagy@arm.com, tglx@linutronix.de, will@kernel.org, x86@kernel.org, kvmarm@lists.linux.dev References: <20240503130147.1154804-1-joey.gouly@arm.com> <20240503130147.1154804-19-joey.gouly@arm.com> Content-Language: en-US In-Reply-To: <20240503130147.1154804-19-joey.gouly@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 5h1esggaxgz4r4da3tfwfx1zbuowkq61 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 481D7160011 X-HE-Tag: 1716879426-839495 X-HE-Meta: U2FsdGVkX18j8uFmIH5MlX1qmpW6009SvpHVwp2idHF2gkTAPPAkq0vODu20I91ecy5tNOUKAcxDA19UK3RpcuAKLjIuTBPpqMEK5EJj3l+4QsIdQWUxe9YCeXz2tx8e5KHmQhz8jB0UPex+am88aZCK318FvgLEalDst3a3VKhjhTw5x7q4/8n+3L5HswnbMG/xe4kRj+2FoJTrCANbcOR7G38m20TotEsqM9fgvkQh+ntwtDXwXm3UCxf9v6bOQ+XBzxe5TKcqs2c08VHqaLLIl1GrEF/FfDccmXaEeSl8oJIQgQkPQeWZj4jxZQmC3rxHwm2+A1jEeRpXQlTdEqyEf5ANQUX18kBiIjiOX+ED188b0ZOkijYjZyDLRqATcfph4YgcmgVdpmxc1im3gZC8PF86mqnrCv6JcqMDaejEGPN+O4CilQXmohvy96pqPLUH29fLkT951wB72k1F4J6BmH7rER6CJbM6Oi46byY3qljiX1S03VPFSsPtpVl/bAxIi6RoCGYTSW0YZLRoe6/DJj2AaA+Rjj229rx+F4G+FR82ZhNm3GXNYLRETbYBKmDT6/b4lKlMavTdodkgTtwyVIxjRE4hrJs+steGAAMlSWuEd9vaFpUViwmfu6yKdZFFcuhCFCgirM8HAip3SkAvlIl1q84MNu5gkV1vUTXytq6R07JF0AgsaG5s5mbYOgifPJM3Gv/oHq1LtYL7SSfyEULw+jd+iMTkKQ7OaH5BIwkyHuh8wgvYvlOGupM9D6g5HT8o8hjR5sIhJkBoInlEVp4bZMBtzibcSGfSK40YxI/2A7qXv8l4dWGqeTatbFPTMM8ktPcSkgm+r//OyCReVJ+XEBrkvyV3Y5XlU5QkdYrnzfYr6zrXUiszYAJ1te25qdPSSMhZW0DHrPuxnbmVrA8Fx955NEJuXoEtJIwazNPnql3oH4e1gGW1FehzZqS1ZZqGY1ad5wBNwKj bB18yzDd 2h9A3mGxStDV17iZs0LnvrPP4U1sQHv2sgEZpPIYvb9Xpk4ZkcE9kYxSXD19Ic+6KlwtwyOx0ySg9VJcTMPWRFhPZbzLQIgfBMH0gmn8uKo2OstJSt673dKcoEDfVlcJ0apq3z9PLRO6Wq7cjlJ8zgVfWJF2l/Aal11Rmf6DC6Vh14/nLECPiAKA1yRgDFwhQot4TUb3e9bn5Z/5q8mgWHLhlWkw0V6Xut+702qeD15BZ4GoW97RLyszMmWLUFDsOct0dv9A1QLaiySU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/3/24 18:31, Joey Gouly wrote: > Add PKEY support to signals, by saving and restoring POR_EL0 from the stackframe. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Reviewed-by: Mark Brown > Acked-by: Szabolcs Nagy > --- > arch/arm64/include/uapi/asm/sigcontext.h | 7 ++++ > arch/arm64/kernel/signal.c | 52 ++++++++++++++++++++++++ > 2 files changed, 59 insertions(+) > > diff --git a/arch/arm64/include/uapi/asm/sigcontext.h b/arch/arm64/include/uapi/asm/sigcontext.h > index 8a45b7a411e0..e4cba8a6c9a2 100644 > --- a/arch/arm64/include/uapi/asm/sigcontext.h > +++ b/arch/arm64/include/uapi/asm/sigcontext.h > @@ -98,6 +98,13 @@ struct esr_context { > __u64 esr; > }; > > +#define POE_MAGIC 0x504f4530 > + > +struct poe_context { > + struct _aarch64_ctx head; > + __u64 por_el0; > +}; There is a comment section in the beginning which mentions the size of the context frame structure and subsequent reduction in the reserved range. So this new context description can be added there. Although looks like it is broken for za, zt and fpmr context. > + > /* > * extra_context: describes extra space in the signal frame for > * additional structures that don't fit in sigcontext.__reserved[]. > diff --git a/arch/arm64/kernel/signal.c b/arch/arm64/kernel/signal.c > index 4a77f4976e11..077436a8bc10 100644 > --- a/arch/arm64/kernel/signal.c > +++ b/arch/arm64/kernel/signal.c > @@ -63,6 +63,7 @@ struct rt_sigframe_user_layout { > unsigned long fpmr_offset; > unsigned long extra_offset; > unsigned long end_offset; > + unsigned long poe_offset; For consistency this can be added after fpmr_offset. Thanks, Amit > }; > > #define BASE_SIGFRAME_SIZE round_up(sizeof(struct rt_sigframe), 16) > @@ -185,6 +186,8 @@ struct user_ctxs { > u32 zt_size; > struct fpmr_context __user *fpmr; > u32 fpmr_size; > + struct poe_context __user *poe;