From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E38EC25B0E for ; Sun, 14 Aug 2022 16:30:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B179C6B0073; Sun, 14 Aug 2022 12:30:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC85B6B0074; Sun, 14 Aug 2022 12:30:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98F3D8D0001; Sun, 14 Aug 2022 12:30:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 870016B0073 for ; Sun, 14 Aug 2022 12:30:45 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 56554A0685 for ; Sun, 14 Aug 2022 16:30:45 +0000 (UTC) X-FDA: 79798736850.17.F7F95F3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 61B051C00A4 for ; Sun, 14 Aug 2022 16:30:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660494643; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7OqIGNvFWmwJKsWdnZAcHQuajnrJ8LLtzZZWISo0x+A=; b=IewzpnhsEWIFVFNIXc7kseJZddxtMhbXSlfXOVOS2pUpYwcPUwFwHkQFruNdRLIDTlCYhE 2aaWTAd1RrlFaGbqUpCpfUGBYhsWsK8uKKftnaGg6gT6lhJrOdKaiTJ0OZepnDiQqX3DCN nO49vYBSVsPeVz2OvpVJtgApdmreONM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-434-2mqlv-efOcSIkLGPciZJiw-1; Sun, 14 Aug 2022 12:30:42 -0400 X-MC-Unique: 2mqlv-efOcSIkLGPciZJiw-1 Received: by mail-wm1-f70.google.com with SMTP id b4-20020a05600c4e0400b003a5a96f1756so7471479wmq.0 for ; Sun, 14 Aug 2022 09:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=7OqIGNvFWmwJKsWdnZAcHQuajnrJ8LLtzZZWISo0x+A=; b=kzETkTcybmPrPIzs5k0e2yXHlrNV+KFywLy8Jo7HOB8xfzUXW1urkLNzofPVJAWwta x7l3dsq22ih8Hi+xZF7bufV3xIdvskKd2h2tSwM9+adsiA9WMyTRNOn/ayqtSA3v2NNz b1qrUXgULev9gFBbc/J3qXO5RYR7RXqq4j49syMbOhJ9C+wkH4QGbN77z4gMF4O/OEB5 VZKjnxvhSgaIopDMH5tY6zDDi9mHu732caCnGXuEQEuUqBWJMr+avyPhUKvtp610S93s j/DufLx+WlsVEeL8cBqRnQvd4SM8M3DLs1qS6PQSBzW7Ng6Gge3zoU2aTG4/oSIDoltH JZfA== X-Gm-Message-State: ACgBeo1AhKWWwzWCXhyZafVwc9sp2Tg/wk0rTOmo6rtr2r5vo4JY45rc i3hmyGp32EdsG+YDFVaZdPhUGFayBbTKa88eBhD81e1qc50ZOcYzDEY1witsNYgTjCaStfoHQ7P y6U5aK6jh0Fw= X-Received: by 2002:a05:600c:2cc5:b0:3a5:4fae:1288 with SMTP id l5-20020a05600c2cc500b003a54fae1288mr14405203wmc.79.1660494641166; Sun, 14 Aug 2022 09:30:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR4zbFVBaiyOjyDfdYEQM8eStx9y5x2XOUmTcHScJeTFx/pQEQl90jmcMKpcqRGyL/qMwFxAzQ== X-Received: by 2002:a05:600c:2cc5:b0:3a5:4fae:1288 with SMTP id l5-20020a05600c2cc500b003a54fae1288mr14405186wmc.79.1660494640879; Sun, 14 Aug 2022 09:30:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c72a:1e00:10cf:131b:999d:9b4a? (p200300cbc72a1e0010cf131b999d9b4a.dip0.t-ipconnect.de. [2003:cb:c72a:1e00:10cf:131b:999d:9b4a]) by smtp.gmail.com with ESMTPSA id h23-20020a05600c145700b003a529b7bc27sm6664588wmi.9.2022.08.14.09.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Aug 2022 09:30:40 -0700 (PDT) Message-ID: <2298704f-03f9-c932-e00e-4e6006a6dffa@redhat.com> Date: Sun, 14 Aug 2022 18:30:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/3] mm: revert handling Non-LRU pages returned by follow_page To: Haiyue Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, linmiaohe@huawei.com, ying.huang@intel.com, songmuchun@bytedance.com, naoya.horiguchi@linux.dev, alex.sierra@amd.com References: <20220812084921.409142-1-haiyue.wang@intel.com> <20220814140534.363348-1-haiyue.wang@intel.com> <20220814140534.363348-2-haiyue.wang@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220814140534.363348-2-haiyue.wang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660494645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7OqIGNvFWmwJKsWdnZAcHQuajnrJ8LLtzZZWISo0x+A=; b=m/x7tC4YNb80718BLd1bcYBC/rTaEoy6YAO88qyR/PCLjrBf74/jKXyclCYHA6LiF3nXxk Mq62FOcEvJtAjVYLIpkml1/jcsEcQJfRRAhVw1WH5hclQHC7OMEx1BIzrcCE/5XpBZRXQM zCfdAGY3OY2bdovgT5pgsGMzBiJsPHw= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iewzpnhs; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660494645; a=rsa-sha256; cv=none; b=1ZC0WcJBEj+hB3jtBuhOoHumzM5BUH+5ZuUVczqErS1i7US9FJNap3PpXrqMIybwbOKiMH W5tnOXOfUSoNC3hpl1MKzQ91I2uEQnUzExN4aahut6xj7eriCBr0uiTv4fLN5ofFakTpcL v5vyayINIs2KcprNVhfqYGl2jAxRQFQ= X-Stat-Signature: pcffi9zowxyqcd4bpph7w1uhfh5oc68c X-Rspamd-Queue-Id: 61B051C00A4 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iewzpnhs; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1660494644-711594 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.08.22 16:05, Haiyue Wang wrote: > The commit > 3218f8712d6b ("mm: handling Non-LRU pages returned by vm_normal_pages") > doesn't handle the follow_page with flag FOLL_GET correctly, this will > do get_page on page, it shouldn't just return directly without put_page. > > So revert the related fix to prepare for clean patch to handle Non-LRU > pages returned by follow_page. What? Why? Just fix it. -- Thanks, David / dhildenb