From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10ECCC7EE23 for ; Wed, 7 Jun 2023 17:32:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97AB88E0003; Wed, 7 Jun 2023 13:32:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92A398E0001; Wed, 7 Jun 2023 13:32:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8194D8E0003; Wed, 7 Jun 2023 13:32:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6CF198E0001 for ; Wed, 7 Jun 2023 13:32:05 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 410F2AF078 for ; Wed, 7 Jun 2023 17:32:05 +0000 (UTC) X-FDA: 80876645010.12.20F2323 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id DF49840015 for ; Wed, 7 Jun 2023 17:32:01 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nd3OJsrA; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686159123; a=rsa-sha256; cv=none; b=XyWQFbDXxJG9MtE4F15380h0yeYBlGbH4fIUvrnYO3cMGtcILe+In+jzfHbEWs5SiV8haE smlOasDiccChByK1iI0liRpuEDfkrpBv9jz5lYytif6XTNftCX4ZR4NDPSRpvH7NlKDKYH LuBR6fq8pmH55uoZjVJH9TeOchJIfQg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Nd3OJsrA; spf=pass (imf01.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686159123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xc3kt7fbXK4RZZ9hervM2RINSzi1H8nscf+Y8dFfX2M=; b=AnT5MTH/sLYg7Ug9R4IXIDrSxp64eX7u+zIL6aTixUjyhGPWznQLY42umdEtEuBcISJW9J 5xTdJHfDnLuzswZprrr8kMa3m+opPxZQtiEn+QrgghonV+6MGJ7iDhhBdvdh/HiZK3OEKC iBg5fQBpGcrkmNK4B2Njt749xnc3dVc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686159119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xc3kt7fbXK4RZZ9hervM2RINSzi1H8nscf+Y8dFfX2M=; b=Nd3OJsrAKbZi1fzZi41wMkaHTS4VSWLiPABmNoyJ1VEAJjA1G8Mv7JljP/lLp/NPsRdDW3 FrP6Hf2v1ESJfdc5UaVHPU0DUekUCLXysgtj75ZS13hvg+7LsR0vFAQjYvgQwyBNyEOOvr j7koiJk8XM/eSkla+yPrcEE4hxf8IKs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-255-6fb_cFy7NMyCZG_m0dqakA-1; Wed, 07 Jun 2023 13:31:54 -0400 X-MC-Unique: 6fb_cFy7NMyCZG_m0dqakA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A24F610328C9; Wed, 7 Jun 2023 17:31:12 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id DF14A2166B25; Wed, 7 Jun 2023 17:31:10 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <2291292.1686158954@warthog.procyon.org.uk> References: <2291292.1686158954@warthog.procyon.org.uk> <20230607101945.65c5df51@kernel.org> <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-12-dhowells@redhat.com> To: Jakub Kicinski Cc: dhowells@redhat.com, netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2293094.1686159070.1@warthog.procyon.org.uk> Date: Wed, 07 Jun 2023 18:31:10 +0100 Message-ID: <2293095.1686159070@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: DF49840015 X-Stat-Signature: x73g6m3g5bqmwdq3ug56c1kt5k746zaf X-Rspam-User: X-HE-Tag: 1686159121-231524 X-HE-Meta: U2FsdGVkX1/wgFBNaQNpkKewpEZ68iTSCb+CBeyn2Dab7mUf08hiA0Is4hxVN1NYSLEnfhBAIvMOIfkF+Y39cSwhzJjQycK+T59fnIFg85UqqLtj+ECsws5Qp8vs3nxnlItcAZ5jID8CqmaLGjemjAu1EAO7zaUf7B1XA5KysRv1TL7AklDnVUqpKWlByxeJ6TzgIflR7/71+4wQ7DBCmUxhwsGeIlMBPZmqotmaqUKhCeGkksIuejHkJxFOK8Dz5fSDb2kfNe/MQooVKVlp1t/fQcpJHCuzm8Wcy4wLrBMXQFELLUUWH1vmPqCcnUjdS7pNpY/luApwtt+pd5w32o+d7Oz70pA+GU1LeH3deeljmgmgx5iSjzJRPWqG6V5LcycgMcjlCt4PYdG5wQQ95cZ4os7gvHtrBaO+/SE0CjSk7NmuH946ZWp1TixJlEy8PcUxkapgUjtpcIoEFAJSPafStQrucgimEAZv1XDcz3fYzK6V5ozR+YsQ6sWCfXlA/qXfGSUKCwbhkT7H4d4yU9O1krgYnaxIq3YMV2I9+Wkx45kxhlMJlwRBQ4YOaUJFmAIKaMuBk7Fe9P1X9UFNK0pzp4QH/BM6g8njR24LZOiiENnAWDmArlgMKzL33yzQhS29FPH9wVoJE1jLl0yKp2ghtRPD9mQUnkphGElHWFimlsLva0rP0eTptt7qlMaYbQuOU+qx+dsAausaN0pErx5I4v3NU8qv5t6dncrEBQ68RedAp0lHQTWRbJSmS6LQjypZyg/PMfKwvJlDQlB1kSoVrznNszYuexYEl62t4UXFfjsbAARHx5UBw0MOI+TruIVqAEUsy36tMO+67kjBCxS1bdu/jEGQc4ovYU3nc/J3O0EoztdWeLYLhUmZbzdswyxCHnNyN03Q47WetNULLoL564lbNEblCZee8d4jDckmuZljeWukSagTnLpvQngyQiOEejaEbF3shkV753k Sxn46vbW KdfkA1A18yODIijpY3tpAflnUq/IQNlls0kq2dAGL8p8Ij7viLAa5v9UHUYP3CYfzGEOW4zbbLs1Atb2zd/9V10Uv5zmXdhd6SzmP1eAExXnyvr7Qnc5RQ2a5VUWBTv/NSplW2wmaF7tAERUGJR3ueuqUJyiNPy589TGP239OxwNl6/ad0sdhPjni0tMp5kR6VfvJY3unQWBmN+pHwr0/1FC75ES/u/5ReHyeqL1DAVr5FvqkCUHCEskndgjoUJocus4F/srTlElu+rUYIhEK1tDU0pP++Wt2eauYoo3yQck9L5k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Howells wrote: > > > - tls_ctx->pending_open_record_frags = true; > > > copied += try_to_copy; > > > +copied: > > > + tls_ctx->pending_open_record_frags = true; > > > > Why move pending-open-record-frags setting if it's also set before > > jumping? > > I should probably remove it from before the goto - unless you'd prefer to do > it in both places. Actually, I need to keep the one before the goto. David