From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48C44C48BC3 for ; Mon, 19 Feb 2024 16:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCEE96B0072; Mon, 19 Feb 2024 11:12:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B81B66B0075; Mon, 19 Feb 2024 11:12:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20E26B007B; Mon, 19 Feb 2024 11:12:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 908A96B0072 for ; Mon, 19 Feb 2024 11:12:26 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 32B38A04A5 for ; Mon, 19 Feb 2024 16:12:26 +0000 (UTC) X-FDA: 81809045892.11.E5D479C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id D68E640010 for ; Mon, 19 Feb 2024 16:12:22 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KPNYccry; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708359144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6KnJ0wJsYP4PPL5k3hrJckmE7GZOMlUN8YoSAyFXLQA=; b=cNlSX6G1yuZW6vAI4WORhMwVfvd/6YmoktG/iZhsYc6FgZI0nuf1yp9ub6HrSW31yV0w1i 97S619Rq/M2FC1KsnsvPrEyrUL6WKZlsrlSN9t3ZarPNR6DxVI9qkbxjBIJYFlAb82jZx9 Lq+PZi1e6alltipfXp8fXs1fBWZjIfU= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KPNYccry; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708359144; a=rsa-sha256; cv=none; b=bpy+s4cfPzbsszDqqpxyXPxQA2FlaPW8QaP7RPFJyq0CS8wHBx1bfcsisvsFU+zB7XTugc 5X53G6buo+NA/NXE+y5YMy2BXvfdb2eAiv1V1Fvw4zXzYQL517AQLS+93yeeRb3F3hul0l dCfu0Z5wHKXYVIIPBa0YT/bVhLfLMpI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708359142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6KnJ0wJsYP4PPL5k3hrJckmE7GZOMlUN8YoSAyFXLQA=; b=KPNYccryb4rncB+CK61LYBnT0b2UO3Dji3PAnPcYaOq+sy79O4Rwhc7d60HT1/p6Vvrxwx CPq3dfnGP+xqjWFkB2yZuvTp+S+gr1iBuv+4/aNAeQ7jDumAPf4k7XjSd02GNauSA4GaPP eVVlt+aLGnWiziN2nF9t804m4geTMgY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-dv6PHkUGNxe-PkviZ87TXQ-1; Mon, 19 Feb 2024 11:12:17 -0500 X-MC-Unique: dv6PHkUGNxe-PkviZ87TXQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B6AB2185A781; Mon, 19 Feb 2024 16:12:16 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01DEB492BC6; Mon, 19 Feb 2024 16:12:14 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <187507.1708357334@warthog.procyon.org.uk> References: <187507.1708357334@warthog.procyon.org.uk> <187136.1708356611@warthog.procyon.org.uk> <20240205225726.3104808-1-dhowells@redhat.com> Cc: dhowells@redhat.com, Steve French , Jeff Layton , Matthew Wilcox , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Christian Brauner , netfs@lists.linux.dev, linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 00/12] netfs, cifs: Delegate high-level I/O to netfslib MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <229264.1708359134.1@warthog.procyon.org.uk> Date: Mon, 19 Feb 2024 16:12:14 +0000 Message-ID: <229265.1708359134@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Rspamd-Queue-Id: D68E640010 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: f7zc8kakgn1p7kmsd1gdrcmf39g8zd5x X-HE-Tag: 1708359142-398369 X-HE-Meta: U2FsdGVkX1/I6gvogL9oPsDjTUAbEjXHw/XZU4sfTNdJ8LATUurziLstWciKk4z2+24GBD/LYtsLOpNhoFg4vg3ndBtpW/8Tp0fpCsE63Gg386gJfWZD6U0POmKzK0ZlNe0JHxXD0EGS1jVcNNIwksCVsYQss8yr77Eb6Lk6AfT9Juo/S/sqBgdO7+KhCQyQJcFLOh2s7HL5nHuuvzNtFd+mPBc3d0fYoXvSsvnHPjwlmg9GWTUq8JbfzhCBj6ylfVIkL1mcEZqzB9MHxEghVc+LRCw2bOmQkAt1DurExrTu2U+AgX9ZrXG/7lOvUzqe7dr3uV7OVaRPVaQjWPVQ6SLjNekB1PMhoeAlIfV0+jQ03tqF0pv5rU6jnFBO5r/hdr8w2mEzYQ6TrtvXUmejar4X9K0k9fD9y5rlng7/Wa7WKupA4FdsQ0yi5fjqCY4/KWR81gz1V1XX6+5XKAYCXKJAKCgYYEBOQlC8vLXjuDlcWsGK0HKT2Bl+86cdI6ywhG0QSoS0QPMrhFB+C6YPf24ZGueveKfpbVgl7Op2+kTMNnnhVtJTrsH3FdEoAePXBWracXtnVNItycmS/liaQzyurA+bvJSs/N8OrpvvPKJm8TVm9a7B6xpD790Ynd7wpYiTS0d3ey8o+Bh7ZqMibYPEJrNsEQTgOKE0GE+LyoQ72V/Q/qtWEnUxo0ECGdoKlXsVTfXqSeglj+S34taZ5H7cynowVfldNabwJ5JmJAE3sin1VHnil8iBW42ITT/DSXMvf8cKrCVTg7k7Y5YgJ9Y1llrMqz1DBex0YDmLslVc+zamv9YuelIA/ZDfQ07xWy2P4nGnMTrYHl9JG/GE3lBzwXR8KvIGOK3O8zI+utFUJM9OZhQeYBOjx+JmHaxFrYwmtL1qO6bKGiPUAZIuRYUQ008KJjNUrv4XVOv+UUpPhs8P133yNGOEkRxGYm9Bf4zkcPvuRGJG484NHjE L9OCzQp3 JHtf3P62amDPEVxzJw32EtESD1dwmxl2F/2E9FdtjCi4+ecdd4NNcsrrls4F3+W4SwUbvYye4Iv3oE8O5RqZr9UyEsOp97/MXyngUhhoaftbvKPhVM8uQaHYUodyrBeF9K95NKpMaS9EDD9ztQpt3CTjaGljjba2/kN+BURbJsLNgK1dQmi+GKIhzyrYjvtHc6OYI7e3xZ1XRE3Dj84z39arUyyAODiw3RPA9ms6VKB8U13f1cp/W2kc3PlcXUhVBv1of X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: David Howells wrote: > so the reversion is probably unnecessary. Removing the iov_iter_revert() fixes the problem. David