From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DEEFC7EE25 for ; Wed, 7 Jun 2023 17:29:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24FE38E0003; Wed, 7 Jun 2023 13:29:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FFC88E0001; Wed, 7 Jun 2023 13:29:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EE4A8E0003; Wed, 7 Jun 2023 13:29:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EDCE98E0001 for ; Wed, 7 Jun 2023 13:29:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B65A61403D8 for ; Wed, 7 Jun 2023 17:29:28 +0000 (UTC) X-FDA: 80876638416.14.A3B7B2D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id B0555140017 for ; Wed, 7 Jun 2023 17:29:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NPlNBip8; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686158966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ce1A88jUKFjSY0Tt+7w8QiaS9zhzMSTost2c+cyMfRw=; b=fMkuUcLJbJw9168Uf+6hUveWW5kUsl6Zy/LOUqc67L5p3ZU/2hbbWzQAVTQ5GYVfkiX86j LUUcsSdUvE8zMcZHSIX6GYAvDWgiaTrA22CjN5Xky+WewdATwNJaj/h2mUNG/uv/mB1nbZ NgJ4ARFzcvZD8xWuw3a7/Eurj8L69fA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686158966; a=rsa-sha256; cv=none; b=ay10k93yPoN6iMjKPrRtNqezZ9BgWPZT8bsgGOE6soVbU4ppmNOLq6ZlyZ/Ivef6JTB7Pr CjY2STVQoyXScioKBovmFmrjIGJFJanLZSehsjyCOpZtjzktrMIxngyljYpIZwc8tBxBl4 qnFtRqXJfwU+tlyZD2UzqlGEBMlgTI8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NPlNBip8; spf=pass (imf26.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686158965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ce1A88jUKFjSY0Tt+7w8QiaS9zhzMSTost2c+cyMfRw=; b=NPlNBip8g9X9uBPO/xkZPDi0F9KeO3JG9zXXevS4Xy9QlLFJwSmY/CocAH2zFAVZ2HUnf7 chWNW/mJQX36IrCm6og2OfvAL4eGKir3nuhs6u7kcORAVCesm+6p6HwoWL3etG6Xx/0tXA JzU6bBGPXY9U92QnJpbmw9Usumc+Pz0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-rIVfiEgZNeSYJi6TjNk2gw-1; Wed, 07 Jun 2023 13:29:20 -0400 X-MC-Unique: rIVfiEgZNeSYJi6TjNk2gw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF81A802E58; Wed, 7 Jun 2023 17:29:18 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id B727D477F61; Wed, 7 Jun 2023 17:29:15 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230607101945.65c5df51@kernel.org> References: <20230607101945.65c5df51@kernel.org> <20230607140559.2263470-1-dhowells@redhat.com> <20230607140559.2263470-12-dhowells@redhat.com> To: Jakub Kicinski Cc: dhowells@redhat.com, netdev@vger.kernel.org, Linus Torvalds , Chuck Lever , Boris Pismenny , John Fastabend , "David S. Miller" , Eric Dumazet , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5 11/14] tls/sw: Support MSG_SPLICE_PAGES MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2291291.1686158954.1@warthog.procyon.org.uk> Date: Wed, 07 Jun 2023 18:29:14 +0100 Message-ID: <2291292.1686158954@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Rspamd-Queue-Id: B0555140017 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 5h33npkc6fbor5yu88irq4z3bf1n65kf X-HE-Tag: 1686158966-172074 X-HE-Meta: U2FsdGVkX1+yZaR76YcEZft1Fq6PA7zD935NzzL2x1IqBq0HOGDW5tG1NnizRBE2X5+5egX6BMUh//uccZyCue6YomT3kD363kGhTdaFSuHNU++rcEMBQsIdjgkzrLPKlTDhUGu2x/E2hIQVO36aeiSdN6V/Fp8M4edJGG6dpOc+9bmTCShi5pZPZizMaaWibeuRE07E4DbRyjX5oavxNZcmhJ8fWEo2hx+aOHpBKJ9p+icwVRvOO0v6SZJJwd2mjtwDDMYyk+hwtWSITbBf/LYaSeAHoCh8hbNMYqZeBOdCMdwxRKuoNOHa5OGCMY5F/ZrVxQ03JSWPHwVFZaaMQs0a+I5/Y5VUGad0OIiYM8j0L9FAKiJoGLEODc86KCkaZYpbw3YhYFVzosrD/bU3yYlrVzUhJmvsl8kFWUroTPKoUwoIKF3fxCeDFR6eZlxZP8xMAX8OsW/G8d1VL2n8NKfSOiS66VEFXfDfr6u2nqZBO8sgPI69xXs4HevV5E3NApTpQY+b1uw3gASKGqxA3pN3QcGf7ZwkLO5e8IXByNC8fxYYdXpNqVE76N0ts5G+3G5beKXa/j7aHI90Voo+qiMZWurSqKeeGGTQfxweTffF9yHw+1E6ZC3oilMr9pl/nHjcimhbw3YA5N7Nl/2OcC++o/OiuKkLR2FqFLtrM6aUp9ikxSBSUvMk5llTPb87dODnHSNpbb9L6zMM7CpUWHkls+kvmRvUNhJtgUbQuTQijEVdQnhgnKoJHdrEC7mkJ4OOov88G04BXLpXMZlbrlsrcWg2K4PRkWqlrBP6qxyd5zj2zzEldckNCKJtFK048VFjIFwaFLgqN5LDVzZz8z/HaeUr8ysCFdHt5uJXRsO24Vqce5hn2hag/T3hp9w+lNLrh11md3r1XO1gHyos5UYKCNWXe4Ybee81Cg02K7R9tqE7wkHalkUNo3vh8ezZQ/7RScgik2o8I4g/E8S 9sSO6MZ6 HMpdsq7HqFQvtY/WVjiPd+uNM3NdtsT6tlXxL3ojs9H8nPNmZ5UnMZp6dOtvow1f7XTjV7jdy73G279gjR9naBZqHiKZK8vO4XVqX7uYBCJVr6BWxZg8OS9d/4Au/fXmWTcpFepkX6wfROEwSRjplKv9yoT19pEOnasDbzdLnH6stPZeeDt/BtARDD6PLFF0sloTpl8D9JpAGSa5HPzqBfOTYh6E5B0TAIkAVIFRvZBsve3YF3UHsNj2SVhFiGn8Lfjq9tgC+wi2vWleXaoo/RJstB17IqY3SgjuR2Oi1X9MFwmxSZNMKDwvCfFOUvyMLA87MdruLqK8WHrw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Jakub Kicinski wrote: > > + if (put) > > + put_page(page); > > is put ever set to true? Ah, the copy-data-if-slab thing got removed. I'll clean this bit up. > > - tls_ctx->pending_open_record_frags = true; > > copied += try_to_copy; > > +copied: > > + tls_ctx->pending_open_record_frags = true; > > Why move pending-open-record-frags setting if it's also set before > jumping? I should probably remove it from before the goto - unless you'd prefer to do it in both places. David