From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F9E7C282DC for ; Tue, 4 Mar 2025 18:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E1CE36B0085; Tue, 4 Mar 2025 13:31:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCC1B6B0088; Tue, 4 Mar 2025 13:31:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C46496B0089; Tue, 4 Mar 2025 13:31:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A54F06B0085 for ; Tue, 4 Mar 2025 13:31:40 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 3AE961202A6 for ; Tue, 4 Mar 2025 18:31:40 +0000 (UTC) X-FDA: 83184711960.11.1AB2416 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf02.hostedemail.com (Postfix) with ESMTP id 70F248002D for ; Tue, 4 Mar 2025 18:31:37 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iGF8nCVE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hTcdK1Ga; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iGF8nCVE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hTcdK1Ga; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741113098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=98gqWV++H4CGrTOO1RWIa1Ttz+WIPNmSFDAZVZZFF50=; b=ebDFl9LP/7J1kLN+rLuM4O+l7CoQHrv8epF+TGWFtTRYycE3sM8zhKOHv5wXGw7anUACob dHhQkvXG2hQMvHJGJW5Fjjjy0wjUJuytdvwtXhKHdTyJuDG1fTHLEwNSuOyGnErrxIZjwK +qtncHDO7a1X7OYQpq8CNms+hX/9nRk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741113098; a=rsa-sha256; cv=none; b=30GvA10swockiMUpUfm+xQ3tyaJOjnbctYqldIrBEBYhAOtuTUpAdomk+G4CAJQXRM9F5T pf1fi23H9N5beeoWP8ByREYvFcyS9qxOAFWert7/2zJd0slbZwMkQYLb6HFsDjsnEU+GgY YUA4jdfW2J4xEkwGkwkHRpdJE1Fv4aA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iGF8nCVE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hTcdK1Ga; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=iGF8nCVE; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=hTcdK1Ga; spf=pass (imf02.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5DF272119C; Tue, 4 Mar 2025 18:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741113095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=98gqWV++H4CGrTOO1RWIa1Ttz+WIPNmSFDAZVZZFF50=; b=iGF8nCVEghjpKrLCZOiCymKnzhoQswaqs64TGfxMeJuzOWT65W3XrZGN3v7AV+UyssMp/e ix3h0g+2RQLxjOBsOqc+/K0nPQk8tYbtSp8sQNbJQBUOg6641nTakn8p9+tPvN/HzJwlJi QqcDWvUaUsXt3egrKVYrhqDXfqfYCuE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741113095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=98gqWV++H4CGrTOO1RWIa1Ttz+WIPNmSFDAZVZZFF50=; b=hTcdK1Gab110pYfgKOYtAYZqF16LnhApuOLx/MpF+2NvteiHs6G9ED1jz9tWhjBL8p3eup 6zXkZrcVonC9GPDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1741113095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=98gqWV++H4CGrTOO1RWIa1Ttz+WIPNmSFDAZVZZFF50=; b=iGF8nCVEghjpKrLCZOiCymKnzhoQswaqs64TGfxMeJuzOWT65W3XrZGN3v7AV+UyssMp/e ix3h0g+2RQLxjOBsOqc+/K0nPQk8tYbtSp8sQNbJQBUOg6641nTakn8p9+tPvN/HzJwlJi QqcDWvUaUsXt3egrKVYrhqDXfqfYCuE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1741113095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=98gqWV++H4CGrTOO1RWIa1Ttz+WIPNmSFDAZVZZFF50=; b=hTcdK1Gab110pYfgKOYtAYZqF16LnhApuOLx/MpF+2NvteiHs6G9ED1jz9tWhjBL8p3eup 6zXkZrcVonC9GPDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 438B31393C; Tue, 4 Mar 2025 18:31:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 6mMpEAdHx2fefQAAD6G6ig (envelope-from ); Tue, 04 Mar 2025 18:31:35 +0000 Message-ID: <2290e466-4294-47ce-a1b1-9f05fa3c6e32@suse.cz> Date: Tue, 4 Mar 2025 19:31:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Kernel oops with 6.14 when enabling TLS Content-Language: en-US To: Matthew Wilcox , Hannes Reinecke Cc: Boris Pismenny , John Fastabend , Jakub Kicinski , Sagi Grimberg , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , linux-mm@kvack.org, Harry Yoo , "netdev@vger.kernel.org" References: <95b0b93b-3b27-4482-8965-01963cc8beb8@suse.cz> <6877dfb1-9f44-4023-bb6d-e7530d03e33c@suse.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Stat-Signature: jbd73x9tmcoob8zjgfaax69h3dw4h9s5 X-Rspamd-Queue-Id: 70F248002D X-Rspam-User: X-HE-Tag: 1741113097-827321 X-HE-Meta: U2FsdGVkX18vIs7gr7X+xyd8FGoRRV18peuEEcb7AKwkb3uIgsTpXRXmEeuYonH260vTiIAXnnucpeOj0Fqk7uVfJEuPX9bUqxu5TUI5S48NnRZY7wQVR7DOlzsCEoLrSX7syHmtbJ1IhL7+QlLFIKS2AtrarO7Tqv0JOlvvwahHzqZNtEB99fuKkBSWs7lnDbAhIvzfU09uzV1fLdUCRt7qzjeQFSZkBocGMmlSiVkmrRI1crDvWmdDkWAE+5VX8SVnkyHtq0Xk8E7S3bfcpQGQtDTX/FEHAW6d6vDO7B12frxjcIGd3pJmdZ+7MuP8+UWJmzohgNy46SG4YO+v+ZLn+HK992m7zX1IeW4qBKdqupP9U9uI12kHxtbtf20KWNQH9R23fgUD0HoxjWHzWEw+rW7dCJ1N0wfVCHhxellRU2nOh2g9uwtaUyXmCzJ3LmdQt5LHa70s5TLBmECWTwEwM5R37ZXMXe9i3bU0kRxotPCkfYpmhpp0oBNsyWlHKVbqSqHuBx9DMoaZXkLEWhJ+wG8Gf+uT3OtPOsz8sjSvs5PW/jEa27W2h0WYlHxcgEo+MUNAZDeI4EiqsEHx88aoPBWJrqFDVtB9DspxQuZEjcUCoAjEQqb5oK+n7he3tNWnjrsdI18HxSOMNH2+YS9K8uCQpEJgLlpZMUbjtC3S7ZPEeAB1wUGBQzcaIdw0Pb4GdnjV15N3KZiNL8TWoSoelhRq2wQFttK68X5EDcJ5Te9lgu+4Zz5m2+L4JaYqDRR/NTJAI6YuAouW7vqFVHA2/E0DJbMf+sPGuV79QpW72v91yjn0t6+1nMXGgCjsC+PH1aAYrD/fUNzr4X6Js4MYoIuOh1yS++26tLHaPQlHAKgnbrqTVyZ61iLgIBCieKCOw+cmu1pPEW5RVh4o82YZojSdVQx0TRDecBRIjWX8tzbio7l2xt3kn6zUbt17eztoaM/XI56I0WAl6Ol D9/X/CBO ufc+kjsXIS/doa2Tmy6BmSWmV0QcKP0SYCFFW6toO+YjfUGv50V+yqw4AZ07fTQ4AxmAZ4UbRbX/SfTUl8FnPp28yKjyHBgD70usTxN4WLj6t+qYPEiY8UZUzwIKCBOLYlsxpMScFZovM4LWrYB6yHMAP7x8Nixf61sLZtY/leyMaJwfjKEd5gFDAIjYjzVHr59HDW40PLbBQPCZTm/2KbxggeEiJqL3o+QOSUfmJm8Q2kQkCM+5R8Gcdmm14+vsrJ9n+LArlUz432xCYDJdIw3myqsQRjBGy5kD8Z4GwnySi/4llTHrEZEG4hsXIeSE8hD5ubtweSH2PdnjNTwbyGUfrAUCzcDYgRkLixCTV/ek8gBwt4u3K/MG9UYmGZ5ckro4/fH7IsxaazwZKQQsOQle6ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/4/25 19:05, Matthew Wilcox wrote: > On Tue, Mar 04, 2025 at 04:53:09PM +0000, Matthew Wilcox wrote: >> Right, that's what happened in the block layer. We mark the bio with >> BIO_PAGE_PINNED if the pincount needs to be dropped. As a transitional >> period, we had BIO_PAGE_REFFED which indicated that the page refcount >> needed to be dropped. Perhaps there's something similar that network >> could be doing. > > Until that time ... how does this look as a quick hack to avoid > reverting the slab change? > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index d6fed25243c3..ca08a923ac6d 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1520,7 +1520,10 @@ static inline void folio_get(struct folio *folio) > > static inline void get_page(struct page *page) > { > - folio_get(page_folio(page)); > + struct folio *folio = page_folio(page); > + if (WARN_ON_ONCE(folio_test_slab(folio))) > + return; > + folio_get(folio); Maybe we could do just VM_WARN_ON_ONCE if we fix the known offender fully. > } > > static inline __must_check bool try_get_page(struct page *page) > @@ -1614,6 +1617,8 @@ static inline void put_page(struct page *page) > { > struct folio *folio = page_folio(page); > > + if (folio_test_slab(folio)) > + return; And that means knowing where the put_page() side is and skipping it for slab pages like for the get_page() side below. Hannes could you apply this patch but also with WARN_ON_ONCE here in put_page()? And tell us where the put_page() splats. Thanks! > folio_put(folio); > } > > diff --git a/lib/iov_iter.c b/lib/iov_iter.c > index 65f550cb5081..8c7fdb7d8c8f 100644 > --- a/lib/iov_iter.c > +++ b/lib/iov_iter.c > @@ -1190,8 +1190,12 @@ static ssize_t __iov_iter_get_pages_alloc(struct iov_iter *i, > if (!n) > return -ENOMEM; > p = *pages; > - for (int k = 0; k < n; k++) > - get_page(p[k] = page + k); > + for (int k = 0; k < n; k++) { > + struct folio *folio = page_folio(page); > + p[k] = page + k; > + if (!folio_test_slab(folio)) > + folio_get(folio); > + } > maxsize = min_t(size_t, maxsize, n * PAGE_SIZE - *start); > i->count -= maxsize; > i->iov_offset += maxsize;