From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C0A1C00140 for ; Thu, 18 Aug 2022 10:43:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B17B46B0073; Thu, 18 Aug 2022 06:43:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC7426B0074; Thu, 18 Aug 2022 06:43:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B5396B0075; Thu, 18 Aug 2022 06:43:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8D5766B0073 for ; Thu, 18 Aug 2022 06:43:45 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B32F140A24 for ; Thu, 18 Aug 2022 10:43:45 +0000 (UTC) X-FDA: 79812377610.28.4288577 Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf01.hostedemail.com (Postfix) with ESMTP id 77A48422F0 for ; Thu, 18 Aug 2022 10:01:11 +0000 (UTC) Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1660813672; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qf/fOtvxzphZECcP4g0SbRjHJLvM9rnNKj1D8UYOdCU=; b=F/jfdAqruc6NZpYfm4kHww/8zt7yCw/PiZesk1jAs3NJOvJangOTjsU6uFj9E7rUxFuXJ7 5ieJIptdFb3hY8PByLbsyV6cIbEe+VQLfRd7/3vilGT7HAiXeYGmfuEUFVrMwEy4M1YewR sJQltiej44aVBe0G2b8tkMrWT8QiJpM= MIME-Version: 1.0 Subject: Re: [PATCH v2 2/2] mm/damon: replace pmd_huge() with pmd_trans_huge() for THP X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Thu, 18 Aug 2022 17:07:23 +0800 Cc: sj@kernel.org, Andrew Morton , Mike Kravetz , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <228E21D0-536C-40BC-A21A-52C1762DD2EB@linux.dev> References: <58b1d1f5fbda7db49ca886d9ef6783e3dcbbbc98.1660805030.git.baolin.wang@linux.alibaba.com> <58b1d1f5fbda7db49ca886d9ef6783e3dcbbbc98.1660805030.git.baolin.wang@linux.alibaba.com> To: Baolin Wang X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660816872; a=rsa-sha256; cv=none; b=h7wXN1btrMPkwQNhq6a5S4oj30K19iUaQcajGiElVQYkPnvSYt1gju8eO67OxHycqAx5PH twFdRRZ1FWHWJxfUuhOMkSV3J8bJe95PqD4rpxa0NYfhsyHxOHRqcKf50INHtXIH3a24ii zSyLEwX02YP/z/07rGkeliBf2X9f7rM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="F/jfdAqr"; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660816872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qf/fOtvxzphZECcP4g0SbRjHJLvM9rnNKj1D8UYOdCU=; b=bGj9SsFp9ymySE6CzFrZbveVSnMWGWfBslVrp2mkKqThZ5V+mAxqifV9f25SoZ4N3eRdy5 tGV4kwcon2dUhimPm7pQsMUCi+ciCbjKJEap4sSCZZEEUyaF5S2DNhPgn2LWaURErLL7G6 Y+DWUgp+9XHfupMI35wVPNsf3zPhKvE= X-Stat-Signature: 3wckhfszke1ft9wr3yhe9n196177dijr X-Rspamd-Queue-Id: 77A48422F0 X-Rspam-User: X-Rspamd-Server: rspam05 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="F/jfdAqr"; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-HE-Tag: 1660816871-7791 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 18, 2022, at 15:37, Baolin Wang = wrote: >=20 > The pmd_huge() is usually used to indicate if a pmd level hugetlb, > however a pmd mapped huge page can only be THP in = damon_mkold_pmd_entry() > or damon_young_pmd_entry(), so replacing pmd_huge() with = pmd_trans_huge() > in this case to make code more readable according to the discussion = [1]. >=20 > [1] = https://lore.kernel.org/all/098c1480-416d-bca9-cedb-ca495df69b64@linux.ali= baba.com/ >=20 > Signed-off-by: Baolin Wang Reviewed-by: Muchun Song Thanks.