From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE5FC7EE23 for ; Wed, 7 Jun 2023 17:10:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90D216B0074; Wed, 7 Jun 2023 13:10:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BD616B0075; Wed, 7 Jun 2023 13:10:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 784D18E0002; Wed, 7 Jun 2023 13:10:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 681AB6B0074 for ; Wed, 7 Jun 2023 13:10:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1C5CEA03BD for ; Wed, 7 Jun 2023 17:10:18 +0000 (UTC) X-FDA: 80876590116.17.F500B41 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 26ACE20021 for ; Wed, 7 Jun 2023 17:10:15 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XCDxYdsH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686157816; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E/4eS/lJzQiNy8tMpqwPuOfCnp2B44jW2PUSyg6nSfU=; b=EC0Lg5cN1PFJToqksfEHc0uPE33KdFGlXFeFjYJPEJzz5qXQsb8qWF49mSkJynNfDRkrHm 8Nk+B8ieCUorT/2//H8V/LFx4tvQSUfsl+0qHiKAk1JRdFsGtP04TSMzjnoz4UNgItgtXM Ne/m7QoLKz2cMx7r92mB1HJ6jzeN7x0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XCDxYdsH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf13.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686157816; a=rsa-sha256; cv=none; b=bnYWYekL/Q9f6gPgBq8UlD5kC47CFAQKi6A+85/tDLtYjI2GLhSFf2gqH0mvvTpIW6Xyma 6+KeA0Shi4WiHgvvwWpJwJFwOkjuJoR7aGoOSwDCP1N6/tmMEH9SyEcNfuiTfUPwyl00lh X+BVxod4rv5rUi2WGGBfeFnfKP0aRqc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686157813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E/4eS/lJzQiNy8tMpqwPuOfCnp2B44jW2PUSyg6nSfU=; b=XCDxYdsHL5jlCXrzQ63i+8mw3z245fziENv2t644LRJRdQmEa6JtZYT4jTn7C6T09odq7+ OD3PzHl0zgUDWZ+VpnxteQolKWwAKWY2+04ZMb3cAx8umxXcUy+Z6c9vFrfFVi+lNvqmmZ 575rVfZBnJ/mwoYKt5RBm4uxt6g6CCE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-628-iNfVzKGiMs6NtphSbkk2cg-1; Wed, 07 Jun 2023 13:10:12 -0400 X-MC-Unique: iNfVzKGiMs6NtphSbkk2cg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B6FF811E7F; Wed, 7 Jun 2023 17:10:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 398402166B26; Wed, 7 Jun 2023 17:10:06 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230607160528.20078-1-kuniyu@amazon.com> References: <20230607160528.20078-1-kuniyu@amazon.com> <20230607140559.2263470-10-dhowells@redhat.com> To: Kuniyuki Iwashima Cc: dhowells@redhat.com, axboe@kernel.dk, borisp@nvidia.com, chuck.lever@oracle.com, cong.wang@bytedance.com, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, john.fastabend@gmail.com, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, pabeni@redhat.com, tom@herbertland.com, tom@quantonium.net, torvalds@linux-foundation.org, willemdebruijn.kernel@gmail.com, willy@infradead.org Subject: Re: [PATCH net-next v5 09/14] kcm: Use splice_eof() to flush MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2288535.1686157805.1@warthog.procyon.org.uk> Date: Wed, 07 Jun 2023 18:10:05 +0100 Message-ID: <2288536.1686157805@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspam-User: X-Stat-Signature: w7wm5u1zqhgf91n9je6of3nyaiduggu6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 26ACE20021 X-HE-Tag: 1686157815-854621 X-HE-Meta: U2FsdGVkX1/wxdhQXO22fGyv+g/DcXO8ryaGAyfyJujAoiH5Wh7Ull/VBOwG8fgvP0E8iP1jnhxwWzmnkZq988UzNhoin7I/opWxLBXFUzDMwWRxuF95zAiaQDQF1WOP+64sYtbwB2qUlBIzqhTdtt6WwpnQCuiTH5z23GdreijXtNZEMjjYiOBp5jfX7OsU7t9a2xVEFjkFu4ysjaAz9WBaNqAEbwGDX1Wu20SjcQ/diHqJM6L1HMYl73guGgzHc4tV8vI+1JUCJf/JXNcnBEpeSc7ddFOEuo4rRjYx3Boi/7eQImu8gk1Xn2ojRBPJDyhB3E5dmV7gSpGA42WIa5PsOA0rbIdIJ1KV1P+FGYb73LaY+hKLO2vqezRgNoOezdC3sFhibVwxhqINH/2rTMtLEXYRhSJk1s5frp5NgJOdbSnIs8OxA5oKDqazAJ/frAHsl/j38/SUzMnFJFahbDkw4nZtt84cLF+B5bwQJpXMavXK17dKYwc5oLNyMhS6tSL8apJ5XOfBXsF+vJ+lt7O0b29f6SFTHMuNFgwlYcu6W2s4H5MQL9xcxdc7+mKCy37fXqOfcGEAzBVDAmRFaBIKVhquZzkBBOBPvzEMQY/2tx4UoYMoGKHj0GnuxyutHx/diJZsHnLQFkNyQiW7an4lqD4SAPTzV3Fu2wHSSkZsDyF/Yo4xZPuyOX1xJU7EX2T9lNkJhUGzyP1nCsDX+1TtmqHTJ+XBVIQUSdHRB30kiy7oDhlZ1oOokqwDGmSO39Oo+PQQ31NlrbtOxHt2kTDoeH6dL8wB38BRWgYT99I2sT0kZvRoNeMEEmOZWt2Wr4qXNwswhIA6DwbiaDdhSmTART7SrXh3MQTT8niKmzTOlw3mMgwMk570BiwQSVxrce1RgJNOwmyxoesXrMjxukeQ0JuFjvgbmWtifJBTPow6GS6Rm62oc6DZyQoApppQpdKSd7fyEzJ+x5gguEe BkJu2cNL /CW2rtEAIaEaRqnNhL4wmOa2HBRioM80FCVCdJJCtcmAzfrzmZEJi5kSpCsz7AcS23fp8SVE6aNVgSVmP6ihzNyn2L3XXhLhPx9pGeiSIM3J8WoxGTs/7yQFJuFN9SAO4o3nzKl+2XW+gOPOm59W382a81Y5MzgPf7X0Sbqv92pAk115RlFtg8BqDDbq31kFrX3E4EJXoyLC7k3Ry2xGD/4tqzOUS18BjzCXJuopG6T9VK/akAf+05coJFatY0HjlUqHrcmL1I4nNcea94WrTIbjMU5czDk9Mc29toTjrn+PqDmIhJBpC61wKcjyxx8mhzY9G X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Kuniyuki Iwashima wrote: > > + if (skb_queue_empty(&sk->sk_write_queue)) > > nit: would be better to use skb_queue_empty_lockless(). Ok. David