From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511A4C2BB3F for ; Mon, 20 Nov 2023 14:05:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0D7C6B03FB; Mon, 20 Nov 2023 09:05:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 995896B040E; Mon, 20 Nov 2023 09:05:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8367D6B0413; Mon, 20 Nov 2023 09:05:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6DF206B03FB for ; Mon, 20 Nov 2023 09:05:10 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 45E4080931 for ; Mon, 20 Nov 2023 14:05:10 +0000 (UTC) X-FDA: 81478504380.26.CD064A6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 46EDC18007F for ; Mon, 20 Nov 2023 14:04:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ny5Mo9sJ; spf=pass (imf24.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700489065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KXOjz0ifmGOciYLPWvEqDuqbvUzPaElYmDcPCwYGBB8=; b=heSIC3uZHkmstihQpCPmBR3flGFL6nvrcdCa3ZlFHk/fuBuV/kCtOnqHOW6+v64grdstRU S3BKEgSMHrZRLvo/RxaTY1AVpjHVeuXm/7u5jzCzcj0IyUHpcJecVl8DFa6znVuEOeVgeb IAEvbwBU5WE+0lGiIjKsBmV2YusybPo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700489065; a=rsa-sha256; cv=none; b=ka9ipy0lUQhMn/+xThMDq9CZlbUxuTrsKbJ0/E6rPKQdh4qo8LzQ36Uws8cK+K/YviZ9Uk elaToJR3l6gK+t9CAvpkiwzEgCMh51RUHsvC2Vn8NA9lD8QHQt7sbCK45RjPxjfGZW6ug+ cWWokCSZE9Nlsz4cF0SXZvGRawd6ExE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ny5Mo9sJ; spf=pass (imf24.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700489064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KXOjz0ifmGOciYLPWvEqDuqbvUzPaElYmDcPCwYGBB8=; b=Ny5Mo9sJiV8xEcK82+uipRZCHKlsyknCkl9nRWNd3T4VF2jeasppQf/MgRdzFqgwcZPB2Z 9HTMeYmdzneT1T83pBwizhmKXqFoxx8wKKmPoU79zW7QUJbjkIfVBNmnPWovJWktta0P43 L25vRfJ5mI0LHfsX5QOWtQk01DTmN+Q= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-u4zxrFwiNz2hIKUxejFxSw-1; Mon, 20 Nov 2023 09:04:19 -0500 X-MC-Unique: u4zxrFwiNz2hIKUxejFxSw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFF793C100A6; Mon, 20 Nov 2023 14:04:08 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.16]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEF75C1596F; Mon, 20 Nov 2023 14:04:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: To: Omar Sandoval Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, Al Viro , Christian Brauner , kernel-team@fb.com, linux-mm@kvack.org Subject: Re: [PATCH] iov_iter: fix copy_page_to_iter_nofault() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2285535.1700489047.1@warthog.procyon.org.uk> Date: Mon, 20 Nov 2023 14:04:07 +0000 Message-ID: <2285536.1700489047@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Stat-Signature: s74yr3mzochdqh7tpuukqi6hdmkehfrg X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 46EDC18007F X-Rspam-User: X-HE-Tag: 1700489064-945583 X-HE-Meta: U2FsdGVkX1/Dv6ko4rQjhFV9qctFzvcnpRtSK5VEzlXkPUpNsCMBq1qY+NpAO75x7Cqj6MbrLOQqm0R4EBhksnPkXuomA65oMKWq9vDFs8Crdd7xy/8dnk/NsOIYlRTcXEaH2HkrGySFouyPdKj+4RhpadxIROp2Bwrny5nkU1Gf+Av3lkPQpNeXfkYzu9gSWaohr7b+fCS+rnXWyIYEoib2O5x1Jbw/CLZ7lyjxCnneyhbqQHlfRW69Id/h5ZudG/dVCrVnidueih9KnOD3X7GAoaEnd7aib7WNoeJlQxFxkMFDJwmie6/Y5yExX4ZEXv2+ksY5KcBAGbd14BBy/CVu+CrI1g8havoUUDLvHd4rBK0ZDFMpWouC1CZPMYxSkcVVwTWbLbZ9FqElftxnjfwaN/5f2xkM7Imh2Zo04g8A7hyHBkmr55LrXYqf4m7G9Qt9JJune9w9ircPH/eF1ut8xT9kNGbTkxMnbq/zpRr8bTTC/bgfJs3QSDiDxOy9cyFGVnBM7SfHargce87B41zYd4+ioB66874UC8lxhaDseZTqJNvBGVS6UTgM9bSaivLhWMyQxPZ1gGiXeLpHSvkqTm6OkRe6f0dvr7z/nOZmumkjsCwbtbnVcFfUaEimdZjikZ7PMPiVcRsIeoAD+ThvquJaWi50+CI1OkN229K+B7qxixhI4xBANRnXPOvuZe+JxwFUv4BNDrS1q57kAtQHPJEcTpCjxeolfE2kuXqAJnlDzUJztRmk5xNygYdbJQzXn1oGet1Ykx3JuuBFYHz++NN9FcVD+Y/YkhDNKRS9iP71/V/84N0EqraRA9AJaasAi5CY/6JTPv4hFVvbLHwS2bu7tzIl4WnhhpvB8LGQY5QlwqGLX7BxjSOGT5kt8qaLxlcUpgQ8Q2BPKstX01m/qrfJPSVcBWFxQL7kKkO6ftemb8fdITkF5DYFeW+gurJtyAKWrOI+gfkmgNE 9OL7Md82 Ewyd0bE6j4ET53MX4bNPIscNeNIXDIW5U9h+834zCODMzfgiZkfLq7hXxzc2qJmdv2NDBSFk0OGhyGipIBqU4Bp/DuWpsn+snfBXW1jfnX5qjigpdxqKCsu1k+063ksPpAdjS55hR1Cz5/mjPis9vQ872CjhXPpYYWbuUMLFlXZzjsPo5+x9wwRnbN/PkVv+P1ozG4SVLjKDa8d5nnqqxRugGe/6RjykrUYfr/mDnKFA2XskS6HNXDQjpq9rHHx2IwBdEB7d9lQvtL8lxriiuKaiIMq3i6e+7YNA7ThKb+bPsM0JCn8lCGsUJn8JS7AbYIUxL1h4d6qwKsAvsVLazrkCeQevXf7D8ZVcUzEib6E+wPX4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Omar Sandoval wrote: > From: Omar Sandoval > > The recent conversion to inline functions made two mistakes: > > 1. It tries to copy the full amount requested (bytes), not just what's > available in the kmap'd page (n). > 2. It's not applying the offset in the first page. > > Note that copy_page_to_iter_nofault() is only used by /proc/kcore. This > was detected by drgn's test suite. > > Fixes: f1982740f5e7 ("iov_iter: Convert iterate*() to inline funcs") > Signed-off-by: Omar Sandoval Acked-by: David Howells