From: David Howells <dhowells@redhat.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
kernel-team@fb.com, linux-mm@kvack.org
Subject: Re: [PATCH] iov_iter: fix copy_page_to_iter_nofault()
Date: Mon, 20 Nov 2023 14:04:07 +0000 [thread overview]
Message-ID: <2285536.1700489047@warthog.procyon.org.uk> (raw)
In-Reply-To: <c1616e06b5248013cbbb1881bb4fef85a7a69ccb.1700257019.git.osandov@fb.com>
Omar Sandoval <osandov@osandov.com> wrote:
> From: Omar Sandoval <osandov@fb.com>
>
> The recent conversion to inline functions made two mistakes:
>
> 1. It tries to copy the full amount requested (bytes), not just what's
> available in the kmap'd page (n).
> 2. It's not applying the offset in the first page.
>
> Note that copy_page_to_iter_nofault() is only used by /proc/kcore. This
> was detected by drgn's test suite.
>
> Fixes: f1982740f5e7 ("iov_iter: Convert iterate*() to inline funcs")
> Signed-off-by: Omar Sandoval <osandov@fb.com>
Acked-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2023-11-20 14:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 21:38 Omar Sandoval
2023-11-18 20:25 ` Christian Brauner
2023-11-20 14:04 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2285536.1700489047@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=brauner@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osandov@osandov.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox