From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 684E5C6FD1D for ; Tue, 21 Mar 2023 16:43:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2BE76B007B; Tue, 21 Mar 2023 12:43:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDB106B007E; Tue, 21 Mar 2023 12:43:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA4866B0080; Tue, 21 Mar 2023 12:43:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B7AF96B007B for ; Tue, 21 Mar 2023 12:43:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8156980212 for ; Tue, 21 Mar 2023 16:43:20 +0000 (UTC) X-FDA: 80593475760.23.2D0288D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf04.hostedemail.com (Postfix) with ESMTP id A96D340025 for ; Tue, 21 Mar 2023 16:43:18 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="YHEt7/8H"; spf=none (imf04.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679416998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z+zwblPNJ3OUYOnKk/QBbkl8n+ZHXybiPX0PiQx3oXU=; b=Svc+tpoTowfbk/q56Y/5+4Y7E+Bt/Fb5S6XG8ryPrmz8EjlwVqRXRlSvzKHhW39OLQO0lD Ett8ePxmN9N+Abschbdn0TCKOzuWGDH3riPEaj9ACxWgaBc7tl0eiJv1d7MxPD5ojY33+u qm/cCy/AhNzqSAC7Hy5H7uVNsDWIfk4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b="YHEt7/8H"; spf=none (imf04.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679416998; a=rsa-sha256; cv=none; b=2YYMk9I5Of2sigt7CZme6j4AzAHj2/t1Ec/IPznnQB3Kwfv3UFaFoTdEj2fqKeGX6gai4j +nH30FgqRX76iw7NMz8MeVfCbv09cJdz1GBODjNsz98GpAFkydBzzY7XF+AuY2sgI2ZtcJ lF86r24TGu2cIrOsrvE6MvezcCek5VU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=Z+zwblPNJ3OUYOnKk/QBbkl8n+ZHXybiPX0PiQx3oXU=; b=YHEt7/8HVk+HXyQdyu4UIyshX9 24kbrya3mv8KOjHy2Mvq9WjJcPISA8U2TMNhAe71LJOCWB2xxAXOlT8a7A0sB0w1B06p8iCOAv+rL 0d8pFv2ojSaI9VUu343HerXQVkP2UWXXTYjzWFROZzX2elqgRzqjHVtLuN4zllt6HH2UQrFGl+iY0 7kGmtienyRFdp+fwP4KMvaE5qlhe7hqKwQj0G5fgN5END84mQjluWFCBg6A+13Yk6XimfuLf/Cq0D GTDq/tUG4bI9++AFKsUWh2fAla691b9RQlx0W0uP24zEaKTuqhChjmaJQSEr9/MnrQixHA4mk1fFc Iv/73d0Q==; Received: from [2601:1c2:980:9ec0::21b4] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1pef4j-00D6ty-1A; Tue, 21 Mar 2023 16:43:05 +0000 Message-ID: <227fdc99-b54a-eeb0-c4e6-21ed92731240@infradead.org> Date: Tue, 21 Mar 2023 09:43:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] mm/slab: Fix undefined init_cache_node_node() for NUMA and !SMP Content-Language: en-US To: Matthew Wilcox , Geert Uytterhoeven Cc: Dave Hansen , Arnd Bergmann , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, John Paul Adrian Glaubitz , linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org References: <67261c513706241d479b8b4cf46eb4e6fb0417ba.1679387262.git.geert+renesas@glider.be> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 1fg5e5m65kyfbgwiyoudmzrmjzkqqoy3 X-Rspamd-Queue-Id: A96D340025 X-HE-Tag: 1679416998-141169 X-HE-Meta: U2FsdGVkX1+OLmnzZwctZFZj6FyrLDWPg/T2F1HKOgfHvkBPhxHi1OsyHdHILVtYt0L6MUXFwuKs/n5aHpsyHu3fV5Tvfhoi5ZjtC+iigapLQc0fg33iOhXZtx64CcXLQrBpB/n9mkPBUJ9pOZtTn8mcqfMKftn8C0jbZ71jjPWN5VRfYrTYrWA7HzAlvPsFHuszP4nUJUqIZqr6AqkR36p2VtHkcxfHHeZ30vFJuCOgbv3j2QviawfgusCX7VIXZbb6JDTEceZd4HPPSXDAdm9Fo4dg6SjTX8XO+QTKuL46sfdW4pOd270OXZXyKJAozwwqD9sBNgAn2mE75Yf8DI2p6gvB3RmxgXfhgvz5jMt7elqKF58uWeDtTW3X0Dx3mP7As+c1McqRxksaY0/IRKCXRQ7gnm1ufUt9IpiaMkAibGruZUXHf69ot+CuUu0F37XdaY7+e4hBRt3I4whUe+PAGD/sdIlprthJrIVUmMLA2sxmDBTSr/jwuJQfGjn1FN9UaaKlA2yfnbXIbK9o/SDbGHoPX2I59R3glT53w505tQ24Q6sHgLR2pVh5tqHaz6bhJt7JmtE4qBZGkTxzpEl6yW+rUKaPqWt4EPS/ocEyJg98nskR+Yv979lR/RXLu4ERjDb0W7sgp6otJi9ROC1b2nl5I64VBrhQANhi/8r7SZm/QiRuLFFotdvaVVDJPzuQKWBWh1Vbatb8Z2IxevbiUKtSDarAa1uE8MI9DMCe1yoyYa2tdfkI2KbKUDd2mFMqKatoAjx5WEJxfAyvCglDl5XEUYqmCPT7UKruZzEZuiQMfBHeePgMHXU7nNRE3W+5U9NpOFLq1Y32bVi4ThyZadWEjMYT1v1OeAKa3byg6Xg4uRH1qZizg3FdK1AD/471XYghYBwU6J9pIz/3C+jPB4x+hYmPAYtSCEqSOum/ljkE9Zs1W9VmUKowdpRbGOhLfndPD0vToWdqrJX hh8WRUyw XmFGv5TAQzyXBg8FbxqdIycCsJpCF3o8pgSzLNLYVTNleDjp7xFkt1RIBazm8kSwzrm5KLag172A3fQsLq8ZVq+Zk8jwxS0EEPnZogfhrnu4uEHKbgCK10J5xYNgEbmUd316xvBtAvvkD35XT8W4HqbJcD2jjXllSWuk99q468JrtClOqicVsrXD/UrwN9WxBOc+rtK+yecuNWzyWCxsEwZuxwDKqOj0CF6eHFp+vMuoT8Astsi4tf0alhA9KkPNID6o+U/sPb5xnE/rnICf+olaYaEQzayTdS+I2ejwDUAETUY87bXvzkhau993oLJ0K2YsvKECnwP6DmNgoddnKagz5J8YZH68JVpQYMW0lmo1lICgLnmglVbEo3SgDm4cRF93Hm9Ig92bLRMo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/21/23 09:40, Matthew Wilcox wrote: > On Tue, Mar 21, 2023 at 09:30:59AM +0100, Geert Uytterhoeven wrote: >> -#if (defined(CONFIG_NUMA) && defined(CONFIG_MEMORY_HOTPLUG)) || defined(CONFIG_SMP) >> +#if defined(CONFIG_NUMA) || defined(CONFIG_SMP) > > I'm amused by the thought of CONFIG_NUMA without CONFIG_SMP. > Is it possible to have one node with memory and a single CPU, then > another node with memory and no CPU? More likely 1 with CPU+memory, 1 with memory only. I've been told that that are also I/O-only nodes. -- ~Randy