From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF9F9C27C65 for ; Tue, 11 Jun 2024 16:04:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 881ED6B007B; Tue, 11 Jun 2024 12:04:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 82FE06B0095; Tue, 11 Jun 2024 12:04:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D0B16B0096; Tue, 11 Jun 2024 12:04:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4B5616B007B for ; Tue, 11 Jun 2024 12:04:39 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A93491C0312 for ; Tue, 11 Jun 2024 16:04:38 +0000 (UTC) X-FDA: 82219080636.10.648E467 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by imf22.hostedemail.com (Postfix) with ESMTP id A2BB4C001E for ; Tue, 11 Jun 2024 16:04:35 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cutxqhmz; spf=pass (imf22.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718121875; a=rsa-sha256; cv=none; b=buA45P4bfWJHaRx1IHeXVJIYH8Yp4X27zYSKa8LQA8F7opcdG0w3y0gmZUPt0ZjkKqCTqq 5UIyyHs04OebzMvWoeOxQR19OUn4I0wU7Mr2e2mDjhayJYUy2IGpY4dq/Qggz+kV0e8Eff RgltuQhgwCB01ffkUcuPScuODD6Hv4M= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Cutxqhmz; spf=pass (imf22.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718121875; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6rnw1FQKN289UDS4/w5kh1z+KMtll11fpDUmcXvCr+s=; b=3/vC7qMxq8zRKWAppdipTVtymdr5JZlMDAm96SD0xhAzGrOcU5BtsHKuQxwBfpOI64it+0 6Xa8NBLxidCFBwGnJLbo3812gXjPhKunT9FpTCusFQIjsn84GElTkqDakYAyWhRdQq70JU ks/lOsWQxr1toa/zVoSperTXwubNnXg= Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4217d808034so24991815e9.3 for ; Tue, 11 Jun 2024 09:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718121874; x=1718726674; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6rnw1FQKN289UDS4/w5kh1z+KMtll11fpDUmcXvCr+s=; b=CutxqhmzG8MTcLv8YLyCiI367DSwF9Ql+MK90XT3D1AqjbE9TXRxHtvndr9zFiIIW9 4rDUBqs22+L8wJXtUiupkvoppMFGLv85a3/N1hl6bLa81ZpJieTFzqH65lO5mNclOAxI Oh7fKqORJgOS1Cpz8FFRyhmhrXFkIbNq8qRrGQoKSKoI/8mX2dVv6DBkBpOkvKSQrwu+ fVk0ShhH4qfPocghFzxD3EUwPlhh4EJG03eSTOvEzrRGxolC338DKidQvgZff1WRrnTr P55iglOmScOV0zsMWQSJ0f1yIVLfCDg9yHPyqfec3flOR903ygGpJ7U16wHfWZ/mgXdR BeZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718121874; x=1718726674; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6rnw1FQKN289UDS4/w5kh1z+KMtll11fpDUmcXvCr+s=; b=BtJEZ2d/Vuid8OuTYcjqSH8hnJSmBj6Kjf2Kj/3fwob6Z3w8scW9g9GDyeAqJiP3Me QjxIgwXrS9WpxYF+ckg6i7thYVZCYpNegPcdYG6qoAXiqVcZV17LrTKRJvz8DinBLzJF QiXDxs4m7axplnlHaGn94ceZLYiVeW8Vld8aDrElFrqTS2TwO3BZ+lMGmz3n8p/lJ0af Wipvb+VPK/GaiFmBRKqLs2g/PN5ehmEp2+nARt/CrwWCOt8upjvy/4khsi8NqQuN5XGq h4MLZr/Loy44xIlVhwwLiEFiMRe0CVk9TX7cAuQjUGLMLuGCcRin48BKDjVftsUSmfiA bO5Q== X-Forwarded-Encrypted: i=1; AJvYcCXSKq5zL9GNOnk0+V5oI16zUMjo7HiDNo5AbfRiAo1R3sV4ncw30cf2iFAe+/Mb/ap8HyZPQa+DqKBY5+OC1ojIHkk= X-Gm-Message-State: AOJu0YxkazzbXRMWBd0uQVXi4E3qfpE07NFMDNVrwxXJ3eeOd//ayLd1 xp9ZL+ndGqliy37spdFy+jwH0V96v+tq/XP+hUwn7NfoilTlNGjo8dixCCxx X-Google-Smtp-Source: AGHT+IHjS1MZMWIZVi7cvT2T/22zRVp9zjGEaMix5oaKL59nfhtDU6VerkK9JUfuY/0DOicCbpydlw== X-Received: by 2002:a17:906:155b:b0:a6f:2a7c:b511 with SMTP id a640c23a62f3a-a6f2a7cb5cbmr257590466b.51.1718121552767; Tue, 11 Jun 2024 08:59:12 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:eb:d0d0:c7fd:c82c? ([2620:10d:c092:500::7:57b4]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f1244180bsm382816266b.116.2024.06.11.08.59.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 08:59:12 -0700 (PDT) Message-ID: <227d931f-18b8-48d5-8306-64940fcf1425@gmail.com> Date: Tue, 11 Jun 2024 16:59:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: Do not start/end writeback for pages stored in zswap To: Chengming Zhou , akpm@linux-foundation.org Cc: willy@infradead.org, hannes@cmpxchg.org, yosryahmed@google.com, nphamcs@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Shakeel Butt References: <20240610143037.812955-1-usamaarif642@gmail.com> <5d051998-015c-4da4-83f0-1b4fb9009c68@linux.dev> Content-Language: en-US From: Usama Arif In-Reply-To: <5d051998-015c-4da4-83f0-1b4fb9009c68@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9ujeswao1ktdwn63j4h5shy9jb3ubp7t X-Rspamd-Queue-Id: A2BB4C001E X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1718121875-892372 X-HE-Meta: U2FsdGVkX18jCsp0m/AaqVnzP9XIeFUII/8K6K0BqcCQQViuquISvxRI5+y8/gsfR1quxgZB0wfbPGlEt7VtKaLbDPHV88FeWiEoQ46a5vNo1loGFSctL+LjZ435iJFoqJCIUw8qB14/8qXh9xzd+DghUiKhUF/wZU2b5N2jN3rLEaZKxQFnZNNw4nfrId7PrIJpudvLSijC9E7SrOYo4iGPgQvFz6GFqTH8x5MvweCifIj9wltaGMmfqYACcsDfzFNV3yCFZeIAgfcL6T8K+72Qsd0SRyr1ltOjk4HA+3OlilTd7XGg8YYsc0JItSTk0akQh5LH/79Ehjs4U/RBEwRO15lSur26ub8yiEAvA7LEWpUsayHxH9E3UvusyTEjRYkOiTPF7uiUnIJ2NqU/FvZtuFFCLK2I63fRaBAdLcFgIc4xBoPnrU1ys8vC25rnaj48tICq4eHoMVuJJuWpYg0C5Sy9bjLSANmAtE3iG6IRsn8wE3HPOete9O4EJYEPNZszh2YlgLK61GHKWr1HclYO/7Pek6fFeUfFHABkfSEDZaLidrsElaZiZGThyncgX0JDY9W80bcZqFWcIF2c6YENT6kYJTDxNFrg8TSWOCNLCgKSfui7EG+4err2QnBY77IbHZ8jflKtS7bh11pE2H+ZL7U3MnhwaVOOpJGjyejztWZEcyg6awnUYhdSTlVQOJDC87zEI87TpM43lT35JxYW9FXTsjPHy/Jr1OlbUZr6NNq8TWJboszXJ3Y+dLCz7PH9QBZdCZrL0J8PGRrHiMAiiMhKjKeZb090j9z2po8E2jE5+6rcZkr8TNM4/4cQoPtpcC46EcsQeIMpJ1aw12LBOA3GpfsE55SFd8AKkrqESrB2TPAyo/x9POPUyT41oFh9F0AoN8MGJKJmLm5k6/ipqc0vn9H7JrBGagc22Ad89+zRdNmTMM4pCsZQ7jySwGhunXn3BYo78gDE0vv tCpo2Ys6 rCz8fl/fwktR8tgeXMsGR+4B5WgaaoEVEn43IVL7vTXZMjnts+GP+cUHXNtpAcwC2IAIvvrBbwxr59XnzGlbtfQpVpvwhQmZh/cBa9m3SJ6JZnulx7fnOvhSyvZTckWVySbfLu5kWB/p9BeqFNN+GaHdPr4XXSbbKqK2Yvu2AL0qL+/g2GXtLU4bjqBXGrNBBpoo9fZhNuecxNBr79tR/q9M+8x56ubN0r/ANZ486Y02ddxg113Vy9AASTjxhtOhjWk8WEHDTN4Lk+dHv2hHkZ39g0QEA5SIbxRxFhZsfcoNjasVGuhIvixYco+yOTkXMSRhYkoXnleA5T1Vs0enh1oqzPhx/nZ0fUxDB8fOPv5fhQiITkmwuWP3dZb2xiR0uWB1zM+XukpFgby3+oZ48S7Pl/DloPVQOcCRlBSNP5NkwnE76N5mSg71IgK5rAY2c2qdHT63x7n6GGq1ZpwWu3UKfDkyM0B4CxJncsQWbiav9NGCNeRSz6QdMpcZ+5+nJDpJNGlcwQSFwgh01iew1GPm+R/XBlFBH4a0vb16LwSyrlS9Tz+3RgkLavQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000058, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/06/2024 10:53, Chengming Zhou wrote: > On 2024/6/10 22:30, Usama Arif wrote: >> start/end writeback combination incorrectly increments NR_WRITTEN >> counter, eventhough the pages aren't written to disk. Pages successfully >> stored in zswap should just unlock folio and return from writepage. >> >> Signed-off-by: Usama Arif > Looks good to me, thanks. > > Reviewed-by: Chengming Zhou Fororgot to add: Suggested-by: Matthew Wilcox (Oracle) > >> --- >> mm/page_io.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/mm/page_io.c b/mm/page_io.c >> index a360857cf75d..501784d79977 100644 >> --- a/mm/page_io.c >> +++ b/mm/page_io.c >> @@ -196,9 +196,7 @@ int swap_writepage(struct page *page, struct writeback_control *wbc) >> return ret; >> } >> if (zswap_store(folio)) { >> - folio_start_writeback(folio); >> folio_unlock(folio); >> - folio_end_writeback(folio); >> return 0; >> } >> if (!mem_cgroup_zswap_writeback_enabled(folio_memcg(folio))) {