From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC45C4332F for ; Mon, 30 Oct 2023 17:18:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E4ECC6B0255; Mon, 30 Oct 2023 13:18:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DFE636B0256; Mon, 30 Oct 2023 13:18:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6966B0257; Mon, 30 Oct 2023 13:18:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id BBE5D6B0255 for ; Mon, 30 Oct 2023 13:18:41 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9342CA0866 for ; Mon, 30 Oct 2023 17:18:41 +0000 (UTC) X-FDA: 81402787242.10.65225D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 2549780011 for ; Mon, 30 Oct 2023 17:18:38 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V005a3pA; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698686319; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rk1z/nbke87TeFl+NzbMTW3BKeJ5hl7Q8glGeyBEAiE=; b=noyE536WkTZAChKe1BZZUXarRMoRBtBtMMDbuP+Anm0Yhf45ZbKEDvFANJZTAWTvcWMeWn uQhln3xmLDS3bKVrSyMXjBT+3wPQKhmpU6zh2I2cKafu71yDGHkwQYB5TRpfD9hdksgDf/ 4m8z/6ZA9+3dSUlzzzL8c5HYK70knPw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=V005a3pA; spf=pass (imf02.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698686319; a=rsa-sha256; cv=none; b=B9e+PzqKWOTRY5wIC3PkHyz4/JdVDqQ7UJbcqsTUhusUJm6doZb7xXub2+cV7mV2pVHb2A SoMjKUDohdti6OPGgc2B1g65c/h3lHhIcbbM2u1FqeHedizSYKZjpInF/VIhqOTn+Sukcr m1OVX9055Xu1kplhW8BRlpRzz/tBgvo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698686318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Rk1z/nbke87TeFl+NzbMTW3BKeJ5hl7Q8glGeyBEAiE=; b=V005a3pA+/KQ921ND+eANYyZKRw+vIVcRSlZnPmhssp3yne9N5xAdSMR2kGxwaToOPJm3i FwV6EAarRT5UKZyJnlP245aHsHBmUB37TQZ3EhSu7rMo2yGt5hrcCI4qo+K1zSbCHsePSy 5JPgtpGrd/q5rncCXNVW4HvGzJEMnG0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-0CA84tvGOOOAD9WZoLG4KA-1; Mon, 30 Oct 2023 13:18:36 -0400 X-MC-Unique: 0CA84tvGOOOAD9WZoLG4KA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4083a670d25so35351075e9.0 for ; Mon, 30 Oct 2023 10:18:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698686315; x=1699291115; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rk1z/nbke87TeFl+NzbMTW3BKeJ5hl7Q8glGeyBEAiE=; b=gHhinr0gh/YhRSiWQ6XlEPQvDWqgTXIT/P4cNw05wCTW2MHw/s4d4Y6SZFWLC5XyJp xR6KygrrVkiHgRLv7k6567GGkmoOG+JeGjGlzDWWfRxNq4i6mMoOgwARo0YQDNYjOTlg xOUKT1966fgrGkSokqtj6xssdKb1R9WPt6QapCst7OCbLb4pxveI79LSRU/CV+01xMRA 8B35mVrG5kFNNz3o5+YsZDAO6K4/H7PRSpXsE5gkqlnrAjdFMkxexXcZG5gV43BTFyP1 WVB+fWJcFru65klccOPni9WgZqz8Sgt/iR/o/kp3puyp8Q8hPvBmviUoEZ9xTzJ6hW41 lO0A== X-Gm-Message-State: AOJu0YzSltNC9u4Dufk4rhg+00rCnSkzxN69AyeDayNxWx182Y/dJArZ PWvFIRGuvXliBBpuR22bIEMPt0iTa6g/xDH6ku0KXy/QOnktWG9pDP3IcOH1TO8swJGLHGao3Qs 9HSDZoM9EFqA= X-Received: by 2002:a05:600c:3512:b0:408:3e7a:82ea with SMTP id h18-20020a05600c351200b004083e7a82eamr9347573wmq.1.1698686315460; Mon, 30 Oct 2023 10:18:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2IYd31Kg1xsjAW7zrsQp03VV1LrLjkoWwzBfM1QTMJAHwovsXW/3FoijWAFrYv3Vz5FidRg== X-Received: by 2002:a05:600c:3512:b0:408:3e7a:82ea with SMTP id h18-20020a05600c351200b004083e7a82eamr9347545wmq.1.1698686315114; Mon, 30 Oct 2023 10:18:35 -0700 (PDT) Received: from [192.168.1.174] ([151.81.68.207]) by smtp.googlemail.com with ESMTPSA id l16-20020adffe90000000b003198a9d758dsm4171497wrr.78.2023.10.30.10.18.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 10:18:34 -0700 (PDT) Message-ID: <22789e20-1a4a-48af-99ad-3e88c18dd231@redhat.com> Date: Mon, 30 Oct 2023 18:18:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 11/35] KVM: Drop .on_unlock() mmu_notifier hook To: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-12-seanjc@google.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: <20231027182217.3615211-12-seanjc@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2549780011 X-Rspam-User: X-Stat-Signature: zi7ebeg8mrb4zhgic6k4ccn658icnhm8 X-Rspamd-Server: rspam01 X-HE-Tag: 1698686318-673621 X-HE-Meta: U2FsdGVkX1+5dTn/3wWnHAhRyjBjVjnuUQ4F0n6E0H9Ydi4mqP1olS2mZuploHk5gT3J9UWKkM1KLoPUGbV5NLtX57Tn6eMwLhbhpe0BdREKvjJIBUGMDtxQg511MF3IUz55sb21nb6HlbuUv/o94iM3rE3o4i0khMy3WwzSe/AVNcF9rJUjIpF06xPlcVd3YV2Fl26xdt3DuRcqiY5BJdk2DW5mvDxPgApMaG1gFdUsHXP2r+LgwTeCZp2u3fx+6rxGX3QRxL0xZhRPDH8VwCm5N5htDfAyJXraIYD6iAYmS6VephG/FeA/k3Px2amesYtQkyQ6MWAtKbSXeeIhtNt+OSFPP56Quhe0e4e/my38uV4FwWClGrd8rcjizMsHcy18xZU8ftpG5ZMehco8ozXX6gwayb/pbEPh0tvyqsB3J6tQfHijnjihlUH9fnH6xy8iRG6RUx1eqi7u8EC0nOSuS8n9JwxHkDs8SCcTKWT0JEgLwNVS1pD01w9FEnJz0TWgtF1ss74b7WxwR2BpgL19A7GvLV4Fu13K72zksvKNfdqKdnse+l5cONKx0kriOC9yVuLCleL1QdWUX69chONHBr1Mqs+7gVRwRzgSV8FvFQuoo/961MD4U7kuZJpFE+xlf2XHI0PSRrKAIFMRav9SP5rIKROzjehKDhYiuwCvLsplfYuovVUuuufd9w++g8ihVwPB6tEA3dxgEvWrQgBOatsINXOVjX/jc49X7W3955KTHTkdo6F3/xjpB8tM1QNf1/tzp61r4GmhL/lRBkbmiFlFH7ukGZ+ihXieTZtcKfaIjCZ3cgcpq+RNGSpcOj0qu9IBv6slwGSTJog1sSLnoJaVfMHXIBld3EUYILtuLC/Lz74sdhXYd8KOhtCZgvZdVbrNDUeHdJOscN493gR0+sUuc8PoTZGg65kS5nXY8frcw4rk71Dd1gsieunDUWCdrV4EDnDpgS75IWB QudCGSYS O8MjV1WpdBdAonYunzTdo+KDggqS+G2G+qbCyCpDSDylmPcCjyKiWmFwCM7YOtFXe0f6nOQhyKHitm6Wx5j6MXkr4cHjm+rnm/7jW2GokoXMXZh9v0FlPWwW6kMz7mTNXuvQcsVCyfxtKUHDsLdy7twl1Mxr2DXAboUdYoOyHCl1TJoIl4AqvL6eNX7n1zFHirf86Kf0oPHZhOxIYLqmO2Wft7AQIx2ODLpjxSDjrSv2AQyPdFqrOZRj/J71ajUKw+eJzptrN9eeiJOzSIKY7Q6oXKdWk6J+8XlmPACqU534feN7jjfENQ9go2ZCDneUm2U6c3Xd26q6TES/mp7Gz7lwW+uTzvV4gn8zlCWnF/NtSWOAUpZ5BOFmMc5ARKPIBuzUrIvGVYs0l8PVbIPTnC+JxUNV+Kwh6IY+5sUklKCe3cK9EhuIsjgFt3N+rT5Utw6rFwc4saAtkfEAAHOzVVxnfSQA9adeiz1MdxkJUNwJNI0ccZraYJTFQb3nlwxVs7z3FOz3+/Dkp+skQ2Kjb7fYXY8FyrCOYBXw8B8UB+BnsBDSOFipUMNH4KKlq/PbGj7PcFHW/Lc8CHjewcrMYAHwr19t28UnHQKWC1De74ODutdPQaLx4T3m3ZdrpgaR5OFSyT6h7lwivM9P0oqQQi+imJy3uaJA/RiBJo72JZgRG84Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/23 20:21, Sean Christopherson wrote: > Drop the .on_unlock() mmu_notifer hook now that it's no longer used for > notifying arch code that memory has been reclaimed. Adding .on_unlock() > and invoking it *after* dropping mmu_lock was a terrible idea, as doing so > resulted in .on_lock() and .on_unlock() having divergent and asymmetric > behavior, and set future developers up for failure, i.e. all but asked for > bugs where KVM relied on using .on_unlock() to try to run a callback while > holding mmu_lock. > > Opportunistically add a lockdep assertion in kvm_mmu_invalidate_end() to > guard against future bugs of this nature. This is what David suggested to do in patch 3, FWIW. Reviewed-by: Paolo Bonzini Paolo > Reported-by: Isaku Yamahata > Link: https://lore.kernel.org/all/20230802203119.GB2021422@ls.amr.corp.intel.com > Signed-off-by: Sean Christopherson > ---