From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D10AC6FD1D for ; Tue, 21 Mar 2023 14:37:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DD856B0074; Tue, 21 Mar 2023 10:37:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18F876B0078; Tue, 21 Mar 2023 10:37:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0565F6B007B; Tue, 21 Mar 2023 10:37:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EADFB6B0074 for ; Tue, 21 Mar 2023 10:37:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 750AF141489 for ; Tue, 21 Mar 2023 14:37:17 +0000 (UTC) X-FDA: 80593158114.25.6F4C2E2 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf17.hostedemail.com (Postfix) with ESMTP id B03C24000C for ; Tue, 21 Mar 2023 14:37:14 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VGvMDHg7; spf=pass (imf17.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679409434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=iHEqN7BarmB0XfV9NF5gycuaqpBq0s3WoFUcLxi5+4k=; b=62LrV9UjD7gFDC3o55UTg5pnu2CjvvHCBmlNPqLU4/n/tJ6Oi2hkFD8cp1GSyGp87CH1Kd pcENW3lAAm9vPveBrPm76cXB/N/bbnjH30TbJ471IsOpV/2xMJC+nUY8V9cmHLh+yAHt6N 0gkmQaEmstzvzzMFh6VwTYLWXJqMV9I= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=VGvMDHg7; spf=pass (imf17.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679409434; a=rsa-sha256; cv=none; b=Meptnu6e+pgvO+fpzw4ej9f5h3+QyNpBIDZQwdpvCPK2aEeE3H0engWojFKbL3GGThGgov cBapbjub/G1tNzGQksJp1z5E8d+Yly3ctYxtrQfiE5SFhYsZTyJ0OTudgA5MfkFnaqSb3j KWn1i7U+c7WqXYvGa8+4z6hiVn67llM= Received: by mail-ed1-f46.google.com with SMTP id eg48so60441449edb.13 for ; Tue, 21 Mar 2023 07:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679409433; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=iHEqN7BarmB0XfV9NF5gycuaqpBq0s3WoFUcLxi5+4k=; b=VGvMDHg7IAZVxzH2gfoNgMSOji5IfjSe5JCEZiAbT7Ro12HxXutcQs3nrUqMrmZaQa YTjVp2EgGLLiDw6JuPaXagf+kufzeJNwYYYLUs0fk7VA/aD/pax06JOC2gsjHDAXPntV cfNRwERJFhpsYBbF/Vwvjh6s34xtgWvWcko31v4S0Oeqwq2N2NzgoJ1Fye42plrr2Ypj nGtABjWvI/3YVwzxii7IzcVFIXGMfK9v4SXSrlFLf1g09Ka+U3qKrVzH5PffZpj3N+5v M/ZbS6B/UiQpB1a392GUZonq7hdTT+iANRtaXP+0pfqFy7Hi88K244RqT7o2MTOOdBxR bEeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679409433; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iHEqN7BarmB0XfV9NF5gycuaqpBq0s3WoFUcLxi5+4k=; b=NJIObAAXrOxjOBdjJKo7I75QvOrd99dNkafU/t4CZZxmHV8z9pC4QVceb0SKJMXHR9 42fNuaLxJljEgvQnHJQr4GJT0pTZ1ixLtN4rvsddenD+xJDN9HKcdrVuKweb6HoDtV3w iWKQjSv6OW8hOgK47nSfsAGNKtLltrQDJ2sxxpftBtEr5sXO3PsAWEmpPe7ae5DYP6Ur 5s2cGFvo05S/jIDmC0j3j4dUYS+cLPTtz5EanQXdLldjiL4T4O3jOUOJHQw20TMR86XO OqWnT+qyKuZNZtrYVMQ5rwp8PnJckITX5CzJSoWzgkdPVf9K0vrR7WEPo4oQGHubIRmd DjLw== X-Gm-Message-State: AO0yUKXWRUByRl9loM9HYovNOsL9JF56Kyn3/hjHp0QiERLz5zMCSWWF O8BS6BFZvIW++0DriwpBwA== X-Google-Smtp-Source: AK7set/uV6swtI6Cha2IBxu6FSeT/CGJESekpZ8We0l6hTyn2lZuhQ5yhr67rv0UD8ZpLfE8F26Xvw== X-Received: by 2002:a17:906:2e8e:b0:933:44ef:e5b5 with SMTP id o14-20020a1709062e8e00b0093344efe5b5mr3716363eji.30.1679409432985; Tue, 21 Mar 2023 07:37:12 -0700 (PDT) Received: from p183 ([46.53.248.97]) by smtp.gmail.com with ESMTPSA id f3-20020a17090624c300b0092a59ee224csm5828944ejb.185.2023.03.21.07.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 07:37:12 -0700 (PDT) Date: Tue, 21 Mar 2023 17:37:10 +0300 From: Alexey Dobriyan To: brauner@kernel.org, frank.li@vivo.com Cc: mcgrof@kernel.org, Alexander Viro , Andrew Morton , Kees Cook , Iurii Zaikin , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Message-ID: <226a6fc1-f6f4-4972-b76e-774094ffb821@p183> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B03C24000C X-Rspam-User: X-Stat-Signature: xkjimmh19yyx5sqmax14gb1r68ogda1d X-HE-Tag: 1679409434-941178 X-HE-Meta: U2FsdGVkX1/pu+gPKLhCgFNxASXDCXMET0BRIfmoIwht0A+t1ZZ1m1c0pEqVrK7CAhun1H6KNZxtNxK8PBCq4Ox6/TyU2FDYCXLt+IVSluVRjI5WPtTHZj8eoPpOU5Bj0RpC2RPMP+NxSLDChWCgS/xmU4Vet2vrvYDoYH1HyM/NnOZXF/3riT9V6D7wgid6Kh4V9fha0U2tfAbPhVa+S5MpCXTVGFo338WVj9jdQ3recVBm7HIUOikcLIU+cA1JVEJtVRDsH6wIZWuGCXrcgBeSBp9jYY1pZiBMcdJCC21bj/iZy+GeyJA6Gd0zXncCDzO/XAMCAfw676IjHzSff4hPvl0YaXkyshPjzNJYIzsHQBb9aarU1yVWjW3rdX5Ay30V4kplKXxMZHUTKTx5ewNHHjYbr4ljRB+sskk97s6AleLs56njBiU2Bsu9fMRe2lJs2Jf3yKRg+QTm3B7dCSpsMnFS+Cob+o0ypfgY+aIZJTSrMUXkkzckH+K0dbmVIJFs2ayoW/Z/UlMbSwKMSfnCSwePbYopC9n59SEio9o2OVERsFM3kQZGjGnPnUXQCN2/HmAOrT8ImiJIibnk4V/eM3vqjD8IDZo8lMaFeqcSaHosebM77jc0/yIO5UWdtQ31pxYADE2d6bEHs/xdtUjGyBM2+vD9mvCehVq6nwFY3nIA6+gLViKYU0o206iSiCx8siwxHG5M/2tEHwx+pxabVPLq2Xohaqw1WpMztnur5fdWaZD7pRXkDYSEYfDg3TNquG0YDCqvwe66S4pxmgIiIryvBUfacMFhh3U/HroSO5bPsQbhSpoC+HpGZ7BIFKvsiYCKZkmp2slAln00gO0hegvZGF0VmmMlLvlXGNOyGAzRSFsWW24Jj3exoAQRImSKIrXkbSmGwA6s6IztvJA2se3CpcBxdQ4MAudO9iK4TsJROPddUhwkIfJGg4hwZbY1R7KCrqxPypiAtzs djNjEhB7 zjO5VCPaWN5BLz5Q58zN7gOz83AN814ehsIV8ZkAHQRUMnbl/4Lj4jfy9C6Ffvo4AKZlAOvfdmjMMcluE53SE7Rh9O9sUSVa8KeLqCxMrf+spz+P4s/bvab00WPhHP8YAALtmr9JxwYtz033zbKjI6LwEDqVa2Sz3vcr6wt48ZUYZW1u291HqCwNhE4JjD3xsvi8VPgP++Dwk0wYHFBGVVUE9V/EMZ2BEgxbA7A3Kixt9ERO7c/e39DrAeHMX4M+aFhyFQGd7wfDkjPhMkLhU3kH0Td78ZI2v+y7FrllH+2zCTOnV9YQwGGSwrgtl1N1AUGX7U0uUD5KDRpVxDNBXGzvr/QWOTNPDfk8pIq0CjPqwmsmchYKkN78BksuFqUWFB8mIFl6aM7UVKbUXZJuztn8VPpe71Hb0sPbMdtzwB8d3BqRawSQUd2uoZC6wGSTGXfrK6g3dXwAKGerlIL/Z9FL2AsHtpRJinN25sWxUjCQLx0EZ+02dCxQWNjFY6NJf0cFW8itqLb/9+kojK2pn8fqUuBRPYZsAwcsgHAeh2PAssf4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > +static struct ctl_table drop_caches_table[] = { > > + { > > + .procname = "drop_caches", > > + .data = &sysctl_drop_caches, > > + .maxlen = sizeof(int), > > + .mode = 0200, > > + .proc_handler = drop_caches_sysctl_handler, > > + .extra1 = SYSCTL_ONE, > > + .extra2 = SYSCTL_FOUR, > > + }, > > + {} > > +}; > > + > > +static int __init drop_cache_init(void) > > +{ > > + register_sysctl_init("vm", drop_caches_table); > > Does this belong under mm/ or fs/? > And is it intended to be moved into a completely separate file? > Feels abit wasteful for 20 lines of code... It is better to keep all sysctls in one preallocated structure for memory reasons: header = kzalloc(sizeof(struct ctl_table_header) + sizeof(struct ctl_node)*nr_entries, GFP_KERNEL_ACCOUNT);