linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Julien Grall <julien.grall@arm.com>,
	Matthew Wilcox <willy@infradead.org>,
	Nadav Amit <namit@vmware.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH v1] xen/balloon: Fix mapping PG_offline pages to user space
Date: Thu, 14 Mar 2019 16:59:50 +0100	[thread overview]
Message-ID: <2268eedd-65f6-4715-792f-702bfca4659c@redhat.com> (raw)
In-Reply-To: <20190314154907.wcwh5ricj6v7p23v@d104.suse.de>

On 14.03.19 16:49, Oscar Salvador wrote:
> On Thu, Mar 14, 2019 at 04:40:25PM +0100, David Hildenbrand wrote:
>> @@ -646,6 +647,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
>>  
>>  	for (i = 0; i < nr_pages; i++) {
>>  		if (pages[i])
>> +			__SetPageOffline(pages[i]);
>>  			balloon_append(pages[i]);
> 
> didn't you forget {} there? ;-)
> 

That's what happens when you stashed the original patch and try to
recreate it quickly from a mail ;)

Thanks!


-- 

Thanks,

David / dhildenb


  reply	other threads:[~2019-03-14 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 15:40 David Hildenbrand
2019-03-14 15:49 ` Oscar Salvador
2019-03-14 15:59   ` David Hildenbrand [this message]
2019-03-14 15:49 ` [Xen-devel] " Jan Beulich
2019-03-14 16:00   ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2268eedd-65f6-4715-792f-702bfca4659c@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=julien.grall@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=namit@vmware.com \
    --cc=osalvador@suse.de \
    --cc=sstabellini@kernel.org \
    --cc=willy@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox