From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3012EC77B7A for ; Wed, 7 Jun 2023 15:12:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8006C900006; Wed, 7 Jun 2023 11:12:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B0E4900005; Wed, 7 Jun 2023 11:12:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 678EC900006; Wed, 7 Jun 2023 11:12:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 59120900005 for ; Wed, 7 Jun 2023 11:12:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 037311202EB for ; Wed, 7 Jun 2023 15:12:35 +0000 (UTC) X-FDA: 80876293512.20.1547A4B Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id B4EB82000B for ; Wed, 7 Jun 2023 15:12:33 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EhCRt46J; spf=pass (imf13.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686150753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K3r/K8HkhE4xuB+jM5Kf0f4GFwH3PwislIM7Zb9RO88=; b=3ueZNiCSFsMMDMm/6uJP6sSRgJNDlyu+zGuS8peOh456dqdDF4FdXvPSrJP9ni5AH1JOFK yuzZiJC6oxnpC3tte6B60/uxePh1ugudLiqZNcnX7ErRBj6zKgXQ4e5rpIcoLwmVc5s8yv h0v793nL+/isvmsCr289aIjoJrbbnwI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686150753; a=rsa-sha256; cv=none; b=LKGqPGWEW0P3TUw6dyPrlg4hGTGLSTNF9tzZ/viIxcsMrS1GaoQrg0RArnqEA8nI0O29aA ETbiyku7kVf6X9GfgfG/zFDcAKQ8+RNkD7u+Y3GyD8H2IUrAnbHskygxPMa0yFCDykyVK1 wrcYgmVECOfxNENCLSuXTN0Ug+4JDTk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EhCRt46J; spf=pass (imf13.hostedemail.com: domain of dhowells@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686150753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K3r/K8HkhE4xuB+jM5Kf0f4GFwH3PwislIM7Zb9RO88=; b=EhCRt46JRjD5+DznBPJtG5OL1MyroA8btrPpxS6UskVQ4ajUhlN7JN6BaVO4KpVhkwu7wf QN7BEcO6KKOiZaGu4s3hNcFmBjW6oXwHTuR3gpUH54amOW58aAL15Ygxq6hcPDVrXcMjqL UVlOJvnpgVrx9pwDDGeMQf7uw7DYkds= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-641-v6-IUeUzMTyM9FIOsecLMw-1; Wed, 07 Jun 2023 11:12:28 -0400 X-MC-Unique: v6-IUeUzMTyM9FIOsecLMw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93FE0848B6F; Wed, 7 Jun 2023 15:03:50 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id C69F82166B25; Wed, 7 Jun 2023 15:03:41 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> To: Tariq Toukan Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2267271.1686150217.1@warthog.procyon.org.uk> Date: Wed, 07 Jun 2023 16:03:37 +0100 Message-ID: <2267272.1686150217@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Rspamd-Queue-Id: B4EB82000B X-Rspam-User: X-Stat-Signature: jinq593j1s9anzrjnuotme4ay1k59cbq X-Rspamd-Server: rspam03 X-HE-Tag: 1686150753-797212 X-HE-Meta: U2FsdGVkX19uiw8l3pfzEv3uCzcMkCF/bHsNy17KOlkZrI1Qwt/Xnh2mcw04LGsQDRz+Q+qW1FhVCzgxuvQ6u9oFLCJp+GkuZ/UkDUgUyeVy0ISQQUhWZci8K616qcYNtEsO6NuPtTGYxqKogZGeH3oqkKp92HIW5Ekkl3WjUdZy+uAXTwLqigMZYzTOd/Fd+cU7y0/UWX0NFGBxo+x3LSPn8BF8gtxZHqkRUwIt+nUshhfocoIIqfMfecTfZ9gWaf3Mmqa65bbe1FTWgxNCog05vC1OPKnn4ntAhT7T1OLfKRr6YAlC+BJB2JUCRolVs0B50HJC6g+n7d8UIKyF4WzONouYvkWe33KKBd9KEJR2d38c6D+4C0d+NNTkHxwnNG66i1SuPPMpmS5TjpqAgdJ6Aty/Qy8M4aGQ9P5ib2ozHud+1QZ+3yuP2K607/WbNEzHrnazAM6BEEhYJddOomo4dkDHHj+y9p8dUMSlLemLQ+syDo48WVTSHtgFqtxT03YdTgC3TQqQDEYawse9pt2fByTovdX1Smdhyto6/swtF4WpwyIn2q37N5c6NpJxQ/4+E5pvuCbqBch8H94YKJdwrs/jBIIAHDXBl6VOqQrhYNv5yHrHASYNo/PwRIBLHT2w4y55mqImO6cWgrzG9oEuPPdr7/iDQuF/FtJNLKblv2ahcTiYEtcWdlKP2y69tYuXfttxY7jB4ycZvYIBWheiuH3FCna6hQz2qtmqPzrGK0tyq5+S70GA/Q6qy9I90QRuROr66YpfL705O7GWIs/4m6b9LBPw/bh8mQljDdohghqOZRpfChXahl+rcmoQ4qNXvpMezRIaUh9kNrLojbw+0y4kzj5UyfQ1hOXq4PtXw1xXwe0K+pj+iP2dljZo7ErJW/DZENu9UHTPIuyH3yDADbvKrAjQ/wZ/i0PvSnO6q5nwahNnvDKRAA7wg9AJPGU9a0reuLUA5HniTlM kMDfCgld Lw7U5TjGCwBrdJ2l8E1PkZimyh1bzbRhgcxspe3eVast6YSQKwjgMkVMOqzT5mm+5Y1CLVQOrSJt3MpGVpPlCBHizxbF0w5sVOEFnj6RroNIF6orI9SsGjhNKskaK9CmjxFVgH8gK7CI8gek7wCejun1iuMnd85jRmhtx/aX3kQ9KffBct2zmffugiuneCupvWRKdCGotNs4k5Sf9WSmRg5FDGyQHq02MP7VsSZ7EAaU+09CZuyC24z2gdFJ70MLFhmcv9yhYbph76L7f2wJeEt7ZsC+wX+cjLf6HF2g8+e28A7U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Tariq Toukan wrote: > My team spotted a new degradation in TLS TX device offload, bisected to this > patch. I presume you're using some hardware (I'm guessing Mellanox?) that can actually do TLS offload? Unfortunately, I don't have any hardware that can do this, so I can't test the tls_device stuff. > From a quick look at the patch, it's not clear to me what's going wrong. > Please let us know of any helpful information that we can provide to help in > the debug. Can you find out what source line this corresponds to? RIP: 0010:skb_splice_from_iter+0x102/0x300 Assuming you're building your own kernel, something like the following might do the trick: echo "RIP: 0010:skb_splice_from_iter+0x102/0x300" | ./scripts/decode_stacktrace.sh /my/built/vmlinux /my/build/tree if you run it in the kernel source tree you're using and substitute the paths to vmlinux and the build tree for modules. David