From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60A67E81E1E for ; Fri, 6 Oct 2023 18:53:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3F978000D; Fri, 6 Oct 2023 14:53:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEF6E80008; Fri, 6 Oct 2023 14:53:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B90608000D; Fri, 6 Oct 2023 14:53:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A5A6C80008 for ; Fri, 6 Oct 2023 14:53:40 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7F035120301 for ; Fri, 6 Oct 2023 18:53:40 +0000 (UTC) X-FDA: 81315935400.01.4528736 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 4C6AF180008 for ; Fri, 6 Oct 2023 18:53:38 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VWZUNfV9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696618418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UW50MvzyQoFy0Y9n7htqlvGtReQShELOcf6kg4n+7v4=; b=insagZ8lqSDBakl5x6IySCMF4Wkkyrs2BYIca/Dv+tjdbo2BdhnZfuLtZkjZyu61z1miF8 XbvpjvxDZ9TiIvbEc2PueTYIosBrPJE8b9PU8F3ByftfLQGaFDSNmPASh9YOyB9j6dcUvF uPTqil4JfBZH/z9z9Voixmv83c9/85k= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VWZUNfV9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696618418; a=rsa-sha256; cv=none; b=oeLNh1f8hMwqsg+zdNfJbe2fGMwwQu5YZ2Ck7QGWy0w75TDfMCHydtRPEU3mwDxcK0jKhF D7hVbKVr9ZfCyHauR4dReEjTvJjydoVUoN0bKGtlFnJdz64EbyhjAmVD5O3aLdAqS8GLBE 7cD51Xp9eqcEHjxr8Uj0NXfDyYx9Q20= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696618417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UW50MvzyQoFy0Y9n7htqlvGtReQShELOcf6kg4n+7v4=; b=VWZUNfV9jJgPWuSH7ZrfxPibgHA/dMnRD4bURUCLmGlVUI5sfj2NoI20G+z/6p3BWF1kZe bsCuwHZmHuIpwbNXLDfjrS8rTJ4KYwswq5aA7Fae+9CYcowRvohXms8OIepYVFMiKPLF0i s1AZl3HW5TviJNMPDRKXLfy0uK4x9y0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-388-kUVhawLVM-mVanJVRNZgZg-1; Fri, 06 Oct 2023 14:53:36 -0400 X-MC-Unique: kUVhawLVM-mVanJVRNZgZg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-327b5f2235aso1775366f8f.1 for ; Fri, 06 Oct 2023 11:53:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696618415; x=1697223215; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UW50MvzyQoFy0Y9n7htqlvGtReQShELOcf6kg4n+7v4=; b=OmNdvBdQ4NUGrwztbwLInI6I4bw7lLusCLRawOCTS3lAW6NmZF3idZYXO3mq2pcTsO nmtug8zsHN1Eo9rKNn2dQIPpTB3kN8Y4gqrHaC2/TPm5O/16yMiFahpyhVBJJZ/GdhxK ri5jfW7p5K4DaVq+kLfZ9Osd0rivHrwUXo5o11I2W9odnd5fELzxlGlk2DzkkD0uJLk3 FeQjfOEA5KelXP01FlHSAVyPpU6ehfzb8zZmkKaLVoGVzLHLg/D2UVbT9/KnABzmkA2E pcWuVrZgfuEXJ+TWBnK+sJK5j7nqcbZFztN5Pen1hyfP4CzL+QBRA9/PAP25GzuTbbcB AEoQ== X-Gm-Message-State: AOJu0Yyej01kxNU3K1aldrY/DwdbWqsjJRr2xw+MxXHs1EXluijnkNnl 9fRbNS636ohmswRYWrcLIOlhwW9cM8+tEDVkR+06oMEEv0xBm5eOrzd2FeV++OeD63OCI9pWmBi oJWh0BRPY/f8= X-Received: by 2002:adf:f692:0:b0:31f:e883:2ffc with SMTP id v18-20020adff692000000b0031fe8832ffcmr7401129wrp.43.1696618415033; Fri, 06 Oct 2023 11:53:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGpqMwEsERFbTQP4/MhAPILilQxV0SuCQcsD/MwMnwwdswb1JRO89mDTE4up485ECSgZoYcFg== X-Received: by 2002:adf:f692:0:b0:31f:e883:2ffc with SMTP id v18-20020adff692000000b0031fe8832ffcmr7401116wrp.43.1696618414601; Fri, 06 Oct 2023 11:53:34 -0700 (PDT) Received: from [192.168.3.108] (p4ff23b7e.dip0.t-ipconnect.de. [79.242.59.126]) by smtp.gmail.com with ESMTPSA id g7-20020a5d5407000000b00327df8fcbd9sm2250805wrv.9.2023.10.06.11.53.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 11:53:34 -0700 (PDT) Message-ID: <225e8018-ef79-5514-a6ce-f5994206efe9@redhat.com> Date: Fri, 6 Oct 2023 20:53:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v4] mm/thp: fix "mm: thp: kill __transhuge_page_enabled()" To: Zach O'Keefe , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Saurabh Singh Sengar , Yang Shi , Matthew Wilcox References: <20230925200110.1979606-1-zokeefe@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230925200110.1979606-1-zokeefe@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 4C6AF180008 X-Stat-Signature: bj4tkzzmyoy3xuon9zg8ykemxfoftusx X-Rspam-User: X-HE-Tag: 1696618418-144025 X-HE-Meta: U2FsdGVkX19YFKEcDucBL/i94WrS5ZncZK9ZhiFsoiXbJ3YarpJQflQhvCp0W8THI4O8q3RRS7STpCDB28QkIdnWe6dcRu36+yTm45iKLQDpIsrb+S4N+YWTv319yFJiF6BAQx9oKeNRvNoMo8/HtbGkCboaTCYNJuJCR7tDAs9RVFSwGH4kAT2oyDHErEsowxYu5cFs9iy9X1S0thiWUSnlde0XhOiNGjkiuX+fyCPOyiV5gSj2jnbS6NHeuR31pgF+FrFN6rvQQ/zG+EhOgAKc5bGsn7bDoI1GYr8uVz3WPWeGnu24BdCpQMASRVHUBlbrIOTIL41CUu12VHmDLYDMnDJHaCJb+Bww6jlU/Stqma34o9qkEe8hiZ1O1Z9UnhAxWt4MfyoBq01qf+LsJ8UlBsJG9B2TckpyStSeuXiKBGheJQKbJyL05m8VeVDu5oKHhLJbhVjiDVsBHwtsYNvqGdaH16UhHEQ+Fs0vnkqgwV7DVeuw5Q8hNEXv4d5oGIqsCVMvfUu+gqIg82KWyg/+24hxt0Kl9hv5m4aCklmnV2SzD5U9IEBmbc+hDCL8sYm6qDFRY9U18jjT2FlEWG9bqQBd/HWo2pPbh0xp3A8IYMKBOALGbcZguD0a27nAgfAiUHtnAysFKl22WfShXNBBF5abQKqdTTqWZUQpVmigfiJ2++VusiVQj8OQXJYBpvX90OGqExhZoQBaprpoXlBFu+/7xIwwPLD7aL8GxfLORYxZwMbxIlfJ+klnAklAMnHv0MG3Jgus40pIu1xSsUzM3dGvCs+fGmpzHLmpL4+k3tCVu0wikFVTX07s+wzw4VEEwxj8gL7kFV+REBzkzRvI0oxxdcI23BHbDm4EvsWzQa3BUZGJUFa7uGJOZt5OVklAMR8qjPXgmrrWJuyqi+pigujUEtFZ2WeYHNfz7xox+OvS8gGaFxgJbD2MxTOMFSP/zSYEjd5L/XX4+u8 x9anJvWa 6sWcI2uqRWNUSPrCVMW9pwD9bxee7gb68nKtABxcHONMzvsWhIMH6VrEA/55iYgZbRiZwKrU5JC9B97fbKfCBs6urq1t0/P2gmUcwfeTgnpV8v3mUKNZE/qvUran4ViQArig57SGWFYJLmf5eBLFRdCcGbVxEXtg4e0b9RZDtWdAhRL3JtZxpYKMZ9AhpNNodVFvciWRgLiFluEsuMDfCut0wiXDoXn/2PUQfGd1TzldB1jYjhW8isN0SJx1KS8V8u/LXRI8HTl32G6GZwIeLYxScir0m8CIx9jKy7UOUv1tedqjgJk888aihBQg2NhpT6Hil4YLeMs9cCLhckGfo2zIYn3COMDBzzMTZfv2J6K/nhGJ9CQOLgblyJxxkYSMn2qKak+Gpnluy+XZ19t1APUYM6ELvrhpGRqYNpCDOoAoat3CxxWpZS1xltbre5z5wS5e2xf5nVH4ZoeaEKl9itjsANlWbBO66iG7iB3pFcKrMZwmD6oxBcPvYiEJlRX9tBJWQCl9DH47iJQd8F5mxmPPeluzecaiiLwmaFT4B+6u4YxtB9mg4m6qG71bob0I1JfXTDHu7PsHWU87U5w/8mbgnMg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.09.23 22:01, Zach O'Keefe wrote: > The 6.0 commits: > > commit 9fec51689ff6 ("mm: thp: kill transparent_hugepage_active()") > commit 7da4e2cb8b1f ("mm: thp: kill __transhuge_page_enabled()") > > merged "can we have THPs in this VMA?" logic that was previously done > separately by fault-path, khugepaged, and smaps "THPeligible" checks. > > During the process, the semantics of the fault path check changed in two > ways: > > 1) A VM_NO_KHUGEPAGED check was introduced (also added to smaps path). > 2) We no longer checked if non-anonymous memory had a vm_ops->huge_fault > handler that could satisfy the fault. Previously, this check had been > done in create_huge_pud() and create_huge_pmd() routines, but after > the changes, we never reach those routines. > > During the review of the above commits, it was determined that in-tree > users weren't affected by the change; most notably, since the only relevant > user (in terms of THP) of VM_MIXEDMAP or ->huge_fault is DAX, which is > explicitly approved early in approval logic. However, this was a bad > assumption to make as it assumes the only reason to support ->huge_fault > was for DAX (which is not true in general). > > Remove the VM_NO_KHUGEPAGED check when not in collapse path and give > any ->huge_fault handler a chance to handle the fault. Note that we > don't validate the file mode or mapping alignment, which is consistent > with the behavior before the aforementioned commits. > > Fixes: 7da4e2cb8b1f ("mm: thp: kill __transhuge_page_enabled()") > Reported-by: Saurabh Singh Sengar > Signed-off-by: Zach O'Keefe > Cc: Yang Shi > Cc: Matthew Wilcox > Cc: David Hildenbrand > --- > I've updated the changelog to reflect discussions in [1] -- leaving > ack to David / Matthew on whether to take the patch. Works for me. Acked-by: David Hildenbrand -- Cheers, David / dhildenb