From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8010C4332F for ; Wed, 23 Nov 2022 09:29:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CB396B0071; Wed, 23 Nov 2022 04:29:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67AB06B0073; Wed, 23 Nov 2022 04:29:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5423F6B0074; Wed, 23 Nov 2022 04:29:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 471C06B0071 for ; Wed, 23 Nov 2022 04:29:21 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 169BDC0A18 for ; Wed, 23 Nov 2022 09:29:21 +0000 (UTC) X-FDA: 80164183722.30.3CC9B1C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 8FED214000C for ; Wed, 23 Nov 2022 09:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669195759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UK8W/f6JX0V0buNKgwaW7N3X4d6jcuFhKnmILB+4f5c=; b=O2BTo7Rs9Ha6Fp+xIsWngr4xAQZo1QyDiRGVtrWrkziWtc4pKYa6bmnhPspgbpjnkOU0Q2 ZjgFR5Fj26Km1UezGA69lKOAKgdHdMK2AzbYXdgJy6CcMhVomCUbjvgYX4LxICBBXq+kai zfu6s0OzfDdm5M+NUQgCuyZ5EJhbyJo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-120-0p3CyYj7PbunpwmaDWuI6w-1; Wed, 23 Nov 2022 04:29:18 -0500 X-MC-Unique: 0p3CyYj7PbunpwmaDWuI6w-1 Received: by mail-wm1-f69.google.com with SMTP id v125-20020a1cac83000000b003cfa148576dso9374675wme.3 for ; Wed, 23 Nov 2022 01:29:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UK8W/f6JX0V0buNKgwaW7N3X4d6jcuFhKnmILB+4f5c=; b=sdgh9wJQdYuy141oXvEoLHoalg+9i7HmZCHBRtN56nMv8MvmKAy0vT128/rd61r18I mU5ESoU6XBVW0P1Zc2Y53rVPs0D4VLQC8Gld96ZOlPOfuP7HTWqgnOBmm18d4QrJ/+hO Nhe2NEPHYICKf9eSFr+wpNvInWt1lCl9HBfy1d8GdSSLNYrbYAhVIbrWUgwEjiEJcPeq Bh6Ab2O8V+PEwxf3/hXAaSR9H73uKsGDiPvRDa+YPlEsF9HHVoA88OB2JbKb3aX/cumb 8KXm7epAYCgDsafPaSNwh6H9NK1O3XLUVqs1FwvCrDcPP4qTrRIOAXapnfbw/kkts7sK TiRQ== X-Gm-Message-State: ANoB5plmKLSIqL5fqHx2SYQRXVsX5T4rJuYV+h8+DPlX311gT5u7596S gJORCL2kVvde9bE40+twS76cVe7Ip8usIA//h2vm/BD1PsgNxm9+Xz6KapB3w+ozvYQAyVIuPzP 2cWobTEMVAbU= X-Received: by 2002:a05:600c:2213:b0:3cf:a6eb:3290 with SMTP id z19-20020a05600c221300b003cfa6eb3290mr12096286wml.116.1669195757286; Wed, 23 Nov 2022 01:29:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf7/opCgmSRLhbgLaahs3dmcIF2YGbvr3mHchJssUcljoxsHHnw+Uj8AEtvdzDFHmHTRUpp1JQ== X-Received: by 2002:a05:600c:2213:b0:3cf:a6eb:3290 with SMTP id z19-20020a05600c221300b003cfa6eb3290mr12096266wml.116.1669195756960; Wed, 23 Nov 2022 01:29:16 -0800 (PST) Received: from ?IPV6:2003:cb:c704:9f00:a98d:4026:7c44:40fd? (p200300cbc7049f00a98d40267c4440fd.dip0.t-ipconnect.de. [2003:cb:c704:9f00:a98d:4026:7c44:40fd]) by smtp.gmail.com with ESMTPSA id d9-20020adfef89000000b00241dd5de644sm5961918wro.97.2022.11.23.01.29.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Nov 2022 01:29:16 -0800 (PST) Message-ID: <224b7bb5-6e82-7894-b5d4-44abd3c411dc@redhat.com> Date: Wed, 23 Nov 2022 10:29:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH mm-unstable v4 06/10] mm/hugetlb: convert add_hugetlb_page() to folios and add hugetlb_cma_folio() To: Sidhartha Kumar , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, willy@infradead.org, almasrymina@google.com, linmiaohe@huawei.com, hughd@google.com References: <20221118222002.82588-1-sidhartha.kumar@oracle.com> <20221118222002.82588-7-sidhartha.kumar@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20221118222002.82588-7-sidhartha.kumar@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O2BTo7Rs; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669195760; a=rsa-sha256; cv=none; b=fIWFhotu4pFaEKX9JyznDJLvNlaVquieB0OfB3/yZRkcIZgRcfLVnfYcjdcBzxZhwHwY+N c1rH4aEtl8GOnbskLtymtEzQsaVd6oKVENQJ/1Wv/Zysd4vYRvA1GXj9mFsMX5zaC+l2l6 vcEG2CJ72H9Go6otdEYH13WhieZo3n0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669195760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UK8W/f6JX0V0buNKgwaW7N3X4d6jcuFhKnmILB+4f5c=; b=mgnYc3ykgIrOxZJ5FyauajpojNvwrbtcjgOytuZs42VF66aOTzSDioaBSrhSL2RQIoKghG PpbRRZsppzvojVFYja6Zex8p/Qv1FgQL7rMqBDELoz+qjyFI56iUiV083Rv304SP10B+Xb vJrlOubEh86KTjot7VQq3jPEABAiaDw= X-Stat-Signature: eircno8xhpqt1a37bcx7iwwmzuazwf6n X-Rspamd-Server: rspam08 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=O2BTo7Rs; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Queue-Id: 8FED214000C X-HE-Tag: 1669195760-519621 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.11.22 23:19, Sidhartha Kumar wrote: > Convert add_hugetlb_page() to take in a folio, also convert > hugetlb_cma_page() to take in a folio. > > Signed-off-by: Sidhartha Kumar [...] > > @@ -1525,21 +1525,21 @@ static void add_hugetlb_page(struct hstate *h, struct page *page, > h->surplus_huge_pages_node[nid]++; > } > > - set_compound_page_dtor(page, HUGETLB_PAGE_DTOR); > - set_page_private(page, 0); > + folio_set_compound_dtor(folio, HUGETLB_PAGE_DTOR); > + folio_change_private(folio, 0); > As raised (CC'ed you), this should be s/0/NULL/ -- Thanks, David / dhildenb