From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A331C5AE59 for ; Tue, 3 Jun 2025 13:12:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D597D6B0443; Tue, 3 Jun 2025 09:12:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D30A66B0444; Tue, 3 Jun 2025 09:12:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C20896B0445; Tue, 3 Jun 2025 09:12:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A33236B0443 for ; Tue, 3 Jun 2025 09:12:32 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 533591D4EFC for ; Tue, 3 Jun 2025 13:12:32 +0000 (UTC) X-FDA: 83514128544.09.2CBF931 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id DFF9DA0007 for ; Tue, 3 Jun 2025 13:12:29 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wf9B8E+K; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748956350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+ulZTKUbjhbIdV1Dqqln7PDmK544y4yBqs+kfh4X+DM=; b=dVXfymI9UyzvPVJfCbAHPyxdSLY/qLHebFKoTXyIWfbVW/mBWjBOJxxA0+8mkPQZ93B3Ih dh0wd/TC8guvzgFI6I+OzF4rTrC61jaoE6bp0Tt5WqhMlSeo4n2LUpPq5gX+ndUdPPdRgV 0cfWe/JeBUKAaIlreB6SCondS0b8dS8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Wf9B8E+K; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748956350; a=rsa-sha256; cv=none; b=S1RiLRQ+sUPnya3axHGA55qbOabUxx8BBwmwEaK/9quWnvtWYY0qHW6dNMHLy2acLjqRAn ItzEQJJ28i6CMmY7/WNw446UpxFdsP09MKiZOwRctI6LwZmMCh5ivUxw/pX37TBZf3ZwF3 op616Cs8zVD/QX6iEQcNfMLOuTjkCXc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748956349; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+ulZTKUbjhbIdV1Dqqln7PDmK544y4yBqs+kfh4X+DM=; b=Wf9B8E+K4R7D69z9+iuHG64qii5PclAdAKt2C+nDd8gTZzcMGP8+oa1fqROQvE8KTH6Xu/ Ar2hPALRSyt+eVsGy9ZSiwrJJGzdBFUS2rBIzWjzAOmTbA27B8FzF5PgdzB+jgTZHOH+e3 15OXafsvtM/KcF8Tw2/kOEjhxXXP7FM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-niZdL0pQPr2yP9VTUVuvHA-1; Tue, 03 Jun 2025 09:12:28 -0400 X-MC-Unique: niZdL0pQPr2yP9VTUVuvHA-1 X-Mimecast-MFC-AGG-ID: niZdL0pQPr2yP9VTUVuvHA_1748956347 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-442fda1cba7so26430305e9.1 for ; Tue, 03 Jun 2025 06:12:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748956347; x=1749561147; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+ulZTKUbjhbIdV1Dqqln7PDmK544y4yBqs+kfh4X+DM=; b=BornMe59eX7g+DaIADvPB+r3gN5yHLQSIQ1FpbtVWxtFiTeypqke3aOkfW+R/lOysx iaNd2315euuteM1NrhJUn5ngdB6P5dyi1YL3EEvbysSw3XCtxpBEsYxOW/hPtTcfTkmx LN7tsj828G7R5687TzDD4fOqgC5rL8vLs3nUoFdGBlElsLZpcyMuLRDIAKItdhf0Siya /fJkYq0xllrPgs8pipd2GEKWjCIL4gf14gdDi2duU6oeF/+9QULfcZgSc6jLvrZZjarJ +++dMPbiH+Cp38pnuwXRGF1d8Z1UcHXEPZmy/GwOlHOC7q2Onwel6110VUn+33OHUlNp x2Wg== X-Forwarded-Encrypted: i=1; AJvYcCXPzUa7er8SAmsCzfvIiGrWCEKRTzN7pRQVsio+xxe24RfEBGmT+VMfA9GRSlUzFt4vqSyatXQOVA==@kvack.org X-Gm-Message-State: AOJu0Yx4NecUrvTD6l2y6XN4sllyW9q21Q151yv09bpZFnLsckl5Qj/X qOgGxVWFfb0lqLfFE4elfoukWAi1ttpmD6/mg5GieQw/rAwgP9cidj82bJr2iRdgFD0n9HMWxM0 dNBP1Qblzug9Npkh4EgbFXF5puRdt28Shbx9JxSARKDkFurERQFJm X-Gm-Gg: ASbGncuAplKrDfE6HcGY2FKa1BVQKgrnCHP+ZAjWuMFg4TMAlqmRGj8eXDfyQgdGq9J BY+AIeWjJTt4u3du8dXnAJ67O7PgorHdwcuugG6NgaNOLCNVvZh7O9YvMACQre37cbR9NlhMglv ZSwOe6guvXaqRmSQAIQ9rn6UDF1AeE4G26FBLxD5br6BSg0wdQd3lv2ggTTanFLSgqJfVlNy3PX vOwBUEoa0uxV8yUvFnZH3HLl8sxU7EZtt8rES026UsyzQuNUB2DIgQxDZ7bSQxJ5Qvw0YlvN7QR M/fDyt39FrphdqWRvMG/8CfeFlNvuOgzmEzBkQfPz2yw7rw+mk9NdqXW3IKNtm8/iLv9pGJhgr8 ynFCNGPl+jTNpE7q6KNUQc9c5rRGyXhk20KfFb/M= X-Received: by 2002:a05:600c:4e44:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-450d882b3c3mr157854825e9.2.1748956346971; Tue, 03 Jun 2025 06:12:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLwCODo0vbeCfIY0Q7QWBbg8g90s3PIR36BCX+xRaf3bQX9gx/j/s+APbDfjzq+D7FfnWurA== X-Received: by 2002:a05:600c:4e44:b0:441:b3eb:570a with SMTP id 5b1f17b1804b1-450d882b3c3mr157854375e9.2.1748956346505; Tue, 03 Jun 2025 06:12:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:f000:eec9:2b8d:4913:f32a? (p200300d82f0df000eec92b8d4913f32a.dip0.t-ipconnect.de. [2003:d8:2f0d:f000:eec9:2b8d:4913:f32a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d800658csm160327665e9.27.2025.06.03.06.12.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Jun 2025 06:12:26 -0700 (PDT) Message-ID: <223cf8fc-7743-497f-893c-37ac689af002@redhat.com> Date: Tue, 3 Jun 2025 15:12:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: reply: [RFC] pin_user_pages_fast failure count increased To: Zhaoyang Huang Cc: Hyesoo Yu , jaewon31.kim@samsung.com, John Hubbard , "zhaoyang.huang@unisoc.com" , "surenb@google.com" , "Steve.Kang@unisoc.com" , Jaewon Kim , "linux-mm@kvack.org" , Jang-Hyuck Kim References: <4e2305d6-b067-4963-b16a-367a254d22c1@nvidia.com> <20250526074845.GA2848800@tiffany> <20250526093258.GA3489925@tiffany> <20250526111744epcms1p89d664f5cebd1e690730f32b66c24e3c0@epcms1p8> <20250528012329.GA1545287@tiffany> <20250528033626.GA1607193@tiffany> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qJkLD8gJH-pwb0bLf_R5vXqT31g6aok72UC9OYaNTa8_1748956347 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DFF9DA0007 X-Stat-Signature: qzdiwitnuixiexidronj7z8qjupmg159 X-Rspam-User: X-HE-Tag: 1748956349-436467 X-HE-Meta: U2FsdGVkX18t2uxwOez9AZKlZisqML70gV5ZfdLueMEapHB5GYL50cBleGT/yvaRZxnngSny+/fIZmTh9K5aENy3bG8+B3D/Sp9FB5+0BtxoGO7ZR9OU0JncKJkFtTHDDCKrS0VJ6zKeHhdPNCokuvymTQ++lSujkP3rp0MUWXOf6Z8whDaRpGbWLoHvnxwYtzxkt4oUd0fJaYMhBed/y45nKdzrYQmUlyB1wYfianRs8eMsw9YzPC+8tsGiRIqz1BHXlCjGVxmzzgaRCbgVYgKMtp6W59fdjyZGyA7iNpNxYWffEQ2sWtppLIxW4NZjsAUJ6lqJvRbYWxImgUVmiSEXga/ObhaMtv+EULzxpstJ9dIadqzlTTZVmH8TEZHYSo/n+zuauCzX82vbA5tt4cdsXnGLeNBIhGUA/PO54CG028p/Awm6xD6LymlR4xXIxscRrw1vR+QNia4T0QGLhX6qabhtjtuJnFj0Fx/cSuhSAscnmKzzOFQIrZjt3jtzCT9tLsyV6K5T58VpJoj1Q6iUE+V+T8s+Nvk2KB0rBPp3/PZDNCGTfkI38sKNe9vvNSR6fjQ/S9FklbrkkH3xT4+soot/TEx5rNeykpOhBjIoBUQ4nliCeRcc5gpG+EHKoOcaDPefcMKzydh0VTMDp1NsGgfTWjdpmtB+8Qr4SiYwqj42IWxaSkBNvspWIM9JRwE2aswbXHSB3ooKPsIaQBUY661DcHglrCRpRE04nA4mh5Lz2nVyBlRJcCxztGKbfnfg3RMe4AAQzjleeSh10v/XjhMEiGw5WGdZevoYn9eTMD5xjV4KBmJW2fNldUyRNvhbLiETUZ/mk5HkEOwxEYjI3hOKh+IrFVXig4SFMUT7UGSzrsRWS2obdrFhA3bIhFbOhHqX4n1PD4inTuh6MqxbQx7ijbvSF2rWrZd7m4lvYE8wEfj1H7KatdCKKmEH86ahS9F0MJRM5iaruwL phsV66mF pvUmyK5igHIjUNw9DohXINuZ6Np/KVgUiwb6YX/+8GIRqKQU4hbQlTaK8gkqjxCky2jgJ1ezfVkqswV8xYB/tC68l/KUFUMxdDkZv2VicORetSI/6TmxxJ5E2hs4CgAhNHZFPYPTXx/68mPGJ3G3t0DKQLS14XvBN78/9S7QZl5i752XA2CxkmXC/qqVKTqZKRH6qx9FReZZtoCpE/1u4YmECEjiG18klSFwmzQur9uxKBgE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.05.25 12:59, Zhaoyang Huang wrote: > On Wed, May 28, 2025 at 3:55 PM David Hildenbrand wrote: >> >> On 28.05.25 05:36, Hyesoo Yu wrote: >>> On Wed, May 28, 2025 at 10:49:36AM +0800, Zhaoyang Huang wrote: >>>> On Wed, May 28, 2025 at 9:25 AM Hyesoo Yu wrote: >>>>> >>>>> On Mon, May 26, 2025 at 07:49:57PM +0800, Zhaoyang Huang wrote: >>>>> >>>>> Hello, Zhaoyang. >>>>> >>>>> I don't believe commit 1aaf8c was just intended to prevent an infinite loop. >>>>> The commit was introduced to allow pinning CMA memory in the pKVM on AOSP. >>>>> >>>>> That leads me to question whether the assumption that CMA can be long-term pinned is actually valid. >>>> That depends on the user of CMA, yes for my scenario since it worked >>>> for the guest os. For common scenario such as the file/anon mapping, >>>> the page will be judged as unpinnable for long-term and be migrated >>>> out of CMA area. >>> >>> Your scenario and the common scenarios can not be distinguished from the kernel API's perspective. >>> Even in common cases, the page may be in a non-LRU state temporiarily, and in such situations, >>> pinning CMA can lead to bugs - we've encountered multiple issues because of this. >>> >> >> Right. We just disallow long-term pinning CMA pages, because we don't >> know who the real owner is that would be okay with long-term pinning them. >> >>>>> >>>>> In my opinion, it might be more appropriate to revert that commit 1aaf8c and instead ensure >>>>> that pKVM avoids using CMA for memory that requires long-term pinning through GUP ? >>>> It is not a pkvm issue but a defect of applying FOLL_LONGTERM over >>>> non-LRU CMA pages. >>> >>> In include/linux/mm_types.h, the CMA should be migrated when FOLL_LONGTERM. >>> >>> * In the CMA case: long term pins in a CMA region would unnecessarily fragment >>> * that region. And so, CMA attempts to migrate the page before pinning, when >>> * FOLL_LONGTERM is specified. >>> >>> Given this, would it make sense to avoid using FOLL_LONGTERM in this code path ? >> >> If something is unbounded in time, FOLL_LONGTERM is the right thing to use. >> >>>>> >>>>> Alternatively, instead of changing the current logic that prevents longterm GUP from pinning CMA, >>>>> it would be better to propose a new patch that specifically addresses the pKVM scenario like adding new FOLL_flags ? >>>> I don't think so. pin_user_pages is an exported API which can't make >>>> assumptions over the caller. >>> >>> My point is not to base the patch on assumptions about the caller, >>> but to define a clear mechanism that ensures safe behavior in the intended scenario. >>> >>> For example, you can add FOLL_NO_MIGRATION and skip to migrate unpinnable pages. >> >> Not sure which exact semantics you have in mind. But failing if we would >> have to migrate might be ok. Not sure if the caller should worry about >> that, though: the caller should not have to worry about page placement >> in general. > With going over the whole thread, I think the root cause is > collect_longterm_unpinnable_folios() hit the race window between > lru_add_drain_all() and folio_isolate_lru() by chance and returned > with ret=0 which finally have the CMA page pinned, right? However, I > find the proposed patch below will fail the PKVM > scenario(FOLL_LONGTERM set with non-LRU CMA pages) again as the CMA > pages never go to LRU which will have the __gup_longterm_locked loop > in do while(ret == -EAGAIN) as it did before 1aaf8c. I think the key > point is to find a way to distinguish the temporary(on the way to LRU) > and permanent CMA pages within collect_longterm_unpinnable_folios. > > static long > check_and_migrate_movable_pages_or_folios(struct pages_or_folios *pofs) > { > + bool any_unpinnable; > LIST_HEAD(movable_folio_list); > > - collect_longterm_unpinnable_folios(&movable_folio_list, pofs); > - if (list_empty(&movable_folio_list)) > - return 0; > + any_unpinnable = > collect_longterm_unpinnable_folios(&movable_folio_list, pofs); > + if (list_empty(&movable_folio_list)) { > + if (any_unpinnable) > + pofs_unpin(pofs); > + return any_unpinnable ? -EAGAIN : 0; > + } > So, what's the status of that? We should fix it upstream (*not* caring about controversial out-of-tree pkvm issues). -- Cheers, David / dhildenb